skip creating effecter when its dbus isn't present
In the current state, we attempt to create an effecter PDR even if
the D-Bus object that is being modeled as an effecter is absent at
the time of creation.
However, this behavior may not be beneficial, as assuming that the
D-Bus backend will magically appear later does not necessarily mean
that we will be able to process it, we only process the JSON files
during the first getPDR request. Therefore, it would be more efficient
to skip creating the effecter in the absence of the D-Bus object.
This commit also addresses an error trace by including the dbus object
path when it is not present on the system, rather than the opaque
effecter id number which does not provide contextual information and
may make it harder to diagnose issues.
Change-Id: I84239c75684f611b7985df027a93ba4531f783d0
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
diff --git a/libpldmresponder/pdr_state_effecter.hpp b/libpldmresponder/pdr_state_effecter.hpp
index 78b1632..49e079c 100644
--- a/libpldmresponder/pdr_state_effecter.hpp
+++ b/libpldmresponder/pdr_state_effecter.hpp
@@ -160,8 +160,9 @@
catch (const std::exception& e)
{
error(
- "D-Bus object path does not exist, effecter ID: {EFFECTER_ID}",
- "EFFECTER_ID", static_cast<uint16_t>(pdr->effecter_id));
+ "Failed to create effecter PDR, D-Bus object '{PATH}' returned {ERROR}",
+ "PATH", objectPath, "ERROR", e);
+ continue;
}
dbusMappings.emplace_back(std::move(dbusMapping));