commit d4a14d3ae2d07c214cee0ce77b1a0f002abb3ab2
author Alexander Hansen <alexander.hansen@9elements.com> Tue Nov 18 11:43:06 2025 +0100
committer ManojKiran Eda <manojkiran.eda@gmail.com> Wed Nov 26 05:01:12 2025 +0000
tree beb0ae234d67e42cfd2ccb9c5fc64d55dd9bbc6b
parent dc36d9b62a01f78f39e16877220fa7902b0f4128

fru_parser: use PDI constants

Use PDI constants to create the mapping for DSP0257 Table 5 General
FRU Record Field Type Definitions.

Tested: Inspection only.

Change-Id: Iad999814d0dc0baa63dc2577e86d7eeab319aff6
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

libpldmresponder/fru_parser.cpp

diff --git a/libpldmresponder/fru_parser.cpp b/libpldmresponder/fru_parser.cpp
index bc04f56..c95ab7b 100644
--- a/libpldmresponder/fru_parser.cpp
+++ b/libpldmresponder/fru_parser.cpp
@@ -3,6 +3,10 @@
 #include <nlohmann/json.hpp>
 #include <phosphor-logging/lg2.hpp>
 #include <xyz/openbmc_project/Common/error.hpp>
+#include <xyz/openbmc_project/Inventory/Decorator/Asset/common.hpp>
+#include <xyz/openbmc_project/Inventory/Decorator/AssetTag/common.hpp>
+#include <xyz/openbmc_project/Inventory/Decorator/Revision/common.hpp>
+#include <xyz/openbmc_project/Inventory/Item/common.hpp>
 
 #include <filesystem>
 #include <fstream>
@@ -20,6 +24,13 @@
 using Json = nlohmann::json;
 using InternalFailure =
     sdbusplus::xyz::openbmc_project::Common::Error::InternalFailure;
+using InventoryDecoratorAsset =
+    sdbusplus::common::xyz::openbmc_project::inventory::decorator::Asset;
+using InventoryDecoratorAssetTag =
+    sdbusplus::common::xyz::openbmc_project::inventory::decorator::AssetTag;
+using InventoryDecoratorRevision =
+    sdbusplus::common::xyz::openbmc_project::inventory::decorator::Revision;
+using InventoryItem = sdbusplus::common::xyz::openbmc_project::inventory::Item;
 
 const Json emptyJson{};
 const std::vector<Json> emptyJsonList{};
@@ -87,19 +98,23 @@
         1, // encodingTypeASCII
         {
             // DSP0257 Table 5 General FRU Record Field Type Definitions
-            {"xyz.openbmc_project.Inventory.Decorator.Asset", "Model", "string",
-             2},
-            {"xyz.openbmc_project.Inventory.Decorator.Asset", "PartNumber",
-             "string", 3},
-            {"xyz.openbmc_project.Inventory.Decorator.Asset", "SerialNumber",
-             "string", 4},
-            {"xyz.openbmc_project.Inventory.Decorator.Asset", "Manufacturer",
-             "string", 5},
-            {"xyz.openbmc_project.Inventory.Item", "PrettyName", "string", 8},
-            {"xyz.openbmc_project.Inventory.Decorator.AssetTag", "AssetTag",
-             "string", 11},
-            {"xyz.openbmc_project.Inventory.Decorator.Revision", "Version",
-             "string", 10},
+            {InventoryDecoratorAsset::interface,
+             InventoryDecoratorAsset::property_names::model, "string", 2},
+            {InventoryDecoratorAsset::interface,
+             InventoryDecoratorAsset::property_names::part_number, "string", 3},
+            {InventoryDecoratorAsset::interface,
+             InventoryDecoratorAsset::property_names::serial_number, "string",
+             4},
+            {InventoryDecoratorAsset::interface,
+             InventoryDecoratorAsset::property_names::manufacturer, "string",
+             5},
+            {InventoryItem::interface,
+             InventoryItem::property_names::pretty_name, "string", 8},
+            {InventoryDecoratorAssetTag::interface,
+             InventoryDecoratorAssetTag::property_names::asset_tag, "string",
+             11},
+            {InventoryDecoratorRevision::interface,
+             InventoryDecoratorRevision::property_names::version, "string", 10},
         }};
 
     for (auto [intf, entityType] : intfToEntityType)