commit d9fb152669375b8aabf8e4c51644d194d357b16c
author Deepak Kodihalli <dkodihal@in.ibm.com> Thu Nov 28 10:06:34 2019 -0600
committer Xiaochao Ma <maxiaochao@inspur.com> Wed Dec 04 11:09:30 2019 +0800
tree a3f3999930e9de4f8446e343efd8402f05dc627c
parent bc669f1b027873a4d6cac7b1298b87a41b869f02

bios: delete persisted tables at startup

Leveraging the new registration scheme introduced in the previous
commit, delete persisted BIOS tables at PLDM daemon startup. This lets
us process new (via a firmware update, for eg) BIOS config JSONs.

Signed-off-by: Deepak Kodihalli <dkodihal@in.ibm.com>
Change-Id: I2e7759261e80afb2f0a45d8598c36838ab530d54

libpldmresponder/bios.cpp

diff --git a/libpldmresponder/bios.cpp b/libpldmresponder/bios.cpp
index c3a1c53..e9ed628 100644
--- a/libpldmresponder/bios.cpp
+++ b/libpldmresponder/bios.cpp
@@ -7,6 +7,7 @@
 #include <boost/crc.hpp>
 #include <chrono>
 #include <ctime>
+#include <filesystem>
 #include <memory>
 #include <numeric>
 #include <phosphor-logging/elog-errors.hpp>
@@ -16,9 +17,14 @@
 #include <variant>
 #include <vector>
 
+namespace fs = std::filesystem;
 using namespace pldm::responder::bios;
 using namespace bios_parser;
 
+constexpr auto stringTableFile = "stringTable";
+constexpr auto attrTableFile = "attributeTable";
+constexpr auto attrValTableFile = "attributeValueTable";
+
 namespace pldm
 {
 
@@ -74,6 +80,31 @@
 namespace bios
 {
 
+Handler::Handler()
+{
+    try
+    {
+        fs::remove(
+            fs::path(std::string(BIOS_TABLES_DIR) + "/" + stringTableFile));
+        fs::remove(
+            fs::path(std::string(BIOS_TABLES_DIR) + "/" + attrTableFile));
+        fs::remove(
+            fs::path(std::string(BIOS_TABLES_DIR) + "/" + attrValTableFile));
+    }
+    catch (const std::exception& e)
+    {
+    }
+
+    handlers.emplace(PLDM_GET_DATE_TIME,
+                     [this](const pldm_msg* request, size_t payloadLength) {
+                         return this->getDateTime(request, payloadLength);
+                     });
+    handlers.emplace(PLDM_GET_BIOS_TABLE,
+                     [this](const pldm_msg* request, size_t payloadLength) {
+                         return this->getBIOSTable(request, payloadLength);
+                     });
+}
+
 Response Handler::getDateTime(const pldm_msg* request, size_t /*payloadLength*/)
 {
     uint8_t seconds = 0;
@@ -805,11 +836,11 @@
     if (rc == PLDM_SUCCESS)
     {
         BIOSTable BIOSStringTable(
-            ((std::string(biosTablePath) + "/stringTable")).c_str());
+            (std::string(biosTablePath) + "/" + stringTableFile).c_str());
         BIOSTable BIOSAttributeTable(
-            ((std::string(biosTablePath) + "/attributeTable")).c_str());
+            (std::string(biosTablePath) + "/" + attrTableFile).c_str());
         BIOSTable BIOSAttributeValueTable(
-            ((std::string(biosTablePath) + "/attributeValueTable")).c_str());
+            (std::string(biosTablePath) + "/" + attrValTableFile).c_str());
         switch (tableType)
         {
             case PLDM_BIOS_STRING_TABLE:

libpldmresponder/bios.hpp

diff --git a/libpldmresponder/bios.hpp b/libpldmresponder/bios.hpp
index e9abed2..f9a3eff 100644
--- a/libpldmresponder/bios.hpp
+++ b/libpldmresponder/bios.hpp
@@ -51,17 +51,7 @@
 class Handler : public CmdHandler
 {
   public:
-    Handler()
-    {
-        handlers.emplace(PLDM_GET_DATE_TIME,
-                         [this](const pldm_msg* request, size_t payloadLength) {
-                             return this->getDateTime(request, payloadLength);
-                         });
-        handlers.emplace(PLDM_GET_BIOS_TABLE,
-                         [this](const pldm_msg* request, size_t payloadLength) {
-                             return this->getBIOSTable(request, payloadLength);
-                         });
-    }
+    Handler();
 
     /** @brief Handler for GetDateTime
      *