commit e5268cda7389820cfc76142218dd149c76c59fe6
author Tom Joseph <rushtotom@gmail.com> Tue Sep 07 13:04:03 2021 +0530
committer Tom Joseph <rushtotom@gmail.com> Mon Sep 13 05:59:55 2021 +0000
tree 9a3fa59af3fb4816a35cee7d3bc62d893ec700f6
parent 430aaee5013789862de586473b43d2191d492a41

Refactor the verbose tracing in PLDM

1. Add verbose tracing in requester code
2. Change the prefix of verbose tracing to "Tx: " and "Rx: "
3. Remove explicit verbose tracing flag in libpldmresponder
4. Change the prefix of pldmtool verbose tracing to "pldmtool: Tx: "
   and "pldmtool: Rx: "

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ie2c6b323e32e0828ed5ecaeb3e61943a98a2f089

pldmtool/pldm_cmd_helper.cpp

diff --git a/pldmtool/pldm_cmd_helper.cpp b/pldmtool/pldm_cmd_helper.cpp
index 0bb2941..92979c0 100644
--- a/pldmtool/pldm_cmd_helper.cpp
+++ b/pldmtool/pldm_cmd_helper.cpp
@@ -193,8 +193,11 @@
         pldmVerbose = true;
     }
 
-    Logger(pldmVerbose, "Request Message:", "");
-    printBuffer(requestMsg, pldmVerbose);
+    if (pldmVerbose)
+    {
+        std::cout << "pldmtool: ";
+        printBuffer(Tx, requestMsg);
+    }
 
     if (mctp_eid != PLDM_ENTITY_ID)
     {
@@ -211,18 +214,24 @@
                        requestMsg.size() - 2, &responseMessage,
                        &responseMessageSize);
 
-        Logger(pldmVerbose, "Response Message:", "");
         responseMsg.resize(responseMessageSize);
         memcpy(responseMsg.data(), responseMessage, responseMsg.size());
 
         free(responseMessage);
-        printBuffer(responseMsg, pldmVerbose);
+        if (pldmVerbose)
+        {
+            std::cout << "pldmtool: ";
+            printBuffer(Rx, responseMsg);
+        }
     }
     else
     {
         mctpSockSendRecv(requestMsg, responseMsg, mctpVerbose);
-        Logger(pldmVerbose, "Response Message:", "");
-        printBuffer(responseMsg, pldmVerbose);
+        if (pldmVerbose)
+        {
+            std::cout << "pldmtool: ";
+            printBuffer(Rx, responseMsg);
+        }
         responseMsg.erase(responseMsg.begin(),
                           responseMsg.begin() + 2 /* skip the mctp header */);
     }