commit e5bbe0d0555f25ac3d7ba2a7dbd99dfb59c38f45
author Tom Joseph <rushtotom@gmail.com> Fri Sep 03 17:44:54 2021 +0530
committer Tom Joseph <rushtotom@gmail.com> Fri Sep 03 18:58:19 2021 +0530
tree 2179fd2d8c58d460ed212198eb489cc8ffcde9cf
parent 4fea7a20579e2f42a95a882c9dfab40501e3bdfd

libpldm: Fix error in completion code

Signed-off-by: Tom Joseph <rushtotom@gmail.com>
Change-Id: Ie2fb9d0f1ec5b76761987aeed51192c288558c09

libpldm/firmware_update.h

diff --git a/libpldm/firmware_update.h b/libpldm/firmware_update.h
index a47d80b..a89ebbe 100644
--- a/libpldm/firmware_update.h
+++ b/libpldm/firmware_update.h
@@ -53,7 +53,7 @@
 	PLDM_FWUP_INCOMPLETE_UPDATE = 0x85,
 	PLDM_FWUP_BUSY_IN_BACKGROUND = 0x86,
 	PLDM_FWUP_CANCEL_PENDING = 0x87,
-	PLDM_FWUP_COMMAND_NOT_EXPECTED = 0x87,
+	PLDM_FWUP_COMMAND_NOT_EXPECTED = 0x88,
 	PLDM_FWUP_RETRY_REQUEST_FW_DATA = 0x89,
 	PLDM_FWUP_UNABLE_TO_INITIATE_UPDATE = 0x8A,
 	PLDM_FWUP_ACTIVATION_NOT_REQUIRED = 0x8B,

libpldm/tests/libpldm_firmware_update_test.cpp

diff --git a/libpldm/tests/libpldm_firmware_update_test.cpp b/libpldm/tests/libpldm_firmware_update_test.cpp
index 9343b89..24cbab1 100644
--- a/libpldm/tests/libpldm_firmware_update_test.cpp
+++ b/libpldm/tests/libpldm_firmware_update_test.cpp
@@ -2139,7 +2139,7 @@
     EXPECT_EQ(transferCompleteResponse1, outTransferCompleteResponse1);
 
     constexpr std::array<uint8_t, hdrSize + sizeof(completionCode)>
-        outTransferCompleteResponse2{0x04, 0x05, 0x16, 0x87};
+        outTransferCompleteResponse2{0x04, 0x05, 0x16, 0x88};
     std::array<uint8_t, hdrSize + sizeof(completionCode)>
         transferCompleteResponse2{0x00, 0x00, 0x00, 0x00};
     auto responseMsg2 =
@@ -2220,7 +2220,7 @@
     EXPECT_EQ(verifyCompleteResponse1, outVerifyCompleteResponse1);
 
     constexpr std::array<uint8_t, hdrSize + sizeof(completionCode)>
-        outVerifyCompleteResponse2{0x05, 0x05, 0x17, 0x87};
+        outVerifyCompleteResponse2{0x05, 0x05, 0x17, 0x88};
     std::array<uint8_t, hdrSize + sizeof(completionCode)>
         verifyCompleteResponse2{0x00, 0x00, 0x00, 0x00};
     auto responseMsg2 =
@@ -2327,7 +2327,7 @@
     EXPECT_EQ(applyCompleteResponse1, outApplyCompleteResponse1);
 
     constexpr std::array<uint8_t, hdrSize + sizeof(completionCode)>
-        outApplyCompleteResponse2{0x06, 0x05, 0x18, 0x87};
+        outApplyCompleteResponse2{0x06, 0x05, 0x18, 0x88};
     std::array<uint8_t, hdrSize + sizeof(completionCode)>
         applyCompleteResponse2{0x00, 0x00, 0x00, 0x00};
     auto responseMsg2 =