commit ef5c4eb0e3b0a3d01b05a6dced1d2905649efa6d
author Manojkiran Eda <manojkiran.eda@gmail.com> Thu Jul 25 22:36:41 2024 +0530
committer ManojKiran Eda <manojkiran.eda@gmail.com> Mon Jul 29 04:20:49 2024 +0000
tree 73aa9c89c59b7c8f59c5afdfaa68fc35fa46c858
parent 92af05e2c338d37738984b962c1cd624cae9d645

fix type deduction failure in gcc-14

Looks like gcc-14 has even more strict & more accurate compile time
checks and the current pldm code does not compile with gcc-14 and
reports the following error:

```
03:20:47 | ../git/platform-mc/terminus_manager.cpp: In member function 'exec::task<int> pldm::platform_mc::TerminusManager::discoverMctpTerminusTask()':
03:20:47 | ../git/platform-mc/terminus_manager.cpp:173:38: error: use of 'auto pldm::platform_mc::TerminusManager::findTerminusPtr(const pldm::MctpInfo&)' before deduction of 'auto'
03:20:47 |   173 |             auto it = findTerminusPtr(mctpInfo);
03:20:47 |       |                       ~~~~~~~~~~~~~~~^~~~~~~~~~
03:20:47 | ../git/platform-mc/terminus_manager.cpp: In member function 'void pldm::platform_mc::TerminusManager::removeMctpTerminus(const pldm::MctpInfos&)':
03:20:47 | ../git/platform-mc/terminus_manager.cpp:196:34: error: use of 'auto pldm::platform_mc::TerminusManager::findTerminusPtr(const pldm::MctpInfo&)' before deduction of 'auto'
03:20:47 |   196 |         auto it = findTerminusPtr(mctpInfo);

```

compiler seems to be confused to decude the type for `auto`. Since
we already have a type definition, directly using that to feed
some extra information to the compiler at build time.

Change-Id: I4363afb5fc5f6177c96d313ac88be22418805fbd
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

platform-mc/terminus_manager.cpp

diff --git a/platform-mc/terminus_manager.cpp b/platform-mc/terminus_manager.cpp
index 0b5cf88..1fe5c79 100644
--- a/platform-mc/terminus_manager.cpp
+++ b/platform-mc/terminus_manager.cpp
@@ -144,7 +144,8 @@
                 exec::default_task_context<void>());
 }
 
-auto TerminusManager::findTerminusPtr(const MctpInfo& mctpInfo)
+TerminiMapper::iterator
+    TerminusManager::findTerminusPtr(const MctpInfo& mctpInfo)
 {
     auto foundIter = std::find_if(termini.begin(), termini.end(),
                                   [&](const auto& terminusPair) {

platform-mc/terminus_manager.hpp

diff --git a/platform-mc/terminus_manager.hpp b/platform-mc/terminus_manager.hpp
index 42045b8..249fdff 100644
--- a/platform-mc/terminus_manager.hpp
+++ b/platform-mc/terminus_manager.hpp
@@ -152,7 +152,7 @@
      *
      *  @param[in] mctpInfos - list information of the MCTP endpoints
      */
-    auto findTerminusPtr(const MctpInfo& mctpInfo);
+    TerminiMapper::iterator findTerminusPtr(const MctpInfo& mctpInfo);
 
     /** @brief The coroutine task execute by discoverMctpTerminus()
      *