| commit | f25145fb95626ac1fe9207c369c183733ffa49d9 | [log] [tgz] |
|---|---|---|
| author | Manojkiran Eda <manojkiran.eda@gmail.com> | Sat Sep 10 01:43:39 2022 -0500 |
| committer | ManojKiran Eda <manojkiran.eda@gmail.com> | Wed Sep 21 06:02:49 2022 +0000 |
| tree | 39c7b8b612c041010b21d382d7fcc71abeecb386 | |
| parent | 67fcfdb69e2dda26e4169f60e429b7044d29a3b9 [diff] [blame] |
Fix pldmd verbosity command line argument This commit would attempt to fix the command line argument --verbose. The fact that verbose option requires an argument 0 or 1 is not particularly intuitive and a documented OpenBMC anti-pattern. https://github.com/openbmc/docs/blob/master/anti-patterns.md#non-standard-debug-application-options-and-logging Resolves : https://github.com/openbmc/pldm/issues/7 Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com> Change-Id: I50d82ce492bd815b589627d3713b1a7fc1db997b
diff --git a/pldmd/service_files/pldmd.service b/pldmd/service_files/pldmd.service index 4eaa706..4972822 100644 --- a/pldmd/service_files/pldmd.service +++ b/pldmd/service_files/pldmd.service
@@ -7,8 +7,8 @@ Restart=always Type=dbus BusName=xyz.openbmc_project.PLDM -EnvironmentFile=/etc/default/pldm_verbosity -ExecStart=/usr/bin/pldmd --verbose $VERBOSE +EnvironmentFile=-/etc/default/pldmd +ExecStart=/usr/bin/pldmd $PLDMD_ARGS [Install] WantedBy=multi-user.target