commit fc0d14dfbd52524826864c0540c5a0fb95f0ca29
author Brad Bishop <bradleyb@fuzziesquirrel.com> Tue Oct 12 19:34:20 2021 -0400
committer Brad Bishop <bradleyb@fuzziesquirrel.com> Wed Oct 13 18:23:32 2021 +0000
tree 2e9ab238aedf2e09724af3543cc01358ba31d4c9
parent e0c55c8aa9c3ebf8a0c46dc258fa7bf4121caf84

pldmd: move DbusHandler to stack

The usual reasons for heap allocations are:

- object lifetime requirements
- large size requirements
- allocation failure handling requirements

DBusHandler has none of these requirements, so putting the allocation on
the heap is unexpected and confusing to first-time readers of the code.
Moving the allocation to the stack also produces a smaller binary (sizes
shown are compressed, with default meson options and gcc 11.1):

before: 4513544
after: 4497928

Change-Id: I34569e8d311818cb36f1dedde415c776d8730113
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

pldmd/pldmd.cpp

diff --git a/pldmd/pldmd.cpp b/pldmd/pldmd.cpp
index 53dbe0b..38ee7cd 100644
--- a/pldmd/pldmd.cpp
+++ b/pldmd/pldmd.cpp
@@ -190,7 +190,7 @@
     std::unique_ptr<pldm::host_effecters::HostEffecterParser>
         hostEffecterParser;
     std::unique_ptr<DbusToPLDMEvent> dbusToPLDMEventHandler;
-    auto dbusHandler = std::make_unique<DBusHandler>();
+    DBusHandler dbusHandler;
     auto hostEID = pldm::utils::readHostEID();
     if (hostEID)
     {
@@ -203,7 +203,7 @@
 
         hostEffecterParser =
             std::make_unique<pldm::host_effecters::HostEffecterParser>(
-                &dbusImplReq, sockfd, pdrRepo.get(), dbusHandler.get(),
+                &dbusImplReq, sockfd, pdrRepo.get(), &dbusHandler,
                 HOST_JSONS_DIR, &reqHandler);
         dbusToPLDMEventHandler = std::make_unique<DbusToPLDMEvent>(
             sockfd, hostEID, dbusImplReq, &reqHandler);
@@ -212,11 +212,11 @@
 
 #ifdef OEM_IBM
     std::unique_ptr<pldm::responder::CodeUpdate> codeUpdate =
-        std::make_unique<pldm::responder::CodeUpdate>(dbusHandler.get());
+        std::make_unique<pldm::responder::CodeUpdate>(&dbusHandler);
     codeUpdate->clearDirPath(LID_STAGING_DIR);
     oemPlatformHandler = std::make_unique<oem_ibm_platform::Handler>(
-        dbusHandler.get(), codeUpdate.get(), sockfd, hostEID, dbusImplReq,
-        event, &reqHandler);
+        &dbusHandler, codeUpdate.get(), sockfd, hostEID, dbusImplReq, event,
+        &reqHandler);
     codeUpdate->setOemPlatformHandler(oemPlatformHandler.get());
     invoker.registerHandler(PLDM_OEM, std::make_unique<oem_ibm::Handler>(
                                           oemPlatformHandler.get(), sockfd,
@@ -232,7 +232,7 @@
     // handled. To enable building FRU table, the FRU handler is passed to the
     // Platform handler.
     auto platformHandler = std::make_unique<platform::Handler>(
-        dbusHandler.get(), PDR_JSONS_DIR, pdrRepo.get(), hostPDRHandler.get(),
+        &dbusHandler, PDR_JSONS_DIR, pdrRepo.get(), hostPDRHandler.get(),
         dbusToPLDMEventHandler.get(), fruHandler.get(),
         oemPlatformHandler.get(), event, true);
 #ifdef OEM_IBM