oem-ibm: Improving logs (lg2)
This commit corrects the severity level of logs and also formats the
message string, fixing the ill-defined message string of the logs as
mentioned in the anti-pattern document [1]. Additionally, based on the
requirement this commit adds more debug information to logs.
[1]: https://github.com/openbmc/docs/blob/master/anti-patterns.md#ill-defined-data-structuring-in-lg2-message-strings
Change-Id: I24ca21de35d5a1a9b3cc64b28a149e4c213055f9
Signed-off-by: Riya Dixit <riyadixitagra@gmail.com>
diff --git a/oem/ibm/libpldmresponder/file_table.cpp b/oem/ibm/libpldmresponder/file_table.cpp
index b030f82..d0b06bc 100644
--- a/oem/ibm/libpldmresponder/file_table.cpp
+++ b/oem/ibm/libpldmresponder/file_table.cpp
@@ -17,15 +17,16 @@
std::ifstream jsonFile(fileTableConfigPath);
if (!jsonFile.is_open())
{
- error("File table config file does not exist, FILE={TABLE_CONFIG_PATH}",
- "TABLE_CONFIG_PATH", fileTableConfigPath.c_str());
+ error("File table config file '{PATH}' does not exist", "PATH",
+ fileTableConfigPath);
return;
}
auto data = Json::parse(jsonFile, nullptr, false);
if (data.is_discarded())
{
- error("Parsing config file failed");
+ error("Failed to parse config file '{PATH}'", "PATH",
+ fileTableConfigPath);
return;
}