Avoid freeing instance IDs acquired by other apps
With all applications now utilizing the transport APIs built on top of
libpldm, instance ID allocation and management are consistently handled
through a shared mechanism. These updated APIs also allow applications
to explicitly free their own instance IDs once they're done using them.
As a result, pldmd no longer needs to free instance IDs on behalf of
other applications. Furthermore, when pldmd is operating over AF_MCTP,
it cannot observe or intercept PLDM traffic initiated by other
applications. In such cases, any attempt by pldmd to manage instance
IDs for external requests becomes redundant and effectively dead code.
Change-Id: I5226cc4fa24030583ddbd000ff944a16c5b2e7a6
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
diff --git a/requester/handler.hpp b/requester/handler.hpp
index 3677243..723623b 100644
--- a/requester/handler.hpp
+++ b/requester/handler.hpp
@@ -398,14 +398,6 @@
/* try to send new request if the endpoint is free */
pollEndpointQueue(eid);
}
- else
- {
- // Got a response for a PLDM request message not registered with the
- // request handler, so freeing up the instance ID, this can be other
- // OpenBMC applications relying on PLDM D-Bus apis like
- // openpower-occ-control and softoff
- instanceIdDb.free(key.eid, key.instanceId);
- }
}
/** @brief Wrap registerRequest with coroutine API.