commit 1800045e99e384b966f3b8432d8659e082b91d1b
author Patrick Williams <patrick@stwcx.xyz> Fri Nov 01 15:53:33 2024 -0400
committer Patrick Williams <patrick@stwcx.xyz> Fri Nov 01 15:53:35 2024 -0400
tree 3c7f70b31fd34c5038ec630c1ae9890f1bed19a1
parent 7ffcdaac41a0464954a34fa853ab8da54fb9df0d

sdbus++: events: schema: explicitly prohibit unspecified properties

Modify the schema so that properties that do not belong are called
out as a schema violation.  It was easy for someone to accidentally
add 'severity' on events, which should only be specified on errors.
Adding it to the schema to prohibit makes it clearer what the
expectations are.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3decce5cddce2ce7215f7351339157a2597fdb0b

tools/sdbusplus/schemas/events.schema.yaml

diff --git a/tools/sdbusplus/schemas/events.schema.yaml b/tools/sdbusplus/schemas/events.schema.yaml
index 26e8816..1ee280b 100644
--- a/tools/sdbusplus/schemas/events.schema.yaml
+++ b/tools/sdbusplus/schemas/events.schema.yaml
@@ -58,9 +58,14 @@
             - oneOf:
                   - $ref: "#/$defs/redfish-messages"
                   - $ref: "#/$defs/redfish-map"
+        unevaluatedProperties: false
     error:
         type: object
-        $ref: "#/$defs/event"
+        allOf:
+            - $ref: "#/$defs/base-event"
+            - oneOf:
+                  - $ref: "#/$defs/redfish-messages"
+                  - $ref: "#/$defs/redfish-map"
         properties:
             severity:
                 enum:
@@ -80,6 +85,7 @@
         required:
             - severity
             - errno
+        unevaluatedProperties: false
     redfish-messages:
         type: object
         properties: