commit 1d3a0390650f162b30d360d1ab50e04fd65ceb29
author Ed Tanous <edtanous@google.com> Mon Mar 20 08:48:29 2023 -0700
committer Patrick Williams <patrick@stwcx.xyz> Mon Mar 20 17:53:02 2023 +0000
tree 230686e66d23ac3e3c47b7025f8e96d607ca024c
parent 6993aa4de4ee5a72fe86ebdfa650d836df6bdefe

Remove message copy

This was previously making an unneeded copy to try to work around some
undefined behavior bugs.  It is no longer needed.

Change-Id: Ic2427d37161087880e6fdcf6e1b9aa4210f15d1e
Signed-off-by: Ed Tanous <edtanous@google.com>

include/sdbusplus/asio/object_server.hpp

diff --git a/include/sdbusplus/asio/object_server.hpp b/include/sdbusplus/asio/object_server.hpp
index e45bfae..a8493c5 100644
--- a/include/sdbusplus/asio/object_server.hpp
+++ b/include/sdbusplus/asio/object_server.hpp
@@ -186,25 +186,24 @@
   private:
     void after_spawn(message_t b, boost::asio::yield_context yield)
     {
-        message_t mcpy{std::move(b)};
         std::optional<message_t> err{};
 
         try
         {
-            expandCall(yield, mcpy);
+            expandCall(yield, b);
         }
         catch (const sdbusplus::exception::SdBusError& e)
         {
             // Catch D-Bus error explicitly called by method handler
-            err = mcpy.new_method_errno(e.get_errno(), e.get_error());
+            err = b.new_method_errno(e.get_errno(), e.get_error());
         }
         catch (const sdbusplus::exception_t& e)
         {
-            err = mcpy.new_method_error(e);
+            err = b.new_method_error(e);
         }
         catch (...)
         {
-            err = mcpy.new_method_errno(-EIO);
+            err = b.new_method_errno(-EIO);
         }
 
         if (err)