Make interface and object non-movable
The generated server.hpp for interfaces are non-movable, so there is no
need to make interface and object movable.
Besides, the object was movable but it was broken, that it does not
handle the move correctly, so if an object is moved, both objects will
invoke the destructor and the object will be released twice.
Tested: Verify CI passes, and Witherspoon builds OK.
Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I772269a5e1a9cdb093cc96fa51b06a5782a6e141
diff --git a/sdbusplus/server/interface.hpp b/sdbusplus/server/interface.hpp
index 2b05931..7dd4284 100644
--- a/sdbusplus/server/interface.hpp
+++ b/sdbusplus/server/interface.hpp
@@ -37,15 +37,15 @@
* Not allowed:
* - Default constructor to avoid nullptrs.
* - Copy operations due to internal unique_ptr.
- * Allowed:
* - Move operations.
+ * Allowed:
* - Destructor.
*/
interface() = delete;
interface(const interface&) = delete;
interface& operator=(const interface&) = delete;
- interface(interface&&) = default;
- interface& operator=(interface&&) = default;
+ interface(interface&&) = delete;
+ interface& operator=(interface&&) = delete;
/** @brief Register the (path, interface, vtable) as a dbus object.
*
diff --git a/sdbusplus/server/object.hpp b/sdbusplus/server/object.hpp
index afb031e..add9cd2 100644
--- a/sdbusplus/server/object.hpp
+++ b/sdbusplus/server/object.hpp
@@ -97,15 +97,15 @@
* Not allowed:
* - Default constructor to avoid nullptrs.
* - Copy operations due to internal unique_ptr.
- * Allowed:
* - Move operations.
+ * Allowed:
* - Destructor.
*/
object() = delete;
object(const object&) = delete;
object& operator=(const object&) = delete;
- object(object&&) = default;
- object& operator=(object&&) = default;
+ object(object&&) = delete;
+ object& operator=(object&&) = delete;
enum class action
{