| commit | 3c2cea23d6d9164cf0cf582de66eb9d2a211de81 | [log] [tgz] |
|---|---|---|
| author | Ed Tanous <edtanous@google.com> | Mon Apr 03 16:26:04 2023 -0700 |
| committer | Patrick Williams <patrick@stwcx.xyz> | Tue Apr 04 11:45:30 2023 +0000 |
| tree | 1af03bec288eebbf811f007d2ce98e1e43793d35 | |
| parent | 6db7a6d01517ef13f5a16fd0f8484a65879132c2 [diff] |
Fix behavior of const_ properties In c9eb7e3bdc5e4ff59f38c0184d17ce3a02e680d2, a regression was introduced that would prevent the registration of properties using the sdbusplus::vtable::property_::const_ flag, which defines a parameter as not being modifiable. Unfortunately, sd_bus has a check to determine that if the non-modifiable flag was set, it would ensure that the SD_BUS_PROPERTY method was being used without a setter. Even if the setter is passed in as nullptr, sd-bus still throws an error unless the correct overload is used. This commit makes two adjustments. First, rather than directing sdbsplus::asio::object_server::property_r() to a nop method, it sets the method to nullptr. Then at vtable registration time, that function objects filledness is used to determine which overload of property_o should be called. There is one usage of const_ within the codebase, and it is within the telemetry daemon. Tested: Telemetry daemon now launches its DBus objects without issue in qemu, the environment where this issue was found. Change-Id: I13944695ccd50371fe266048538bc5cceeaf18fd Signed-off-by: Ed Tanous <edtanous@google.com>
sdbusplus contains two parts:
The sdbusplus library requires sd-bus, which is contained in libsystemd.
The sdbus++ application requires Python 3 and the Python libraries mako and inflection.
The sdbusplus library is built using meson.
meson build
cd build
ninja
ninja test
ninja install
Optionally, building the tests and examples can be disabled by passing -Dtests=disabled and -Dexamples=disabled respectively to meson.
The sdbus++ application is installed as a standard Python package using setuptools.
cd tools ./setup.py install
The sdbusplus library builds on top of the sd-bus library to create a modern C++ API for D-Bus. The library attempts to be as lightweight as possible, usually compiling to exactly the sd-bus API calls that would have been necessary, while also providing compile-time type-safety and memory leak protection afforded by modern C++ practices.
Consider the following code:
auto b = bus::new_default_system(); auto m = b.new_method_call("org.freedesktop.login1", "/org/freedesktop/login1", "org.freedesktop.login1.Manager", "ListUsers"); auto reply = b.call(m); std::vector<std::tuple<uint32_t, std::string, message::object_path>> users; reply.read(users); // or auto users = reply.unpack< std::vector<std::tuple<uint32_t, std::string, message::object_path>>>();
In a few, relatively succinct, C++ lines this snippet will create a D-Bus connection to the system bus, and call the systemd login manager to get a list of active users. The message and bus objects are automatically freed when they leave scope and the message format strings are generated at compile time based on the types being read. Compare this to the corresponding server code within logind.
In general, the library attempts to mimic the naming conventions of the sd-bus library: ex. sd_bus_call becomes sdbusplus::bus::call, sd_bus_get_unique_name becomes sdbusplus::bus::get_unique_name, sd_bus_message_get_signature becomes sdbusplus::message::get_signature, etc. This allows a relatively straight-forward translation back to the sd-bus functions for looking up the manpage details.
sdbusplus also contains a bindings generator tool: sdbus++. The purpose of a bindings generator is to reduce the boilerplate associated with creating D-Bus server or client applications. When creating a server application, rather than creating sd-bus vtables and writing C-style functions to handle each vtable callback, you can create a small YAML file to define your D-Bus interface and the sdbus++ tool will create a C++ class that implements your D-Bus interface. This class has a set of virtual functions for each method and property, which you can overload to create your own customized behavior for the interface.
There are currently two types of YAML files: interface and error. Interfaces are used to create server and client D-Bus interfaces. Errors are used to define C++ exceptions which can be thrown and will automatically turn into D-Bus error responses.
[[D-Bus client bindings are not yet implemented. See openbmc/openbmc#851.]]
The path of your file will be the interface name. For example, for an interface org.freedesktop.Example, you would create the files org/freedesktop/Example.interface.yaml and org/freedesktop/Example.errors.yaml] for interfaces and errors respectively. These can then be used to generate the server and error bindings:
sdbus++ interface server-header org.freedesktop.Example > \ org/freedesktop/Example/server.hpp sdbus++ interface server-cpp org.freedesktop.Example > \ org/freedesktop/Example/server.cpp sdbus++ error exception-header org.freedesktop.Example > \ org/freedesktop/Example/error.hpp \ sdbus++ error exception-cpp org.freedesktop.Example > \ org/freedesktop/Example/error.cpp
Markdown-based documentation can also be generated from the interface and exception files:
sdbus++ interface markdown org.freedesktop.Example > \ org/freedesktop/Example.md sdbus++ error markdown org.freedesktop.Example >> \ org/freedesktop/Example.md
See the example/meson.build for more details.
Installation of sdbusplus bindings on a custom distribution requires a few packages to be installed prior. Although these packages are the same for several distributions the names of these packages do differ. Below are the packages needed for Ubuntu and Fedora.
sudo apt install git meson libtool pkg-config g++ libsystemd-dev \ python3 python3-pip python3-yaml python3-mako python3-inflection
sudo dnf install git meson libtool gcc-c++ pkgconfig systemd-devel \ python3 python3-pip python3-yaml python3-mako
Install the inflection package using the pip utility (on Fedora)
pip3 install inflection