tree 46aebb51f513fe8e62282255ee2c63756abac455
parent c9978e3bfceb8a6ba301e9a51f0cedba0de6bbf0
author Patrick Williams <patrick@stwcx.xyz> 1618933827 -0500
committer Patrick Williams <patrick@stwcx.xyz> 1618948850 +0000

sdbuspp_support: correct return value from method callbacks

It was reported that even successful method calls were observed with
dbus-monitor to have an error string:

    error_name=org.freedesktop.DBus.Error.UnknownMethod reply_serial=2
       string "Unknown method DeleteAll or interface
               xyz.openbmc_project.Collection.DeleteAll."

Looking at the sd-bus code for this string, I noticed that there is a
for-loop that iterates through the vtable and continues looking for
additional vtable callbacks if a 0 is returned from a callback.  At
the end of the loop, this string is added.

This behavior is also mentioned in the man page for vtable entries:

    When a request is received, any associated callbacks are called
    sequentially until a callback returns a non-zero integer. Return
    zero from a callback to give other callbacks the chance to process
    the request.

`method_callback` in sdbuspp_support/server.hpp was returning a 0 instead
of a positive integer indicating success.  Modify the support callbacks
so that they all return a non-zero return to indicate non-delegation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3f3239951b873c42527d130b66e53d52c97427e1