tree a69051c51a016fbe9bd24d2ad07b1af14fb5df29
parent aa2e7f7170327511110a448c1314a1ef2195ee25
author Patrick Williams <patrick@stwcx.xyz> 1484236817 -0600
committer Patrick Williams <patrick@stwcx.xyz> 1484316897 -0600

message: Change conversion ctor to inc ref-count

There are cases of calling the message constructor where the
ownership of the raw pointer is transfered and others where it
is duplicated.  The ownership-transfer use-cases are likely all
embedded within sdbusplus itself and the ownership-duplicate
cases tend to be done by external users.  This causes the current
API to be bug-prone as it requires something like:

    sdbusplus::message::message(sd_bus_message_ref(m));

Change the conversion constructor to not require the external _ref
call and instead add a new constructor that bypasses the ref.

Thus, the calling conventions now look like this:

    Ownership-duplicate:
       sdbusplus::message::message(m); // calls _ref.
    Ownership-transfer:
       sdbusplus::message::message(m, std::false_type()); // no _ref.

Resolves openbmc/openbmc#950.

Change-Id: Ia1ae527c4d1235b1625368cfffeb4ed495457768
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>