tree f53026b0112a2edc932756a3b4f3a8117633f8d9
parent 656545416ced84e90853be84c54c8e301fccb904
author William A. Kennington III <wak@google.com> 1539296588 -0700
committer William A. Kennington III <wak@google.com> 1539297074 -0700

Fix invalid uses of sd_bus_error_set_const

sd_bus_error_set_const takes pointers to c-style strings as arguments
which populate its name and message. This function does not take any
ownership of the name or message, requiring the to live beyond the
lifetime of the error. Since we are destroying the error object as soon
as we leave the catch blocks, we are destroying the strings passed to
the sd_bus_error. This violates the lifetime guarantee.

Instead, use the sd_bus_error_set method which copies the strings. We
know that the callers of these callbacks free the errors by inspecting
the libsystemd code.

Tested:
    Run through unit tests which still pass

Change-Id: Ifa1533fc4c41db070f5bf2901581e9f5680cabfc
Signed-off-by: William A. Kennington III <wak@google.com>