commit 869230c608eaa7d3a4c401ce028661040830d567
author Patrick Williams <patrick@stwcx.xyz> Thu Dec 12 09:23:00 2024 -0500
committer Jayanth Othayoth <ojayanth@gmail.com> Sun Dec 15 08:39:21 2024 -0600
tree cc7a21a127ad022bd73b0a1979e9fbd89cb87dbf
parent 4638a2e9549f9b0d860495badb7cc70c6402cade

async: fdio: remove unused member

clang warns about an unused private field ('fd') because it is
a capture-only member.  There isn't any reason to keep the fd
around once the underlying sd_event has been created, so remove
it as a member.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I176b2c4b53bbd7e4bb4bc9a9594f5816ee1bda2e

include/sdbusplus/async/fdio.hpp

diff --git a/include/sdbusplus/async/fdio.hpp b/include/sdbusplus/async/fdio.hpp
index d6f7673..3eb6594 100644
--- a/include/sdbusplus/async/fdio.hpp
+++ b/include/sdbusplus/async/fdio.hpp
@@ -34,7 +34,6 @@
     friend fdio_ns::fdio_completion;
 
   private:
-    int fd;
     event_source_t source;
     std::mutex lock{};
     fdio_ns::fdio_completion* complete{nullptr};

src/async/fdio.cpp

diff --git a/src/async/fdio.cpp b/src/async/fdio.cpp
index 641d6a6..e1c3ddc 100644
--- a/src/async/fdio.cpp
+++ b/src/async/fdio.cpp
@@ -2,7 +2,7 @@
 
 namespace sdbusplus::async
 {
-fdio::fdio(context& ctx, int fd) : context_ref(ctx), fd(fd)
+fdio::fdio(context& ctx, int fd) : context_ref(ctx)
 {
     static auto eventHandler =
         [](sd_event_source*, int, uint32_t, void* data) noexcept {