commit 9688ed6855483f2ba9f09f70f416f412d28c520a
author Ed Tanous <edtanous@google.com> Fri Jan 06 13:17:25 2023 -0800
committer Patrick Williams <patrick@stwcx.xyz> Sat Jan 07 05:25:13 2023 +0000
tree 495cd235bc8a4dc6de2d76ad5505eb4277debe4e
parent 60a943053bce11171e7959af7159a3246f4fc708

Add override keyword everywhere it's required

Clang catches some of these.  Add override keywords where we override
functions, per cpp core guidelines.

Change-Id: I66f9e6dff53e07f0057d86a806701593be16b188
Signed-off-by: Ed Tanous <edtanous@google.com>

include/sdbusplus/server/object.hpp

diff --git a/include/sdbusplus/server/object.hpp b/include/sdbusplus/server/object.hpp
index dfc20c8..c3eaeea 100644
--- a/include/sdbusplus/server/object.hpp
+++ b/include/sdbusplus/server/object.hpp
@@ -203,7 +203,7 @@
         check_action(act);
     }
 
-    ~object()
+    ~object() override
     {
         if (__sdbusplus_server_object_signalstate != action::emit_no_signals)
         {

include/sdbusplus/test/sdbus_mock.hpp

diff --git a/include/sdbusplus/test/sdbus_mock.hpp b/include/sdbusplus/test/sdbus_mock.hpp
index 01dc819..0f74f3e 100644
--- a/include/sdbusplus/test/sdbus_mock.hpp
+++ b/include/sdbusplus/test/sdbus_mock.hpp
@@ -11,7 +11,7 @@
 class SdBusMock : public SdBusInterface
 {
   public:
-    virtual ~SdBusMock(){};
+    virtual ~SdBusMock() override {}
 
     MOCK_METHOD(int, sd_bus_add_object_manager,
                 (sd_bus*, sd_bus_slot**, const char*), (override));

test/async/context.cpp

diff --git a/test/async/context.cpp b/test/async/context.cpp
index 03480c9..7f821ed 100644
--- a/test/async/context.cpp
+++ b/test/async/context.cpp
@@ -4,7 +4,7 @@
 
 struct Context : public testing::Test
 {
-    ~Context() noexcept = default;
+    ~Context() noexcept override = default;
 
     void TearDown() override
     {

test/timer.cpp

diff --git a/test/timer.cpp b/test/timer.cpp
index 48152b0..26ad992 100644
--- a/test/timer.cpp
+++ b/test/timer.cpp
@@ -31,7 +31,7 @@
     }
 
     // Gets called as part of each TEST_F destruction
-    ~TimerTest()
+    ~TimerTest() override
     {
         events = sd_event_unref(events);
     }
@@ -74,7 +74,7 @@
     }
 
     // Gets called as part of each TEST_F destruction
-    ~TimerTestCallBack()
+    ~TimerTestCallBack() override
     {
         events = sd_event_unref(events);
     }