commit a412ca8f94c110239b578c61c6f73b56095f8597
author Ed Tanous <edtanous@google.com> Wed Apr 19 09:40:24 2023 -0700
committer Ed Tanous <edtanous@google.com> Wed Apr 19 09:43:21 2023 -0700
tree 70ba5876f53c6caadaa3e9bcdb59b84c5ac3467b
parent f6cc836dde880f14b69513988b85e258d5b87caf

Remove duplicate std::move

In the effort to remove copies, we removed one that was neccesary, given
that this variable is std::moved twice.  This generally doesn't seem to
cause an issue in upstream code, given that most upstream handlers are
trivial, but there have been reports of this failing for more complex
handlers, passing non-trivial types.  This should correct it by moving
back to a copy.

Change-Id: I1342daf6a41b54b850f279aec696edbf0fd1e229
Signed-off-by: Ed Tanous <edtanous@google.com>

include/sdbusplus/asio/object_server.hpp

diff --git a/include/sdbusplus/asio/object_server.hpp b/include/sdbusplus/asio/object_server.hpp
index 02d2111..e8590b6 100644
--- a/include/sdbusplus/asio/object_server.hpp
+++ b/include/sdbusplus/asio/object_server.hpp
@@ -458,8 +458,8 @@
             name,
             callback_get_instance<PropertyType, CallbackTypeGet>(
                 propertyPtr, std::move(getFunction)),
-            callback_set_message_instance<PropertyType>(propertyPtr,
-                                                        std::move(setFunction)),
+            callback_set_message_instance<PropertyType>(
+                propertyPtr, CallbackTypeSet(setFunction)),
             callback_set_value_instance<PropertyType>(propertyPtr,
                                                       std::move(setFunction)),