tests: Fix memory leak from sd_bus calls
Some of the calls into sd_bus leak memory because they never unreference
the bus or messages. Fix this so we can eventually enable leak checking
from valgrind.
Tested:
Ran through valgrind and the errors went away.
Change-Id: Icc3d5d0860b3852401219c1ca511a1bc26aa1c48
Signed-off-by: William A. Kennington III <wak@google.com>
diff --git a/test/message/read.cpp b/test/message/read.cpp
index cd31b61..4eb6437 100644
--- a/test/message/read.cpp
+++ b/test/message/read.cpp
@@ -28,7 +28,8 @@
// Thread to run the dbus server.
void* server(void* b)
{
- auto bus = sdbusplus::bus::bus(reinterpret_cast<sdbusplus::bus::busp_t>(b));
+ auto bus = sdbusplus::bus::bus(reinterpret_cast<sdbusplus::bus::busp_t>(b),
+ std::false_type());
while (1)
{
@@ -58,12 +59,16 @@
<< std::endl;
}
// Reply to client.
- sd_bus_reply_method_return(m.release(), nullptr);
+ auto sd_m = m.release();
+ sd_bus_reply_method_return(sd_m, nullptr);
+ sd_bus_message_unref(sd_m);
}
else if (m.is_method_call(INTERFACE, QUIT_METHOD))
{
// Reply and exit.
- sd_bus_reply_method_return(m.release(), nullptr);
+ auto sd_m = m.release();
+ sd_bus_reply_method_return(sd_m, nullptr);
+ sd_bus_message_unref(sd_m);
break;
}
}