commit b68700e87a670e6d18bab2ca59d12420b777ac7e
author Patrick Williams <patrick@stwcx.xyz> Thu Sep 09 06:05:15 2021 -0500
committer Patrick Williams <patrick@stwcx.xyz> Fri Sep 10 13:44:16 2021 -0500
tree 5a4d0cb91ea7a3e2e9f3312d185d5abd807024ec
parent dfb5642201699dc42a7dda12d72718a8b9568151

exception: make base get_errno pure virtual

In order to enforce that exception authors make an explicit decision
on the errno, switch get_errno to pure virtual.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I647ef6802149b1092b115fdc78bb9f3e5e67bfa0

include/sdbusplus/exception.hpp

diff --git a/include/sdbusplus/exception.hpp b/include/sdbusplus/exception.hpp
index 65f85c1..2977d4d 100644
--- a/include/sdbusplus/exception.hpp
+++ b/include/sdbusplus/exception.hpp
@@ -19,7 +19,7 @@
 {
     virtual const char* name() const noexcept = 0;
     virtual const char* description() const noexcept = 0;
-    virtual int get_errno() const noexcept;
+    virtual int get_errno() const noexcept = 0;
 };
 
 /** base exception class for all errors created by the sdbus++ generator */

src/exception.cpp

diff --git a/src/exception.cpp b/src/exception.cpp
index 4fa5135..df0baa5 100644
--- a/src/exception.cpp
+++ b/src/exception.cpp
@@ -14,11 +14,6 @@
 namespace exception
 {
 
-int exception::get_errno() const noexcept
-{
-    return EIO;
-}
-
 int generated_exception::get_errno() const noexcept
 {
     return EIO;