Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / sdbusplus / d0f578dfd637da535e4fe11f0e581bb08fc5c79f
commitd0f578dfd637da535e4fe11f0e581bb08fc5c79f[log] [tgz]
authorArun Lal K M <arun.lal@intel.com>Mon Apr 17 06:35:56 2023 +0000
committerSmriti-Ayushi <smriti.ayushi@linux.intel.com>Wed Apr 26 16:08:30 2023 +0530
treedb09e7c61139872b0ccde8fc67d818f45bbfad63
parent1caa5e8a5ad9e9f26ddf2effe095ba1670911bc1 [diff]
Make register_method accept 'Flags'

Problem statement:
SD_BUS_METHOD() takes 'Flags' as one of it's arguments.
The flags parameter is used to specify a combination of D-Bus annotations.
Reference https://man7.org/linux/man-pages/man3/sd_bus_add_object.3.html

'register_method' function in file sdbusplus\include\sdbusplus\asio\object_server.hpp
makes the following call

method_callbacks_.emplace_back(name, std::move(func), argType.data(),
    resultType.data());

This calls ends up in following function which calls SD_BUS_METHOD

constexpr vtable_t method(const char* member, const char* signature,
    const char* result, sd_bus_message_handler_t handler,
    decltype(vtable_t::flags) flags)
{
    return vtable_t SD_BUS_METHOD(member, signature, result, handler, flags);
}

Problem is register_method does not take 'Flags' as one of it's arguments.
So SD_BUS_METHOD is called with flags = 0, default value.

Proposed solution:
Add 'Flags' as one of the arguments in register_method function.

Tested:
By passing flag SD_BUS_VTABLE_UNPRIVILEGED to register_method function
and making sure the property of flag is reflected in dbus.

Change-Id: I4845d3b7e3619c8b10bed9db0d92a90ec09578b4
Signed-off-by: Arun Lal K M <arun.lal@intel.com>
1 file changed
tree: db09e7c61139872b0ccde8fc67d818f45bbfad63
  1. docs/
  2. example/
  3. include/
  4. src/
  5. subprojects/
  6. test/
  7. tools/
  8. .clang-format
  9. .flake8
  10. .gitignore
  11. .isort.cfg
  12. .markdownlint.yaml
  13. .prettierrc.yaml
  14. .shellcheck
  15. .shellcheckrc
  16. LICENSE
  17. meson.build
  18. meson_options.txt
  19. OWNERS
  20. pyproject.toml
  21. README.md
  22. setup.cfg
README.md

sdbusplus

sdbusplus contains two parts:

  1. A C++ library (libsdbusplus) for interacting with D-Bus, built on top of the sd-bus library from systemd.
  2. A tool (sdbus++) to generate C++ bindings to simplify the development of D-Bus-based applications.

Dependencies

The sdbusplus library requires sd-bus, which is contained in libsystemd.

The sdbus++ application requires Python 3 and the Python libraries mako and inflection.

Building

The sdbusplus library is built using meson.

meson build
cd build
ninja
ninja test
ninja install

Optionally, building the tests and examples can be disabled by passing -Dtests=disabled and -Dexamples=disabled respectively to meson.

The sdbus++ application is installed as a standard Python package using setuptools.

cd tools
./setup.py install

C++ library

The sdbusplus library builds on top of the sd-bus library to create a modern C++ API for D-Bus. The library attempts to be as lightweight as possible, usually compiling to exactly the sd-bus API calls that would have been necessary, while also providing compile-time type-safety and memory leak protection afforded by modern C++ practices.

Consider the following code:

auto b = bus::new_default_system();
auto m = b.new_method_call("org.freedesktop.login1",
                           "/org/freedesktop/login1",
                           "org.freedesktop.login1.Manager",
                           "ListUsers");
auto reply = b.call(m);

std::vector<std::tuple<uint32_t, std::string, message::object_path>> users;
reply.read(users);
    // or
auto users = reply.unpack<
    std::vector<std::tuple<uint32_t, std::string, message::object_path>>>();

In a few, relatively succinct, C++ lines this snippet will create a D-Bus connection to the system bus, and call the systemd login manager to get a list of active users. The message and bus objects are automatically freed when they leave scope and the message format strings are generated at compile time based on the types being read. Compare this to the corresponding server code within logind.

In general, the library attempts to mimic the naming conventions of the sd-bus library: ex. sd_bus_call becomes sdbusplus::bus::call, sd_bus_get_unique_name becomes sdbusplus::bus::get_unique_name, sd_bus_message_get_signature becomes sdbusplus::message::get_signature, etc. This allows a relatively straight-forward translation back to the sd-bus functions for looking up the manpage details.

Binding generation tool

sdbusplus also contains a bindings generator tool: sdbus++. The purpose of a bindings generator is to reduce the boilerplate associated with creating D-Bus server or client applications. When creating a server application, rather than creating sd-bus vtables and writing C-style functions to handle each vtable callback, you can create a small YAML file to define your D-Bus interface and the sdbus++ tool will create a C++ class that implements your D-Bus interface. This class has a set of virtual functions for each method and property, which you can overload to create your own customized behavior for the interface.

There are currently two types of YAML files: interface and error. Interfaces are used to create server and client D-Bus interfaces. Errors are used to define C++ exceptions which can be thrown and will automatically turn into D-Bus error responses.

[[D-Bus client bindings are not yet implemented. See openbmc/openbmc#851.]]

Generating bindings

How to use tools/sdbus++

The path of your file will be the interface name. For example, for an interface org.freedesktop.Example, you would create the files org/freedesktop/Example.interface.yaml and org/freedesktop/Example.errors.yaml] for interfaces and errors respectively. These can then be used to generate the server and error bindings:

sdbus++ interface server-header org.freedesktop.Example > \
    org/freedesktop/Example/server.hpp
sdbus++ interface server-cpp org.freedesktop.Example > \
    org/freedesktop/Example/server.cpp
sdbus++ error exception-header org.freedesktop.Example > \
    org/freedesktop/Example/error.hpp \
sdbus++ error exception-cpp org.freedesktop.Example > \
    org/freedesktop/Example/error.cpp

Markdown-based documentation can also be generated from the interface and exception files:

sdbus++ interface markdown org.freedesktop.Example > \
    org/freedesktop/Example.md
sdbus++ error markdown org.freedesktop.Example >> \
    org/freedesktop/Example.md

See the example/meson.build for more details.

Installing sdbusplus on custom distributions

Installation of sdbusplus bindings on a custom distribution requires a few packages to be installed prior. Although these packages are the same for several distributions the names of these packages do differ. Below are the packages needed for Ubuntu and Fedora.

Installation on Ubuntu

sudo apt install git meson libtool pkg-config g++ libsystemd-dev \
    python3 python3-pip python3-yaml python3-mako python3-inflection

Installation on Fedora

sudo dnf install git meson libtool gcc-c++ pkgconfig systemd-devel \
    python3 python3-pip python3-yaml python3-mako

Install the inflection package using the pip utility (on Fedora)

pip3 install inflection