tree 11d335724ef3883c794d09efb758d0c376c1b413
parent 3e20fa8bd0faae5f2115f8c012c50ce5231de90f
author Patrick Williams <patrick@stwcx.xyz> 1683834243 -0500
committer Patrick Williams <patrick@stwcx.xyz> 1683834245 -0500

asio: connection: fix clang-tidy warning

With clang-16, numerous users of asio::connection are failing
clang-tidy with something like:

```
/usr/local/include/boost/asio/detail/impl/io_uring_descriptor_service.ipp:109:3: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
  io_uring_service_.register_io_object(impl.io_object_data_);
/usr/local/include/boost/asio/detail/impl/io_uring_descriptor_service.ipp:109:3: note: Called C++ object pointer is null
  io_uring_service_.register_io_object(impl.io_object_data_);
```

I have looked through the Boost code and cannot figure out any path
where the object really is null and since we use this code everywhere
I highly suspect it is not.  In any case, by using an alternative
constructor we seem to have appeased clang-tidy.  Switch to the
socket constructor which takes an executor instead of a context.

Tested: Ran `ninja clang-tidy` in openbmc/estoraged with this change in
a subproject.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I58295b5515acc46b7879001ce3ae8145f00d9726