commit 1f3813f819f11b27f515891c239113f0b4e60936
author Tom Joseph <tomjoseph@in.ibm.com> Tue Jul 28 08:47:22 2020 +0530
committer Tom Joseph <tomjoseph@in.ibm.com> Fri Jul 31 10:05:22 2020 +0530
tree 7620e5ad68e0ad26c5b653a2d0727f8da9237dd2
parent ba2c083ebaae5a0e9ba87358f67b620e0345f4b9

add_manager adds the ObjectManager interface

add_manager adds the interface org.freedesktop.DBus.ObjectManager
in the object path /xyz/openbmc_project/control/service.

srcCfgMgrIntf had / in the interface name and phosphor-srvcfg-manager
terminates with "Invalid path or interface"

Tested:

1) Verified phosphor-srvcfg-manager is not terminating
2) Verified org.freedesktop.DBus.ObjectManager interface is implemented
   by /xyz/openbmc_project/control/service.

Signed-off-by: Tom Joseph <tomjoseph@in.ibm.com>
Change-Id: I3f0286b4bc36929b15e6e915200d381034bf8663

inc/srvcfg_manager.hpp

diff --git a/inc/srvcfg_manager.hpp b/inc/srvcfg_manager.hpp
index d0a3ae1..bf52ab2 100644
--- a/inc/srvcfg_manager.hpp
+++ b/inc/srvcfg_manager.hpp
@@ -31,8 +31,6 @@
     "xyz.openbmc_project.Control.Service.SocketAttributes";
 static constexpr const char* srcCfgMgrBasePath =
     "/xyz/openbmc_project/control/service";
-static constexpr const char* srcCfgMgrIntf =
-    "/xyz/openbmc_project.Control.Service.Manager";
 static constexpr const char* sockAttrPropPort = "Port";
 static constexpr const char* srvCfgPropMasked = "Masked";
 static constexpr const char* srvCfgPropEnabled = "Enabled";

src/main.cpp

diff --git a/src/main.cpp b/src/main.cpp
index b45cf63..f8d1f22 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -306,9 +306,6 @@
     initTimer = std::make_unique<boost::asio::steady_timer>(io);
     conn->request_name(phosphor::service::serviceConfigSrvName);
     auto server = sdbusplus::asio::object_server(conn, true);
-    auto mgrIntf = server.add_interface(phosphor::service::srcCfgMgrBasePath,
-                                        phosphor::service::srcCfgMgrIntf);
-    mgrIntf->initialize();
     server.add_manager(phosphor::service::srcCfgMgrBasePath);
     // Initialize the objects after systemd indicated startup finished.
     auto userUpdatedSignal = std::make_unique<sdbusplus::bus::match::match>(