ensure persistent settings only used on startup
queryAndUpdateProperties() is called in two code paths
- on startup when it is discovering the state of all the services from
systemd and updating its internal data structures
- when it is issued commands over dbus to change service states
In the first case, the application needs to compare what is reported by
systemd and what it has in its persistent settings and update systemd to
match the persistent settings if there is a mismatch.
In the second case, the application simply needs to ensure the
persistent settings are updated to match what was requested over dbus.
Tested:
- Verified the curl command via Redfish to enable and disable IPMI works
as expected and the persistent settings matched the dbus values
- Verified that if the persistent settings were changed in the
filesystem and the service was restarted that the values in the
persistent settings were used
Change-Id: I0ef7c19c95d32151f8db08a57c9e03f28aa663b1
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
diff --git a/inc/srvcfg_manager.hpp b/inc/srvcfg_manager.hpp
index 4fc9ccd..6920354 100644
--- a/inc/srvcfg_manager.hpp
+++ b/inc/srvcfg_manager.hpp
@@ -111,7 +111,7 @@
bool isMaskedOut();
void registerProperties();
- void queryAndUpdateProperties();
+ void queryAndUpdateProperties(bool isStartup);
void createSocketOverrideConf();
void updateServiceProperties(
const boost::container::flat_map<std::string, VariantType>&