Fix wrong reset pin setting
When power on or power off host, the way to set reset pins based on pin
polarity is not correct. This makes PCIE devices not working properly.
This patch fixed bug introduced by commit:
https://github.com/openbmc/skeleton/commit/3ab5436
and https://github.com/openbmc/skeleton/commit/0475f65
The relationship between expected reset pin state and pgood state looks like:
pgood polarilty reset_pin(expected)
1 0 1
0 0 0
1 1 0
0 1 1
Related with openbmc/openbmc#876
Change-Id: Id0b36c15ed645c29f3ccc2aa507e50b31a718bb9
Signed-off-by: Yi Li <adamliyi@msn.com>
diff --git a/op-pwrctl/power_control_obj.c b/op-pwrctl/power_control_obj.c
index f6cfdbc..9cf8ce4 100644
--- a/op-pwrctl/power_control_obj.c
+++ b/op-pwrctl/power_control_obj.c
@@ -91,9 +91,9 @@
continue;
}
- reset_state = pgood_state ^ !g_power_gpio.reset_pols[i];
- g_print("PowerControl: setting reset %s to %d\n", reset_out->name,
- (int)reset_state);
+ reset_state = pgood_state ^ g_power_gpio.reset_pols[i];
+ g_print("PowerControl: pgood: %d, setting reset %s to %d\n",
+ (int)pgood_state, reset_out->name, (int)reset_state);
gpio_write(reset_out, reset_state);
gpio_close(reset_out);
}
@@ -121,9 +121,9 @@
continue;
}
- reset_state = pgood_state ^ !g_power_gpio.pci_reset_pols[i];
- g_print("PowerControl: setting pci reset %s to %d\n", pci_reset_out->name,
- (int)reset_state);
+ reset_state = pgood_state ^ g_power_gpio.pci_reset_pols[i];
+ g_print("PowerControl: pgood: %d, setting pci reset %s to %d\n",
+ (int)pgood_state, pci_reset_out->name, (int)reset_state);
gpio_write(pci_reset_out, reset_state);
gpio_close(pci_reset_out);
}
@@ -203,9 +203,9 @@
continue;
}
- reset_state = pgood_state ^ !g_power_gpio.pci_reset_pols[i];
- g_print("PowerControl: setting pci reset %s to %d\n", pci_reset_out->name,
- (int)reset_state);
+ reset_state = pgood_state ^ g_power_gpio.pci_reset_pols[i];
+ g_print("PowerControl: pgood: %d, setting pci reset %s to %d\n",
+ (int)pgood_state, pci_reset_out->name, (int)reset_state);
gpio_write(pci_reset_out, reset_state);
gpio_close(pci_reset_out);
g_print("Released pci reset: %s - %s\n", pci_reset_out->name, boot_progress);