commit 036374a29d4192367f1a3fed2f074bde52b82fc6
author George Liu <liuxiwei@inspur.com> Thu Jun 15 08:47:46 2023 +0800
committer George Liu <liuxiwei@inspur.com> Wed Jun 28 11:27:36 2023 +0800
tree 5b869d7fe2478962a22af75bcbe64b451bd85763
parent 132d037edfeedfc74e97d51358dbd41db0f8fdf3

Change the byte of the MemoryAttributes attribute to the size type

We prefer to use size_t type instead of byte type in PDI[1]

[1] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/63799

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I211a7cd553338995170407fa583d8926a6c98f53

include/dimm.hpp

diff --git a/include/dimm.hpp b/include/dimm.hpp
index 1ea406a..72885ff 100644
--- a/include/dimm.hpp
+++ b/include/dimm.hpp
@@ -105,7 +105,7 @@
     std::string serialNumber(std::string value) override;
     std::string partNumber(std::string value) override;
     std::string locationCode(std::string value) override;
-    uint8_t memoryAttributes(uint8_t value) override;
+    size_t memoryAttributes(size_t value) override;
     uint16_t memoryConfiguredSpeedInMhz(uint16_t value) override;
     bool functional(bool value) override;
     EccType ecc(EccType value) override;
@@ -154,7 +154,7 @@
     uint8_t serialNum;
     uint8_t assetTag;
     uint8_t partNum;
-    uint8_t attributes;
+    size_t attributes;
     uint32_t extendedSize;
     uint16_t confClockSpeed;
     uint16_t minimumVoltage;

src/dimm.cpp

diff --git a/src/dimm.cpp b/src/dimm.cpp
index c84bc51..72f5ed3 100644
--- a/src/dimm.cpp
+++ b/src/dimm.cpp
@@ -319,7 +319,7 @@
         LocationCode::locationCode(value);
 }
 
-uint8_t Dimm::memoryAttributes(uint8_t value)
+size_t Dimm::memoryAttributes(size_t value)
 {
     return sdbusplus::server::xyz::openbmc_project::inventory::item::Dimm::
         memoryAttributes(value);

src/mdrv2.cpp

diff --git a/src/mdrv2.cpp b/src/mdrv2.cpp
index 856d817..1bf2e31 100644
--- a/src/mdrv2.cpp
+++ b/src/mdrv2.cpp
@@ -831,7 +831,7 @@
                                                    memoryInfo->length, dataIn);
             record["Part Number"] = positionToString(
                 memoryInfo->partNum, memoryInfo->length, dataIn);
-            record["Attributes"] = memoryInfo->attributes;
+            record["Attributes"] = uint32_t(memoryInfo->attributes);
             record["Extended Size"] = uint32_t(memoryInfo->extendedSize);
             record["Configured Memory Speed"] =
                 uint32_t(memoryInfo->confClockSpeed);