Utilize 'Bank Locator' memory device table field
SMBIOS specification defines the following fields in the
'Memory Device (Type 17)' table:
'''
Device Locator
String number of the string that identifies the physically-labeled
socket or board position where the memory device is located.
EXAMPLE: "DIMM 0"
Bank Locator
String number of the string that identifies the physically labeled
bank where the memory device is located.
EXAMPLE: "Bank 0" or "A"
'''
Currently smbios-mdr uses only 'Device Locator' field for the
'Dimm::MemoryDeviceLocator' value.
Utilize both 'Bank Locator' and 'Device Locator' fields to construct
more complete locator value.
Tested:
Tested on the AMD EthanolX board. Example of the locator fields in
one of the Type 17 tables:
Bank Locator: "P0 CHANNEL A",
Device Locator: "DIMM 0".
Before the patch "MemoryDeviceLocator" property on the
"xyz.openbmc_project.Inventory.Item.Dimm" interface is equal to
the "DIMM 0".
After the patch it is equal to the "P0 CHANNEL A DIMM 0".
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I0e4913b8ac0639a9549c217ca9dfbfe34ea82c68
diff --git a/include/dimm.hpp b/include/dimm.hpp
index 709bfdf..1ce90ab 100644
--- a/include/dimm.hpp
+++ b/include/dimm.hpp
@@ -119,8 +119,9 @@
void dimmSize(const uint16_t size);
void dimmSizeExt(const size_t size);
- void dimmDeviceLocator(const uint8_t positionNum, const uint8_t structLen,
- uint8_t* dataIn);
+ void dimmDeviceLocator(const uint8_t bankLocatorPositionNum,
+ const uint8_t deviceLocatorPositionNum,
+ const uint8_t structLen, uint8_t* dataIn);
void dimmType(const uint8_t type);
void dimmTypeDetail(const uint16_t detail);
void dimmManufacturer(const uint8_t positionNum, const uint8_t structLen,