tree 636c2299fb5da94e4bdc3defc6a9b24b7828748c
parent 9ab8c8d8fb5e7a29869f42be1fef75d8205ea556
author Tim Lee <timlee660101@gmail.com> 1626749758 +0800
committer Tim Lee <timlee660101@gmail.com> 1634106546 +0000

Fix dimm present and functional property to true for robot test

Symptom:
Auto test got failed from ipmi/test_ipmi_sdr.robot
Test DIMM SDR Info At Power Off | FAIL |
Test DIMM SDR Info At Power On  | FAIL |

Root cause:
Read "Present" property from "Verify SDR" keyword and got unexpected result.
Then cause test item "Test DIMM SDR Info At Power On" and
"Test DIMM SDR Info At Power Off" both got failed.

"Present" property ${presence_rest} got false value from
/xyz/openbmc_project/inventory/system/chassis/motherboard/dimmX path
that didn't match expectation of auto test item as below:

If ${presence_ipmi} output is "Presence Detected"
then ${presence_rest} and ${functional_rest} should be true.

However, ${presence_rest} is false and another "Functional" property
didn't be added correctly according current design.
Then cause both DIMM SDR Info test items got failed.

Example of IPMI SDR elist output (ipmitool sdr elist command)
dimm0            | 72h | ok  | 32.25 | Presence Detected
dimm1            | 73h | ok  | 32.26 | Presence Detected
dimm2            | 74h | ok  | 32.27 | Presence Detected
(For example: our host inlcude one DDR4 at dimm0 is DDR4,
 dimm1 and dimm2 are NO DIMM, but output is Presence Detected also)

Solution:
According ipmi sdr elist output "Presence Detected", we need to set
present property to true and add functional property with true by default.

Tested:
Run robot test ipmi/test_ipmi_sdr.robot
Test DIMM SDR Info At Power Off | PASS |
Test DIMM SDR Info At Power On  | PASS |

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: Iaf2e130b682ec47d3b522bc07fa7859aeba559ae