commit f2d8bb48366d812180a8684e3ff58f26425854fa
author Jonathan Doman <jonathan.doman@intel.com> Wed Jul 26 10:13:34 2023 -0700
committer Zhikui Ren <zhikui.ren@intel.com> Sat Aug 05 00:27:59 2023 +0000
tree e39c681398743785dac2ca065922b27d0d1d434a
parent 410bbc271b8e90520905589ae7c505ec78396ccc

Fix compilation warnings

Various small issues:
* Member initialization order
* Comparison of different signedness
* Unused parameters
* Unused variable

Change-Id: Ie59db239b4216ad089f7cf0f289e6ed3d6ac8e18
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

src/smbios-ipmi-blobs/handler.cpp

diff --git a/src/smbios-ipmi-blobs/handler.cpp b/src/smbios-ipmi-blobs/handler.cpp
index 8bd7daf..4b1841f 100644
--- a/src/smbios-ipmi-blobs/handler.cpp
+++ b/src/smbios-ipmi-blobs/handler.cpp
@@ -74,7 +74,7 @@
     return std::vector<std::string>(1, blobId);
 }
 
-bool SmbiosBlobHandler::deleteBlob(const std::string& path)
+bool SmbiosBlobHandler::deleteBlob(const std::string& /* path */)
 {
     return false;
 }
@@ -111,8 +111,9 @@
     return true;
 }
 
-std::vector<uint8_t> SmbiosBlobHandler::read(uint16_t session, uint32_t offset,
-                                             uint32_t requestedSize)
+std::vector<uint8_t> SmbiosBlobHandler::read(uint16_t /* session */,
+                                             uint32_t /* offset */,
+                                             uint32_t /* requestedSize */)
 {
     /* SMBIOS blob handler does not support read. */
     return std::vector<uint8_t>();
@@ -157,8 +158,8 @@
     return true;
 }
 
-bool SmbiosBlobHandler::writeMeta(uint16_t session, uint32_t offset,
-                                  const std::vector<uint8_t>& data)
+bool SmbiosBlobHandler::writeMeta(uint16_t /* session */, uint32_t /* offset */,
+                                  const std::vector<uint8_t>& /* data */)
 {
     return false;
 }