commit f2d8bb48366d812180a8684e3ff58f26425854fa
author Jonathan Doman <jonathan.doman@intel.com> Wed Jul 26 10:13:34 2023 -0700
committer Zhikui Ren <zhikui.ren@intel.com> Sat Aug 05 00:27:59 2023 +0000
tree e39c681398743785dac2ca065922b27d0d1d434a
parent 410bbc271b8e90520905589ae7c505ec78396ccc

Fix compilation warnings

Various small issues:
* Member initialization order
* Comparison of different signedness
* Unused parameters
* Unused variable

Change-Id: Ie59db239b4216ad089f7cf0f289e6ed3d6ac8e18
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

src/system.cpp

diff --git a/src/system.cpp b/src/system.cpp
index 3e4b69c..c0713a6 100644
--- a/src/system.cpp
+++ b/src/system.cpp
@@ -34,7 +34,7 @@
 namespace smbios
 {
 
-std::string System::uuid(std::string value)
+std::string System::uuid(std::string /* value */)
 {
     uint8_t* dataIn = storage;
     dataIn = getSMBIOSTypePtr(dataIn, systemType);
@@ -120,7 +120,7 @@
     bus.call_noreply(method);
 }
 
-std::string System::version(std::string value)
+std::string System::version(std::string /* value */)
 {
     std::string result = "No BIOS Version";
     uint8_t* dataIn = storage;
@@ -128,7 +128,6 @@
     if (dataIn != nullptr)
     {
         auto biosInfo = reinterpret_cast<struct BIOSInfo*>(dataIn);
-        uint8_t biosVerByte = biosInfo->biosVersion;
         std::string tempS = positionToString(biosInfo->biosVersion,
                                              biosInfo->length, dataIn);
         if (std::find_if(tempS.begin(), tempS.end(),