commit 73a2ce323d9e58eb12c75ddf640a3dc23bac42d9
author William A. Kennington III <wak@google.com> Mon Jun 26 16:46:55 2023 -0700
committer William A. Kennington III <wak@google.com> Tue Jun 27 00:09:18 2023 -0700
tree 29d33d3d4041ea1a8d53b0daea7a7bc7898d41eb
parent 69a00d76b8c5ce5571cde254c1d5396705b83f19

net/addr/ether: Remove isEmpty

Users want to be clear about the address the are comparing and this
doesn't add value over a direct comparison to EtherAddr{}.

Change-Id: Ida7f07d6c95d875d92e60791958fcc88911c3649
Signed-off-by: William A. Kennington III <wak@google.com>

include/stdplus/net/addr/ether.hpp

diff --git a/include/stdplus/net/addr/ether.hpp b/include/stdplus/net/addr/ether.hpp
index 1fc3638..e0ff329 100644
--- a/include/stdplus/net/addr/ether.hpp
+++ b/include/stdplus/net/addr/ether.hpp
@@ -33,11 +33,6 @@
         return *this == static_cast<ether_addr&>(rhs);
     }
 
-    constexpr bool isEmpty() const noexcept
-    {
-        return *this == EtherAddr{};
-    }
-
     constexpr bool isMulticast() const noexcept
     {
         return ether_addr_octet[0] & 1;
@@ -45,7 +40,7 @@
 
     constexpr bool isUnicast() const noexcept
     {
-        return !(isEmpty() || isMulticast());
+        return !(*this == EtherAddr{} || isMulticast());
     }
 };
 

test/net/addr/ether.cpp

diff --git a/test/net/addr/ether.cpp b/test/net/addr/ether.cpp
index bf5ec2b..bff7248 100644
--- a/test/net/addr/ether.cpp
+++ b/test/net/addr/ether.cpp
@@ -15,13 +15,6 @@
     std::hash<EtherAddr>{}(EtherAddr{});
 }
 
-TEST(Query, IsEmpty)
-{
-    EXPECT_TRUE((EtherAddr{}.isEmpty()));
-    EXPECT_FALSE((EtherAddr{1}.isEmpty()));
-    EXPECT_FALSE((EtherAddr{0, 0, 0, 1}.isEmpty()));
-}
-
 TEST(Query, IsMulticast)
 {
     EXPECT_TRUE((EtherAddr{255, 255, 255, 255, 255, 255}.isMulticast()));