Remove retry "GetProperty" on fail
Removed retry "GetProperty" on fail when sensor is not present.
Monitoring PropertiesChanged signal is enough to get the latest
value from sensor when it is added to dbus environment. Added
test that check if newly added properties to dbus environment
send PropertiesChanged signal.
Tested: - All unit tests passed
Change-Id: Ibe92b23dd062a6d48b0b6d5bc0dc2198bcfa7a5e
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
diff --git a/src/sensor.cpp b/src/sensor.cpp
index d38fbd9..c4973cd 100644
--- a/src/sensor.cpp
+++ b/src/sensor.cpp
@@ -1,14 +1,11 @@
#include "sensor.hpp"
-#include "utils/detached_timer.hpp"
-
#include <boost/container/flat_map.hpp>
#include <phosphor-logging/log.hpp>
#include <sdbusplus/asio/property.hpp>
#include <sdbusplus/bus/match.hpp>
#include <functional>
-#include <iostream>
Sensor::Sensor(interfaces::Sensor::Id sensorId, boost::asio::io_context& ioc,
const std::shared_ptr<sdbusplus::asio::connection>& bus) :
@@ -40,24 +37,10 @@
"xyz.openbmc_project.Sensor.Value", "Value",
[lock, id = sensorId,
weakSelf = weak_from_this()](boost::system::error_code ec) {
- phosphor::logging::log<phosphor::logging::level::ERR>(
+ phosphor::logging::log<phosphor::logging::level::WARNING>(
"DBus 'GetProperty' call failed on Sensor Value",
phosphor::logging::entry("sensor=%s, ec=%lu", id.str().c_str(),
ec.value()));
-
- if (auto self = weakSelf.lock())
- {
-
- constexpr auto retryIntervalAfterFailedRead =
- std::chrono::seconds(30);
- utils::makeDetachedTimer(
- self->ioc, retryIntervalAfterFailedRead, [weakSelf] {
- if (auto self = weakSelf.lock())
- {
- self->async_read();
- }
- });
- }
},
[lock, weakSelf = weak_from_this()](double newValue) {
if (auto self = weakSelf.lock())