Add TriggerManager and Trigger objects
Implemented initial version of Trigger and TriggerManager DBus
interfaces. Now DBus user is able to add new Trigger and delete it.
There is no support for other functionality added.
Tested:
- Built using yocto dependencies with success
- Unit tests passed
- Verified manually if Trigger and TriggerManager works as
expected
Change-Id: Ie68463526ecccc3be67cc7bfaaf9a9aa7326dee6
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
diff --git a/tests/src/test_trigger.cpp b/tests/src/test_trigger.cpp
new file mode 100644
index 0000000..0f2d752
--- /dev/null
+++ b/tests/src/test_trigger.cpp
@@ -0,0 +1,91 @@
+#include "dbus_environment.hpp"
+#include "helpers.hpp"
+#include "mocks/trigger_manager_mock.hpp"
+#include "params/trigger_params.hpp"
+#include "trigger.hpp"
+#include "utils/set_exception.hpp"
+
+using namespace testing;
+using namespace std::literals::string_literals;
+
+class TestTrigger : public Test
+{
+ public:
+ TriggerParams triggerParams;
+
+ std::unique_ptr<TriggerManagerMock> triggerManagerMockPtr =
+ std::make_unique<NiceMock<TriggerManagerMock>>();
+ std::unique_ptr<Trigger> sut;
+
+ void SetUp() override
+ {
+ sut = std::make_unique<Trigger>(
+ DbusEnvironment::getIoc(), DbusEnvironment::getObjServer(),
+ triggerParams.name(), triggerParams.isDiscrete(),
+ triggerParams.logToJournal(), triggerParams.logToRedfish(),
+ triggerParams.updateReport(), triggerParams.sensors(),
+ triggerParams.reportNames(), triggerParams.thresholds(),
+ *triggerManagerMockPtr);
+ }
+
+ template <class T>
+ static T getProperty(const std::string& path, const std::string& property)
+ {
+ std::promise<T> propertyPromise;
+ sdbusplus::asio::getProperty<T>(
+ *DbusEnvironment::getBus(), DbusEnvironment::serviceName(), path,
+ Trigger::triggerIfaceName, property,
+ [&propertyPromise](boost::system::error_code) {
+ utils::setException(propertyPromise, "GetProperty failed");
+ },
+ [&propertyPromise](T t) { propertyPromise.set_value(t); });
+ return DbusEnvironment::waitForFuture(propertyPromise.get_future());
+ }
+
+ boost::system::error_code deleteTrigger(const std::string& path)
+ {
+ std::promise<boost::system::error_code> methodPromise;
+ DbusEnvironment::getBus()->async_method_call(
+ [&methodPromise](boost::system::error_code ec) {
+ methodPromise.set_value(ec);
+ },
+ DbusEnvironment::serviceName(), path, Trigger::deleteIfaceName,
+ "Delete");
+ return DbusEnvironment::waitForFuture(methodPromise.get_future());
+ }
+};
+
+TEST_F(TestTrigger, checkIfPropertiesAreSet)
+{
+ EXPECT_THAT(getProperty<bool>(sut->getPath(), "Discrete"),
+ Eq(triggerParams.isDiscrete()));
+ EXPECT_THAT(getProperty<bool>(sut->getPath(), "LogToJournal"),
+ Eq(triggerParams.logToJournal()));
+ EXPECT_THAT(getProperty<bool>(sut->getPath(), "LogToRedfish"),
+ Eq(triggerParams.logToRedfish()));
+ EXPECT_THAT(getProperty<bool>(sut->getPath(), "UpdateReport"),
+ Eq(triggerParams.updateReport()));
+ EXPECT_THAT((getProperty<std::vector<
+ std::pair<sdbusplus::message::object_path, std::string>>>(
+ sut->getPath(), "Sensors")),
+ Eq(triggerParams.sensors()));
+ EXPECT_THAT(
+ getProperty<std::vector<std::string>>(sut->getPath(), "ReportNames"),
+ Eq(triggerParams.reportNames()));
+ EXPECT_THAT(
+ getProperty<TriggerThresholdParams>(sut->getPath(), "Thresholds"),
+ Eq(triggerParams.thresholds()));
+}
+
+TEST_F(TestTrigger, deleteTrigger)
+{
+ EXPECT_CALL(*triggerManagerMockPtr, removeTrigger(sut.get()));
+ auto ec = deleteTrigger(sut->getPath());
+ EXPECT_THAT(ec, Eq(boost::system::errc::success));
+}
+
+TEST_F(TestTrigger, deletingNonExistingTriggerReturnInvalidRequestDescriptor)
+{
+ auto ec = deleteTrigger(Trigger::triggerDir + "NonExisting"s);
+ EXPECT_THAT(ec.value(), Eq(EBADR));
+}