commit b47b7db48c4f883eb191077848d55d96bd884607
author Michal Orzel <michalx.orzel@intel.com> Mon Sep 16 10:02:29 2024 +0200
committer Michal Orzel <michalx.orzel@intel.com> Mon Sep 16 11:55:33 2024 +0200
tree e00b8eda41e90dc7bdb53e4bfc9b70602ec65ccf
parent 95f77e623c1b84663fe62e4506d2291b6919a13d

Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_manager.cpp: 94.2% -> 97.5%
- src/trigger_manager.cpp: 94.9% -> 99.0%
- src/utils/dbus_path_utils.cpp: 94.6% -> 100.0%

Change-Id: Id729c7f2e7e188d878b7348c710a09a4ceb40fd4
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

tests/src/test_trigger.cpp

diff --git a/tests/src/test_trigger.cpp b/tests/src/test_trigger.cpp
index cfe0e15..9c68d94 100644
--- a/tests/src/test_trigger.cpp
+++ b/tests/src/test_trigger.cpp
@@ -228,7 +228,7 @@
 }
 
 TEST_F(TestTrigger,
-       DISABLED_settingPropertyReportNamesThrowsExceptionWhenDuplicateReportIds)
+       settingPropertyReportNamesThrowsExceptionWhenDuplicateReportIds)
 {
     std::vector<object_path> newPropertyVal{
         utils::constants::reportDirPath / "report1",
@@ -241,9 +241,8 @@
                 Eq(boost::system::errc::invalid_argument));
 }
 
-TEST_F(
-    TestTrigger,
-    DISABLED_settingPropertyReportNamesThrowsExceptionWhenReportWithTooManyPrefixes)
+TEST_F(TestTrigger,
+       settingPropertyReportNamesThrowsExceptionWhenReportWithTooManyPrefixes)
 {
     std::vector<object_path> newPropertyVal{
         object_path("/xyz/openbmc_project/Telemetry/Reports/P1/P2/MyReport")};
@@ -254,9 +253,8 @@
                 Eq(boost::system::errc::invalid_argument));
 }
 
-TEST_F(
-    TestTrigger,
-    DISABLED_settingPropertyReportNamesThrowsExceptionWhenReportWithTooLongPrefix)
+TEST_F(TestTrigger,
+       settingPropertyReportNamesThrowsExceptionWhenReportWithTooLongPrefix)
 {
     std::vector<object_path> newPropertyVal{
         object_path("/xyz/openbmc_project/Telemetry/Reports/" +
@@ -268,9 +266,8 @@
                 Eq(boost::system::errc::invalid_argument));
 }
 
-TEST_F(
-    TestTrigger,
-    DISABLED_settingPropertyReportNamesThrowsExceptionWhenReportWithTooLongId)
+TEST_F(TestTrigger,
+       settingPropertyReportNamesThrowsExceptionWhenReportWithTooLongId)
 {
     std::vector<object_path> newPropertyVal{
         object_path("/xyz/openbmc_project/Telemetry/Reports/Prefix/" +
@@ -283,7 +280,7 @@
 }
 
 TEST_F(TestTrigger,
-       DISABLED_settingPropertyReportNamesThrowsExceptionWhenReportWithBadPath)
+       settingPropertyReportNamesThrowsExceptionWhenReportWithBadPath)
 {
     std::vector<object_path> newPropertyVal{
         object_path("/xyz/openbmc_project/Telemetry/NotReports/MyReport")};