commit b47b7db48c4f883eb191077848d55d96bd884607
author Michal Orzel <michalx.orzel@intel.com> Mon Sep 16 10:02:29 2024 +0200
committer Michal Orzel <michalx.orzel@intel.com> Mon Sep 16 11:55:33 2024 +0200
tree e00b8eda41e90dc7bdb53e4bfc9b70602ec65ccf
parent 95f77e623c1b84663fe62e4506d2291b6919a13d

Enable disabled unit tests

Enabling tests that were initially disabled, most probably because
corresponding features had yet been in development.

Tested:
Lines coverage increased:
- src/report_manager.cpp: 94.2% -> 97.5%
- src/trigger_manager.cpp: 94.9% -> 99.0%
- src/utils/dbus_path_utils.cpp: 94.6% -> 100.0%

Change-Id: Id729c7f2e7e188d878b7348c710a09a4ceb40fd4
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

tests/src/test_trigger_manager.cpp

diff --git a/tests/src/test_trigger_manager.cpp b/tests/src/test_trigger_manager.cpp
index 945c411..a7651ef 100644
--- a/tests/src/test_trigger_manager.cpp
+++ b/tests/src/test_trigger_manager.cpp
@@ -106,7 +106,7 @@
     EXPECT_THAT(path, Eq(triggerMock.getPath()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerTwice)
+TEST_F(TestTriggerManager, failToAddTriggerTwice)
 {
     triggerFactoryMock.expectMake(TriggerParams(), Ref(*sut), Ref(storageMock))
         .WillOnce(Return(ByMove(std::move(triggerMockPtr))));
@@ -118,7 +118,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithInvalidId)
+TEST_F(TestTriggerManager, failToAddTriggerWithInvalidId)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -128,7 +128,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithDuplicatesInReportsIds)
+TEST_F(TestTriggerManager, failToAddTriggerWithDuplicatesInReportsIds)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -149,7 +149,7 @@
     EXPECT_THAT(path, Eq(triggerMock.getPath()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithBadReportsPath)
+TEST_F(TestTriggerManager, failToAddTriggerWithBadReportsPath)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -160,7 +160,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooManyReportPrefixes)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooManyReportPrefixes)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -276,7 +276,7 @@
     EXPECT_THAT(path, Eq("/"s + triggerParams.id()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooLongFullId)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooLongFullId)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -290,7 +290,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooLongId)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooLongId)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -303,7 +303,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooLongPrefix)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooLongPrefix)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -316,7 +316,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooManyPrefixes)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooManyPrefixes)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -336,7 +336,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooLongName)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooLongName)
 {
     triggerFactoryMock.expectMake(std::nullopt, Ref(*sut), Ref(storageMock))
         .Times(0);
@@ -349,7 +349,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWithTooLongMetricId)
+TEST_F(TestTriggerManager, failToAddTriggerWithTooLongMetricId)
 {
     namespace ts = utils::tstring;
 
@@ -372,7 +372,7 @@
     EXPECT_THAT(path, Eq(std::string()));
 }
 
-TEST_F(TestTriggerManager, DISABLED_failToAddTriggerWhenMaxTriggerIsReached)
+TEST_F(TestTriggerManager, failToAddTriggerWhenMaxTriggerIsReached)
 {
     auto triggerParams = TriggerParams();