Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 1 | #include "dbus_environment.hpp" |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 2 | #include "fakes/clock_fake.hpp" |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 3 | #include "helpers.hpp" |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 4 | #include "messages/collect_trigger_id.hpp" |
| 5 | #include "messages/trigger_presence_changed_ind.hpp" |
| 6 | #include "messages/update_report_ind.hpp" |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 7 | #include "mocks/json_storage_mock.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 8 | #include "mocks/metric_mock.hpp" |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 9 | #include "mocks/report_factory_mock.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 10 | #include "mocks/report_manager_mock.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 11 | #include "params/report_params.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 12 | #include "report.hpp" |
| 13 | #include "report_manager.hpp" |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 14 | #include "utils/clock.hpp" |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 15 | #include "utils/contains.hpp" |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 16 | #include "utils/conv_container.hpp" |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 17 | #include "utils/dbus_path_utils.hpp" |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 18 | #include "utils/messanger.hpp" |
Szymon Dompke | 32305f1 | 2022-07-05 15:37:21 +0200 | [diff] [blame] | 19 | #include "utils/string_utils.hpp" |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 20 | #include "utils/transform.hpp" |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 21 | #include "utils/tstring.hpp" |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 22 | |
| 23 | #include <sdbusplus/exception.hpp> |
| 24 | |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 25 | #include <ranges> |
| 26 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 27 | using namespace testing; |
| 28 | using namespace std::literals::string_literals; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 29 | using namespace std::chrono_literals; |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 30 | using sdbusplus::message::object_path; |
Krzysztof Grobelny | e8fc575 | 2021-02-05 14:30:45 +0000 | [diff] [blame] | 31 | namespace tstring = utils::tstring; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 32 | |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 33 | using ErrorMessageDbusType = std::tuple<std::string, std::string>; |
| 34 | using ErrorMessagesDbusType = std::vector<ErrorMessageDbusType>; |
| 35 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 36 | constexpr Milliseconds systemTimestamp = 55ms; |
| 37 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 38 | namespace |
| 39 | { |
| 40 | |
| 41 | ReportParams defaultParams() |
| 42 | { |
| 43 | return ReportParams(); |
| 44 | } |
| 45 | |
| 46 | ReportParams defaultOnChangeParams() |
| 47 | { |
| 48 | return defaultParams().reportingType(ReportingType::onChange); |
| 49 | } |
| 50 | |
| 51 | } // namespace |
| 52 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 53 | class TestReport : public Test |
| 54 | { |
| 55 | public: |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 56 | std::unique_ptr<ReportManagerMock> reportManagerMock = |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 57 | std::make_unique<NiceMock<ReportManagerMock>>(); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 58 | std::unique_ptr<ReportFactoryMock> reportFactoryMock = |
| 59 | std::make_unique<NiceMock<ReportFactoryMock>>(); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 60 | nlohmann::json storedConfiguration; |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 61 | NiceMock<StorageMock> storageMock; |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 62 | std::vector<std::shared_ptr<MetricMock>> metricMocks; |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 63 | std::unique_ptr<ClockFake> clockFakePtr = std::make_unique<ClockFake>(); |
| 64 | ClockFake& clockFake = *clockFakePtr; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 65 | std::unique_ptr<Report> sut; |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 66 | utils::Messanger messanger; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 67 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 68 | MockFunction<void()> checkPoint; |
| 69 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 70 | TestReport() : messanger(DbusEnvironment::getIoc()) |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 71 | { |
| 72 | clockFake.system.set(systemTimestamp); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 73 | ON_CALL(storageMock, store(to_file_path(ReportParams().reportId()), _)) |
| 74 | .WillByDefault(SaveArg<1>(&storedConfiguration)); |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 75 | } |
| 76 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 77 | void initMetricMocks( |
| 78 | const std::vector<LabeledMetricParameters>& metricParameters) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 79 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 80 | for (auto i = metricMocks.size(); i < metricParameters.size(); ++i) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 81 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 82 | metricMocks.emplace_back(std::make_shared<NiceMock<MetricMock>>()); |
| 83 | } |
| 84 | metricMocks.resize(metricParameters.size()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 85 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 86 | std::vector<MetricValue> readings{{MetricValue{"a", "b", 17.1, 114}, |
| 87 | MetricValue{"aa", "bb", 42.0, 74}}}; |
| 88 | readings.resize(metricParameters.size()); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 89 | |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 90 | for (size_t i = 0; i < metricParameters.size(); ++i) |
| 91 | { |
Krzysztof Grobelny | 9e8da54 | 2022-02-17 10:40:16 +0100 | [diff] [blame] | 92 | ON_CALL(*metricMocks[i], getUpdatedReadings()) |
| 93 | .WillByDefault(ReturnRefOfCopy(std::vector({readings[i]}))); |
Krzysztof Grobelny | d223819 | 2020-12-02 09:27:28 +0000 | [diff] [blame] | 94 | ON_CALL(*metricMocks[i], dumpConfiguration()) |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 95 | .WillByDefault(Return(metricParameters[i])); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 96 | } |
| 97 | } |
| 98 | |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 99 | std::vector<std::shared_ptr<interfaces::Metric>> |
| 100 | getMetricsFromReadingParams(const ReadingParameters& params) |
| 101 | { |
| 102 | const auto metricParameters = |
| 103 | reportFactoryMock->convertMetricParams(params); |
| 104 | std::vector<std::shared_ptr<MetricMock>> metricMocks; |
| 105 | |
| 106 | for (size_t i = 0; i < metricParameters.size(); ++i) |
| 107 | { |
| 108 | metricMocks.emplace_back(std::make_shared<NiceMock<MetricMock>>()); |
| 109 | ON_CALL(*metricMocks[i], dumpConfiguration()) |
| 110 | .WillByDefault(Return(metricParameters[i])); |
| 111 | } |
| 112 | |
| 113 | return utils::convContainer<std::shared_ptr<interfaces::Metric>>( |
| 114 | metricMocks); |
| 115 | } |
| 116 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 117 | void SetUp() override |
| 118 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 119 | sut = makeReport(defaultParams()); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 120 | } |
| 121 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 122 | static interfaces::JsonStorage::FilePath to_file_path(std::string id) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 123 | { |
| 124 | return interfaces::JsonStorage::FilePath( |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 125 | std::to_string(std::hash<std::string>{}(id))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 126 | } |
| 127 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 128 | std::unique_ptr<Report> makeReport(const ReportParams& params) |
| 129 | { |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 130 | initMetricMocks(params.metricParameters()); |
| 131 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 132 | return std::make_unique<Report>( |
| 133 | DbusEnvironment::getIoc(), DbusEnvironment::getObjServer(), |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 134 | params.reportId(), params.reportName(), params.reportingType(), |
| 135 | params.reportActions(), params.interval(), params.appendLimit(), |
| 136 | params.reportUpdates(), *reportManagerMock, storageMock, |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 137 | utils::convContainer<std::shared_ptr<interfaces::Metric>>( |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 138 | metricMocks), |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 139 | *reportFactoryMock, params.enabled(), std::move(clockFakePtr), |
| 140 | params.readings()); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 141 | } |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 142 | |
| 143 | template <class T> |
| 144 | static T getProperty(const std::string& path, const std::string& property) |
| 145 | { |
Szymon Dompke | e28aa53 | 2021-10-27 12:33:12 +0200 | [diff] [blame] | 146 | return DbusEnvironment::getProperty<T>(path, Report::reportIfaceName, |
| 147 | property); |
| 148 | } |
| 149 | |
| 150 | template <class T> |
| 151 | static boost::system::error_code setProperty(const std::string& path, |
| 152 | const std::string& property, |
| 153 | const T& newValue) |
| 154 | { |
| 155 | return DbusEnvironment::setProperty<T>(path, Report::reportIfaceName, |
| 156 | property, newValue); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 157 | } |
| 158 | |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 159 | template <class T> |
| 160 | struct ChangePropertyParams |
| 161 | { |
| 162 | Matcher<T> valueBefore = _; |
| 163 | T newValue; |
| 164 | Matcher<boost::system::error_code> ec = |
| 165 | Eq(boost::system::errc::success); |
| 166 | Matcher<T> valueAfter = Eq(newValue); |
| 167 | }; |
| 168 | |
| 169 | template <class T> |
| 170 | static void changeProperty(const std::string& path, |
| 171 | const std::string& property, |
| 172 | ChangePropertyParams<T> p) |
| 173 | { |
| 174 | ASSERT_THAT(getProperty<T>(path, property), p.valueBefore); |
| 175 | ASSERT_THAT(setProperty<T>(path, property, p.newValue), p.ec); |
| 176 | EXPECT_THAT(getProperty<T>(path, property), p.valueAfter); |
| 177 | } |
| 178 | |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 179 | boost::system::error_code call(const std::string& path, |
| 180 | const std::string& interface, |
| 181 | const std::string& method) |
| 182 | { |
| 183 | std::promise<boost::system::error_code> methodPromise; |
| 184 | DbusEnvironment::getBus()->async_method_call( |
| 185 | [&methodPromise](boost::system::error_code ec) { |
| 186 | methodPromise.set_value(ec); |
| 187 | }, |
| 188 | DbusEnvironment::serviceName(), path, interface, method); |
| 189 | return DbusEnvironment::waitForFuture(methodPromise.get_future()); |
| 190 | } |
| 191 | |
| 192 | boost::system::error_code update(const std::string& path) |
| 193 | { |
| 194 | return call(path, Report::reportIfaceName, "Update"); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 195 | } |
| 196 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 197 | boost::system::error_code deleteReport(const std::string& path) |
| 198 | { |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 199 | return call(path, Report::deleteIfaceName, "Delete"); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 200 | } |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 201 | |
| 202 | static std::pair<std::string, std::vector<std::string>> |
| 203 | makeStateDetail(const std::string& detailType, |
| 204 | std::vector<std::string> detailArgs) |
| 205 | { |
| 206 | return make_pair(detailType, detailArgs); |
| 207 | } |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 208 | }; |
| 209 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 210 | TEST_F(TestReport, returnsId) |
| 211 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 212 | EXPECT_THAT(sut->getId(), Eq(defaultParams().reportId())); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 213 | } |
| 214 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 215 | TEST_F(TestReport, verifyIfPropertiesHaveValidValue) |
| 216 | { |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 217 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 218 | Eq(defaultParams().enabled())); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 219 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 220 | Eq(defaultParams().interval().count())); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 221 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Persistency"), Eq(true)); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 222 | EXPECT_THAT( |
| 223 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 224 | Eq(utils::transform(defaultParams().reportActions(), [](const auto v) { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 225 | return utils::enumToString(v); |
| 226 | }))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 227 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "EmitsReadingsUpdate"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 228 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 229 | ReportAction::emitsReadingsUpdate))); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 230 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "AppendLimit"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 231 | Eq(defaultParams().appendLimit())); |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 232 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportingType"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 233 | Eq(utils::enumToString(defaultParams().reportingType()))); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 234 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "ReportUpdates"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 235 | Eq(utils::enumToString(defaultParams().reportUpdates()))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 236 | EXPECT_THAT( |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 237 | getProperty<bool>(sut->getPath(), "LogToMetricReportsCollection"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 238 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 239 | ReportAction::logToMetricReportsCollection))); |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 240 | EXPECT_THAT(getProperty<ReadingParameters>( |
| 241 | sut->getPath(), "ReadingParametersFutureVersion"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 242 | Eq(toReadingParameters(defaultParams().metricParameters()))); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 243 | EXPECT_THAT(getProperty<std::string>(sut->getPath(), "Name"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 244 | Eq(defaultParams().reportName())); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 245 | EXPECT_THAT( |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 246 | getProperty<std::vector<object_path>>(sut->getPath(), "Triggers"), |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 247 | IsEmpty()); |
| 248 | EXPECT_THAT( |
| 249 | getProperty<ErrorMessagesDbusType>(sut->getPath(), "ErrorMessages"), |
| 250 | IsEmpty()); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 251 | } |
| 252 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 253 | TEST_F(TestReport, readingsAreInitialyEmpty) |
| 254 | { |
| 255 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 256 | Eq(Readings{})); |
| 257 | } |
| 258 | |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 259 | TEST_F(TestReport, setReadingParametersWithNewParams) |
| 260 | { |
| 261 | ReadingParameters newParams = toReadingParameters( |
| 262 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
| 263 | {LabeledSensorInfo{"Service", |
| 264 | "/xyz/openbmc_project/sensors/power/psu", |
| 265 | "NewMetadata123"}}, |
| 266 | OperationType::avg, |
| 267 | "NewMetricId123", |
| 268 | CollectionTimeScope::startup, |
| 269 | CollectionDuration(250ms)}}}); |
| 270 | auto metrics = getMetricsFromReadingParams(newParams); |
| 271 | |
| 272 | EXPECT_CALL(*reportFactoryMock, updateMetrics(_, _, _)) |
| 273 | .WillOnce(SetArgReferee<0>(metrics)); |
| 274 | EXPECT_THAT( |
| 275 | setProperty(sut->getPath(), "ReadingParametersFutureVersion", newParams) |
| 276 | .value(), |
| 277 | Eq(boost::system::errc::success)); |
| 278 | EXPECT_THAT(getProperty<ReadingParameters>( |
| 279 | sut->getPath(), "ReadingParametersFutureVersion"), |
| 280 | Eq(newParams)); |
| 281 | } |
| 282 | |
Szymon Dompke | 32305f1 | 2022-07-05 15:37:21 +0200 | [diff] [blame] | 283 | TEST_F(TestReport, setReadingParametersWithTooLongMetricId) |
| 284 | { |
| 285 | const ReadingParameters currentValue = |
| 286 | toReadingParameters(defaultParams().metricParameters()); |
| 287 | |
| 288 | ReadingParameters newParams = toReadingParameters( |
| 289 | std::vector<LabeledMetricParameters>{{LabeledMetricParameters{ |
| 290 | {LabeledSensorInfo{"Service", |
| 291 | "/xyz/openbmc_project/sensors/power/psu", |
| 292 | "NewMetadata123"}}, |
| 293 | OperationType::avg, |
| 294 | utils::string_utils::getTooLongId(), |
| 295 | CollectionTimeScope::startup, |
| 296 | CollectionDuration(250ms)}}}); |
| 297 | |
| 298 | changeProperty<ReadingParameters>( |
| 299 | sut->getPath(), "ReadingParametersFutureVersion", |
| 300 | {.valueBefore = Eq(currentValue), |
| 301 | .newValue = newParams, |
| 302 | .ec = Eq(boost::system::errc::invalid_argument), |
| 303 | .valueAfter = Eq(currentValue)}); |
| 304 | } |
| 305 | |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 306 | TEST_F(TestReport, setReportingTypeWithValidNewType) |
| 307 | { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 308 | changeProperty<std::string>( |
| 309 | sut->getPath(), "ReportingType", |
| 310 | {.valueBefore = Not(Eq(utils::enumToString(ReportingType::onRequest))), |
| 311 | .newValue = utils::enumToString(ReportingType::onRequest)}); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 312 | } |
| 313 | |
| 314 | TEST_F(TestReport, setReportingTypeWithInvalidType) |
| 315 | { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 316 | const std::string currentValue = |
| 317 | utils::enumToString(defaultParams().reportingType()); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 318 | |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 319 | changeProperty<std::string>( |
| 320 | sut->getPath(), "ReportingType", |
| 321 | {.valueBefore = Eq(currentValue), |
| 322 | .newValue = "Periodic_ABC", |
| 323 | .ec = Eq(boost::system::errc::invalid_argument), |
| 324 | .valueAfter = Eq(currentValue)}); |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 325 | } |
| 326 | |
| 327 | TEST_F(TestReport, setReportActionsWithValidNewActions) |
| 328 | { |
| 329 | std::vector<std::string> newActions = {"EmitsReadingsUpdate"}; |
| 330 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 331 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 332 | [](const auto v) { return utils::enumToString(v); }); |
| 333 | |
| 334 | EXPECT_THAT(newActions, Ne(currActions)); |
| 335 | EXPECT_THAT( |
| 336 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 337 | Eq(boost::system::errc::success)); |
| 338 | EXPECT_THAT( |
| 339 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 340 | UnorderedElementsAre("EmitsReadingsUpdate", |
| 341 | "LogToMetricReportsCollection")); |
| 342 | } |
| 343 | |
| 344 | TEST_F(TestReport, setReportActionsWithValidUnsortedActions) |
| 345 | { |
| 346 | std::vector<std::string> newActions = {"LogToMetricReportsCollection", |
| 347 | "EmitsReadingsUpdate"}; |
| 348 | std::vector<std::string> expectedActions = {"EmitsReadingsUpdate", |
| 349 | "LogToMetricReportsCollection"}; |
| 350 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 351 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 352 | [](const auto v) { return utils::enumToString(v); }); |
| 353 | |
| 354 | EXPECT_THAT(newActions, Ne(currActions)); |
| 355 | EXPECT_THAT( |
| 356 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 357 | Eq(boost::system::errc::success)); |
| 358 | EXPECT_THAT( |
| 359 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 360 | Eq(expectedActions)); |
| 361 | } |
| 362 | |
| 363 | TEST_F(TestReport, setReportActionsWithEmptyActions) |
| 364 | { |
| 365 | std::vector<std::string> newActions = {}; |
| 366 | std::vector<std::string> expectedActions = {"LogToMetricReportsCollection"}; |
| 367 | std::vector<std::string> currActions = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 368 | utils::transform(defaultParams().reportActions(), |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 369 | [](const auto v) { return utils::enumToString(v); }); |
| 370 | |
| 371 | EXPECT_THAT(newActions, Ne(currActions)); |
| 372 | EXPECT_THAT( |
| 373 | setProperty(sut->getPath(), "ReportActions", newActions).value(), |
| 374 | Eq(boost::system::errc::success)); |
| 375 | EXPECT_THAT( |
| 376 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 377 | Eq(expectedActions)); |
| 378 | } |
| 379 | |
| 380 | TEST_F(TestReport, setReportActionsWithInvalidActions) |
| 381 | { |
| 382 | std::vector<std::string> invalidActions = {"EmitsReadingsUpdate_1"}; |
| 383 | EXPECT_THAT( |
| 384 | setProperty(sut->getPath(), "ReportActions", invalidActions).value(), |
| 385 | Eq(boost::system::errc::invalid_argument)); |
| 386 | EXPECT_THAT( |
| 387 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 388 | Eq(utils::transform(defaultParams().reportActions(), [](const auto v) { |
Szymon Dompke | fdb06a1 | 2022-02-11 11:04:44 +0100 | [diff] [blame] | 389 | return utils::enumToString(v); |
| 390 | }))); |
| 391 | } |
| 392 | |
| 393 | TEST_F(TestReport, createReportWithEmptyActions) |
| 394 | { |
| 395 | std::vector<std::string> expectedActions = {"LogToMetricReportsCollection"}; |
| 396 | |
| 397 | sut = makeReport(ReportParams().reportId("TestId_1").reportActions({})); |
| 398 | EXPECT_THAT( |
| 399 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 400 | Eq(expectedActions)); |
| 401 | } |
| 402 | |
| 403 | TEST_F(TestReport, createReportWithValidUnsortedActions) |
| 404 | { |
| 405 | std::vector<std::string> newActions = {"LogToMetricReportsCollection", |
| 406 | "EmitsReadingsUpdate"}; |
| 407 | std::vector<std::string> expectedActions = {"EmitsReadingsUpdate", |
| 408 | "LogToMetricReportsCollection"}; |
| 409 | |
| 410 | sut = makeReport( |
| 411 | ReportParams() |
| 412 | .reportId("TestId_1") |
| 413 | .reportActions(utils::transform(newActions, [](const auto& action) { |
| 414 | return utils::toReportAction(action); |
| 415 | }))); |
| 416 | EXPECT_THAT( |
| 417 | getProperty<std::vector<std::string>>(sut->getPath(), "ReportActions"), |
| 418 | Eq(expectedActions)); |
| 419 | } |
| 420 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 421 | TEST_F(TestReport, setEnabledWithNewValue) |
| 422 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 423 | bool newValue = !defaultParams().enabled(); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 424 | EXPECT_THAT(setProperty(sut->getPath(), "Enabled", newValue).value(), |
| 425 | Eq(boost::system::errc::success)); |
| 426 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), Eq(newValue)); |
| 427 | } |
| 428 | |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 429 | TEST_F(TestReport, setIntervalWithValidValue) |
| 430 | { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 431 | uint64_t newValue = ReportManager::minInterval.count() * 42; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 432 | EXPECT_THAT(setProperty(sut->getPath(), "Interval", newValue).value(), |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 433 | Eq(boost::system::errc::success)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 434 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
| 435 | Eq(newValue)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 436 | } |
| 437 | |
Szymon Dompke | 3e2cc9d | 2021-12-14 12:00:52 +0100 | [diff] [blame] | 438 | TEST_F( |
| 439 | TestReport, |
| 440 | settingIntervalWithInvalidValueDoesNotChangePropertyAndReturnsInvalidArgument) |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 441 | { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 442 | uint64_t newValue = ReportManager::minInterval.count() - 1; |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 443 | EXPECT_THAT(setProperty(sut->getPath(), "Interval", newValue).value(), |
Szymon Dompke | 3e2cc9d | 2021-12-14 12:00:52 +0100 | [diff] [blame] | 444 | Eq(boost::system::errc::invalid_argument)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 445 | EXPECT_THAT(getProperty<uint64_t>(sut->getPath(), "Interval"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 446 | Eq(defaultParams().interval().count())); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 447 | } |
| 448 | |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 449 | TEST_F(TestReport, settingInvalidReportingTypeCreatesErrorMessage) |
| 450 | { |
| 451 | auto report = makeReport(defaultParams() |
| 452 | .reportId("report2") |
| 453 | .reportingType(ReportingType::onRequest) |
| 454 | .interval(Milliseconds{0})); |
| 455 | |
| 456 | EXPECT_THAT( |
| 457 | setProperty<std::string>(report->getPath(), "ReportingType", "Periodic") |
| 458 | .value(), |
| 459 | Eq(boost::system::errc::success)); |
| 460 | |
| 461 | EXPECT_THAT(getProperty<std::string>(report->getPath(), "ReportingType"), |
| 462 | Eq("Periodic")); |
| 463 | EXPECT_THAT( |
| 464 | getProperty<ErrorMessagesDbusType>(report->getPath(), "ErrorMessages"), |
| 465 | UnorderedElementsAre( |
| 466 | ErrorMessageDbusType( |
| 467 | utils::enumToString(ErrorType::propertyConflict), "Interval"), |
| 468 | ErrorMessageDbusType( |
| 469 | utils::enumToString(ErrorType::propertyConflict), |
| 470 | "ReportingType"))); |
| 471 | } |
| 472 | |
| 473 | TEST_F(TestReport, settingValidReportingTypeRemovesErrors) |
| 474 | { |
| 475 | auto report = makeReport(defaultParams() |
| 476 | .reportId("report2") |
| 477 | .reportingType(ReportingType::onRequest) |
| 478 | .interval(Milliseconds{0})); |
| 479 | |
| 480 | EXPECT_THAT( |
| 481 | setProperty<std::string>(report->getPath(), "ReportingType", "Periodic") |
| 482 | .value(), |
| 483 | Eq(boost::system::errc::success)); |
| 484 | EXPECT_THAT(setProperty<std::string>(report->getPath(), "ReportingType", |
| 485 | "OnRequest") |
| 486 | .value(), |
| 487 | Eq(boost::system::errc::success)); |
| 488 | |
| 489 | EXPECT_THAT(getProperty<std::string>(report->getPath(), "ReportingType"), |
| 490 | Eq("OnRequest")); |
| 491 | EXPECT_THAT( |
| 492 | getProperty<ErrorMessagesDbusType>(report->getPath(), "ErrorMessages"), |
| 493 | IsEmpty()); |
| 494 | } |
| 495 | |
| 496 | TEST_F(TestReport, settingInvalidIntervalDisablesReport) |
| 497 | { |
| 498 | auto report = makeReport(defaultParams() |
| 499 | .reportId("report2") |
| 500 | .reportingType(ReportingType::periodic) |
| 501 | .interval(ReportManager::minInterval)); |
| 502 | |
| 503 | EXPECT_THAT(setProperty<uint64_t>(report->getPath(), "Interval", 0).value(), |
| 504 | Eq(boost::system::errc::success)); |
| 505 | |
| 506 | EXPECT_THAT(getProperty<uint64_t>(report->getPath(), "Interval"), Eq(0u)); |
| 507 | EXPECT_THAT( |
| 508 | getProperty<ErrorMessagesDbusType>(report->getPath(), "ErrorMessages"), |
| 509 | UnorderedElementsAre( |
| 510 | ErrorMessageDbusType( |
| 511 | utils::enumToString(ErrorType::propertyConflict), "Interval"), |
| 512 | ErrorMessageDbusType( |
| 513 | utils::enumToString(ErrorType::propertyConflict), |
| 514 | "ReportingType"))); |
| 515 | } |
| 516 | |
| 517 | TEST_F(TestReport, settingValidIntervalEnablesReport) |
| 518 | { |
| 519 | auto report = makeReport(defaultParams() |
| 520 | .reportId("report2") |
| 521 | .reportingType(ReportingType::periodic) |
| 522 | .interval(ReportManager::minInterval)); |
| 523 | |
| 524 | EXPECT_THAT(setProperty<uint64_t>(report->getPath(), "Interval", 0).value(), |
| 525 | Eq(boost::system::errc::success)); |
| 526 | EXPECT_THAT(setProperty<uint64_t>(report->getPath(), "Interval", |
| 527 | ReportManager::minInterval.count()) |
| 528 | .value(), |
| 529 | Eq(boost::system::errc::success)); |
| 530 | |
| 531 | EXPECT_THAT(getProperty<uint64_t>(report->getPath(), "Interval"), |
| 532 | Eq(ReportManager::minInterval.count())); |
| 533 | EXPECT_THAT( |
| 534 | getProperty<ErrorMessagesDbusType>(report->getPath(), "ErrorMessages"), |
| 535 | IsEmpty()); |
| 536 | } |
| 537 | |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 538 | TEST_F(TestReport, settingEmitsReadingsUpdateHaveNoEffect) |
| 539 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 540 | EXPECT_THAT( |
| 541 | setProperty(sut->getPath(), "EmitsReadingsUpdate", true).value(), |
| 542 | Eq(boost::system::errc::read_only_file_system)); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 543 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "EmitsReadingsUpdate"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 544 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 545 | ReportAction::emitsReadingsUpdate))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 546 | } |
| 547 | |
| 548 | TEST_F(TestReport, settingLogToMetricReportCollectionHaveNoEffect) |
| 549 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 550 | EXPECT_THAT( |
| 551 | setProperty(sut->getPath(), "LogToMetricReportsCollection", true) |
| 552 | .value(), |
| 553 | Eq(boost::system::errc::read_only_file_system)); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 554 | EXPECT_THAT( |
| 555 | getProperty<bool>(sut->getPath(), "LogToMetricReportsCollection"), |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 556 | Eq(utils::contains(defaultParams().reportActions(), |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 557 | ReportAction::logToMetricReportsCollection))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 558 | } |
| 559 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 560 | TEST_F(TestReport, settingPersistencyToFalseRemovesReportFromStorage) |
| 561 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 562 | EXPECT_CALL(storageMock, store(_, _)).Times(0); |
| 563 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))) |
| 564 | .Times(AtLeast(1)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 565 | |
| 566 | bool persistency = false; |
| 567 | EXPECT_THAT(setProperty(sut->getPath(), "Persistency", persistency).value(), |
| 568 | Eq(boost::system::errc::success)); |
| 569 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Persistency"), |
| 570 | Eq(persistency)); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 571 | } |
| 572 | |
| 573 | TEST_F(TestReport, deleteReport) |
| 574 | { |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 575 | EXPECT_CALL(*reportManagerMock, removeReport(sut.get())); |
| 576 | auto ec = deleteReport(sut->getPath()); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 577 | EXPECT_THAT(ec, Eq(boost::system::errc::success)); |
| 578 | } |
| 579 | |
| 580 | TEST_F(TestReport, deletingNonExistingReportReturnInvalidRequestDescriptor) |
| 581 | { |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 582 | auto ec = |
| 583 | deleteReport(utils::constants::reportDirPath.str + "NonExisting"s); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 584 | EXPECT_THAT(ec.value(), Eq(EBADR)); |
| 585 | } |
| 586 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 587 | TEST_F(TestReport, deleteReportExpectThatFileIsRemoveFromStorage) |
| 588 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 589 | EXPECT_CALL(storageMock, store(_, _)).Times(0); |
| 590 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))) |
| 591 | .Times(AtLeast(1)); |
| 592 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 593 | auto ec = deleteReport(sut->getPath()); |
| 594 | EXPECT_THAT(ec, Eq(boost::system::errc::success)); |
| 595 | } |
| 596 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 597 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsAdded) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 598 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 599 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 600 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 601 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 602 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 603 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 604 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 605 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 606 | messages::Presence::Exist, "trigger2", {"someOtherReport"}}); |
| 607 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 608 | messages::Presence::Exist, |
| 609 | "trigger3", |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 610 | {"someOtherReport", defaultParams().reportId()}}); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 611 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 612 | EXPECT_THAT( |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 613 | getProperty<std::vector<object_path>>(sut->getPath(), "Triggers"), |
| 614 | UnorderedElementsAre(utils::constants::triggerDirPath / "trigger1", |
| 615 | utils::constants::triggerDirPath / "trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 616 | } |
| 617 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 618 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsRemoved) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 619 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 620 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
| 621 | |
| 622 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 623 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 624 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 625 | messages::Presence::Exist, "trigger2", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 626 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 627 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 628 | |
| 629 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 630 | messages::Presence::Removed, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 631 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 632 | messages::Presence::Removed, "trigger2", {}}); |
| 633 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 634 | messages::Presence::Removed, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 635 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 636 | EXPECT_THAT( |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 637 | getProperty<std::vector<object_path>>(sut->getPath(), "Triggers"), |
| 638 | UnorderedElementsAre(utils::constants::triggerDirPath / "trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 639 | } |
| 640 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 641 | TEST_F(TestReport, updatesTriggerIdWhenTriggerIsModified) |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 642 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 643 | utils::Messanger messanger(DbusEnvironment::getIoc()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 644 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 645 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 646 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 647 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 648 | messages::Presence::Exist, "trigger2", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 649 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 650 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 651 | |
| 652 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 653 | messages::Presence::Exist, "trigger1", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 654 | messanger.send(messages::TriggerPresenceChangedInd{ |
| 655 | messages::Presence::Exist, "trigger2", {}}); |
| 656 | messanger.send(messages::TriggerPresenceChangedInd{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 657 | messages::Presence::Exist, "trigger3", {defaultParams().reportId()}}); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 658 | |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 659 | EXPECT_THAT( |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 660 | getProperty<std::vector<object_path>>(sut->getPath(), "Triggers"), |
| 661 | UnorderedElementsAre(utils::constants::triggerDirPath / "trigger1", |
| 662 | utils::constants::triggerDirPath / "trigger3")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 663 | } |
| 664 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 665 | class TestReportStore : |
| 666 | public TestReport, |
| 667 | public WithParamInterface<std::pair<std::string, nlohmann::json>> |
| 668 | { |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 669 | void SetUp() override |
| 670 | {} |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 671 | }; |
| 672 | |
| 673 | INSTANTIATE_TEST_SUITE_P( |
| 674 | _, TestReportStore, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 675 | Values( |
| 676 | std::make_pair("Enabled"s, nlohmann::json(defaultParams().enabled())), |
| 677 | std::make_pair("Version"s, nlohmann::json(6)), |
| 678 | std::make_pair("Id"s, nlohmann::json(defaultParams().reportId())), |
| 679 | std::make_pair("Name"s, nlohmann::json(defaultParams().reportName())), |
| 680 | std::make_pair("ReportingType", |
| 681 | nlohmann::json(defaultParams().reportingType())), |
| 682 | std::make_pair("ReportActions", nlohmann::json(utils::transform( |
| 683 | defaultParams().reportActions(), |
| 684 | [](const auto v) { |
| 685 | return utils::toUnderlying(v); |
| 686 | }))), |
| 687 | std::make_pair("Interval", |
| 688 | nlohmann::json(defaultParams().interval().count())), |
| 689 | std::make_pair("AppendLimit", |
| 690 | nlohmann::json(ReportParams().appendLimit())), |
| 691 | std::make_pair( |
| 692 | "ReadingParameters", |
| 693 | nlohmann::json( |
| 694 | {{{tstring::SensorPath::str(), |
| 695 | {{{tstring::Service::str(), "Service"}, |
| 696 | {tstring::Path::str(), |
| 697 | "/xyz/openbmc_project/sensors/power/p1"}, |
| 698 | {tstring::Metadata::str(), "metadata1"}}}}, |
| 699 | {tstring::OperationType::str(), OperationType::avg}, |
| 700 | {tstring::Id::str(), "MetricId1"}, |
| 701 | {tstring::CollectionTimeScope::str(), |
| 702 | CollectionTimeScope::point}, |
| 703 | {tstring::CollectionDuration::str(), 0}}, |
| 704 | {{tstring::SensorPath::str(), |
| 705 | {{{tstring::Service::str(), "Service"}, |
| 706 | {tstring::Path::str(), |
| 707 | "/xyz/openbmc_project/sensors/power/p2"}, |
| 708 | {tstring::Metadata::str(), "metadata2"}}}}, |
| 709 | {tstring::OperationType::str(), OperationType::avg}, |
| 710 | {tstring::Id::str(), "MetricId2"}, |
| 711 | {tstring::CollectionTimeScope::str(), |
| 712 | CollectionTimeScope::point}, |
| 713 | {tstring::CollectionDuration::str(), 0}}})))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 714 | |
| 715 | TEST_P(TestReportStore, settingPersistencyToTrueStoresReport) |
| 716 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 717 | sut = makeReport(defaultParams()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 718 | |
| 719 | { |
| 720 | InSequence seq; |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 721 | EXPECT_CALL(storageMock, remove(to_file_path(sut->getId()))); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 722 | EXPECT_CALL(checkPoint, Call()); |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 723 | EXPECT_CALL(storageMock, store(to_file_path(sut->getId()), _)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 724 | } |
| 725 | |
| 726 | setProperty(sut->getPath(), "Persistency", false); |
| 727 | checkPoint.Call(); |
| 728 | setProperty(sut->getPath(), "Persistency", true); |
| 729 | |
| 730 | const auto& [key, value] = GetParam(); |
| 731 | |
| 732 | ASSERT_THAT(storedConfiguration.at(key), Eq(value)); |
| 733 | } |
| 734 | |
| 735 | TEST_P(TestReportStore, reportIsSavedToStorageAfterCreated) |
| 736 | { |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 737 | EXPECT_CALL(storageMock, |
| 738 | store(to_file_path(defaultParams().reportId()), _)); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 739 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 740 | sut = makeReport(defaultParams()); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 741 | |
| 742 | const auto& [key, value] = GetParam(); |
| 743 | |
| 744 | ASSERT_THAT(storedConfiguration.at(key), Eq(value)); |
| 745 | } |
| 746 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 747 | class TestReportValidNames : |
| 748 | public TestReport, |
| 749 | public WithParamInterface<ReportParams> |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 750 | { |
| 751 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 752 | void SetUp() override |
| 753 | {} |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 754 | }; |
| 755 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 756 | INSTANTIATE_TEST_SUITE_P( |
| 757 | ValidNames, TestReportValidNames, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 758 | Values(defaultParams().reportName("Valid_1"), |
| 759 | defaultParams().reportName("Valid_1/Valid_2"), |
| 760 | defaultParams().reportName("Valid_1/Valid_2/Valid_3"))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 761 | |
| 762 | TEST_P(TestReportValidNames, reportCtorDoesNotThrowOnValidName) |
| 763 | { |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 764 | EXPECT_NO_THROW(makeReport(GetParam())); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 765 | } |
| 766 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 767 | class TestReportInvalidIds : |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 768 | public TestReport, |
| 769 | public WithParamInterface<ReportParams> |
| 770 | { |
| 771 | public: |
| 772 | void SetUp() override |
| 773 | {} |
| 774 | }; |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 775 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 776 | INSTANTIATE_TEST_SUITE_P(InvalidNames, TestReportInvalidIds, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 777 | Values(defaultParams().reportId("/"), |
| 778 | defaultParams().reportId("/Invalid"), |
| 779 | defaultParams().reportId("Invalid/"), |
| 780 | defaultParams().reportId("Invalid/Invalid/"), |
| 781 | defaultParams().reportId("Invalid?"))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 782 | |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 783 | TEST_P(TestReportInvalidIds, failsToCreateReportWithInvalidName) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 784 | { |
| 785 | EXPECT_CALL(storageMock, store).Times(0); |
Krzysztof Grobelny | b8cc78d | 2021-11-29 15:54:53 +0100 | [diff] [blame] | 786 | |
| 787 | EXPECT_THROW(makeReport(GetParam()), sdbusplus::exception::SdBusError); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 788 | } |
| 789 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 790 | class TestReportAllReportTypes : |
| 791 | public TestReport, |
| 792 | public WithParamInterface<ReportParams> |
| 793 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 794 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 795 | void SetUp() override |
| 796 | { |
| 797 | sut = makeReport(GetParam()); |
| 798 | } |
| 799 | }; |
| 800 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 801 | INSTANTIATE_TEST_SUITE_P( |
| 802 | _, TestReportAllReportTypes, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 803 | Values(defaultParams().reportingType(ReportingType::onRequest), |
| 804 | defaultParams().reportingType(ReportingType::onChange), |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 805 | defaultParams() |
| 806 | .reportingType(ReportingType::periodic) |
| 807 | .interval(ReportManager::minInterval))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 808 | |
| 809 | TEST_P(TestReportAllReportTypes, returnPropertValueOfReportType) |
| 810 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 811 | EXPECT_THAT(utils::toReportingType( |
| 812 | getProperty<std::string>(sut->getPath(), "ReportingType")), |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 813 | Eq(GetParam().reportingType())); |
| 814 | } |
| 815 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 816 | TEST_P(TestReportAllReportTypes, readingsAreUpdated) |
| 817 | { |
| 818 | clockFake.system.advance(10ms); |
| 819 | |
| 820 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
| 821 | const auto [timestamp, readings] = |
| 822 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 823 | |
| 824 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
| 825 | } |
| 826 | |
| 827 | TEST_P(TestReportAllReportTypes, readingsAreNotUpdatedWhenReportIsDisabled) |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 828 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 829 | clockFake.system.advance(10ms); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 830 | |
| 831 | setProperty(sut->getPath(), "Enabled", false); |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 832 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 833 | const auto [timestamp, readings] = |
| 834 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 835 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 836 | EXPECT_THAT(Milliseconds{timestamp}, Eq(0ms)); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 837 | } |
| 838 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 839 | TEST_P(TestReportAllReportTypes, readingsAreNotUpdatedWhenReportIdDiffers) |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 840 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 841 | clockFake.system.advance(10ms); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 842 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 843 | messanger.send(messages::UpdateReportInd{{sut->getId() + "x"s}}); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 844 | const auto [timestamp, readings] = |
| 845 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 846 | |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 847 | EXPECT_THAT(Milliseconds{timestamp}, Eq(0ms)); |
Wludzik, Jozef | d960e1f | 2021-01-08 09:25:59 +0100 | [diff] [blame] | 848 | } |
| 849 | |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 850 | class TestReportOnRequestType : public TestReport |
| 851 | { |
| 852 | void SetUp() override |
| 853 | { |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 854 | sut = |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 855 | makeReport(defaultParams().reportingType(ReportingType::onRequest)); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 856 | } |
| 857 | }; |
| 858 | |
| 859 | TEST_F(TestReportOnRequestType, updatesReadingTimestamp) |
| 860 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 861 | clockFake.system.advance(10ms); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 862 | |
| 863 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 864 | |
| 865 | const auto [timestamp, readings] = |
| 866 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 867 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 868 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 869 | } |
| 870 | |
| 871 | TEST_F(TestReportOnRequestType, updatesReadingWhenUpdateIsCalled) |
| 872 | { |
| 873 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 874 | |
| 875 | const auto [timestamp, readings] = |
| 876 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 877 | |
| 878 | EXPECT_THAT(readings, |
| 879 | ElementsAre(std::make_tuple("a"s, "b"s, 17.1, 114u), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 880 | std::make_tuple("aa"s, "bb"s, 42.0, 74u))); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 881 | } |
| 882 | |
| 883 | class TestReportNonOnRequestType : |
| 884 | public TestReport, |
| 885 | public WithParamInterface<ReportParams> |
| 886 | { |
| 887 | void SetUp() override |
| 888 | { |
| 889 | sut = makeReport(GetParam()); |
| 890 | } |
| 891 | }; |
| 892 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 893 | INSTANTIATE_TEST_SUITE_P( |
| 894 | _, TestReportNonOnRequestType, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 895 | Values(defaultParams().reportingType(ReportingType::periodic), |
| 896 | defaultParams().reportingType(ReportingType::onChange))); |
Krzysztof Grobelny | f32f6fe | 2020-10-30 13:51:58 +0100 | [diff] [blame] | 897 | |
| 898 | TEST_P(TestReportNonOnRequestType, readingsAreNotUpdateOnUpdateCall) |
| 899 | { |
| 900 | ASSERT_THAT(update(sut->getPath()), Eq(boost::system::errc::success)); |
| 901 | |
| 902 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 903 | Eq(Readings{})); |
| 904 | } |
| 905 | |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 906 | class TestReportNonPeriodicReport : |
| 907 | public TestReport, |
| 908 | public WithParamInterface<ReportParams> |
| 909 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 910 | public: |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 911 | void SetUp() override |
| 912 | { |
| 913 | sut = makeReport(GetParam()); |
| 914 | } |
| 915 | }; |
| 916 | |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 917 | INSTANTIATE_TEST_SUITE_P( |
| 918 | _, TestReportNonPeriodicReport, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 919 | Values(defaultParams().reportingType(ReportingType::onRequest), |
| 920 | defaultParams().reportingType(ReportingType::onChange))); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 921 | |
| 922 | TEST_P(TestReportNonPeriodicReport, readingsAreNotUpdatedAfterIntervalExpires) |
| 923 | { |
| 924 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 925 | |
| 926 | EXPECT_THAT(getProperty<Readings>(sut->getPath(), "Readings"), |
| 927 | Eq(Readings{})); |
| 928 | } |
| 929 | |
| 930 | class TestReportPeriodicReport : public TestReport |
| 931 | { |
| 932 | void SetUp() override |
| 933 | { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 934 | sut = makeReport(defaultParams() |
| 935 | .reportingType(ReportingType::periodic) |
| 936 | .interval(ReportManager::minInterval)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 937 | } |
| 938 | }; |
| 939 | |
| 940 | TEST_F(TestReportPeriodicReport, readingTimestampIsUpdatedAfterIntervalExpires) |
| 941 | { |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 942 | clockFake.system.advance(10ms); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 943 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 944 | |
| 945 | const auto [timestamp, readings] = |
| 946 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 947 | |
Krzysztof Grobelny | 51f0fd5 | 2021-12-28 16:32:08 +0100 | [diff] [blame] | 948 | EXPECT_THAT(Milliseconds{timestamp}, Eq(systemTimestamp + 10ms)); |
Krzysztof Grobelny | c8e3a64 | 2020-10-23 12:29:16 +0200 | [diff] [blame] | 949 | } |
| 950 | |
| 951 | TEST_F(TestReportPeriodicReport, readingsAreUpdatedAfterIntervalExpires) |
| 952 | { |
| 953 | DbusEnvironment::sleepFor(ReportManager::minInterval + 1ms); |
| 954 | |
| 955 | const auto [timestamp, readings] = |
| 956 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 957 | |
| 958 | EXPECT_THAT(readings, |
| 959 | ElementsAre(std::make_tuple("a"s, "b"s, 17.1, 114u), |
Krzysztof Grobelny | dcc4e19 | 2021-03-08 09:09:34 +0000 | [diff] [blame] | 960 | std::make_tuple("aa"s, "bb"s, 42.0, 74u))); |
Wludzik, Jozef | 2f9f9b8 | 2020-10-13 09:07:45 +0200 | [diff] [blame] | 961 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 962 | |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 963 | struct ReportUpdatesReportParams |
| 964 | { |
| 965 | ReportParams reportParams; |
| 966 | std::vector<ReadingData> expectedReadings; |
| 967 | bool expectedEnabled; |
| 968 | }; |
| 969 | |
| 970 | class TestReportWithReportUpdatesAndLimit : |
| 971 | public TestReport, |
| 972 | public WithParamInterface<ReportUpdatesReportParams> |
| 973 | { |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 974 | public: |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 975 | void SetUp() override |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 976 | {} |
| 977 | |
| 978 | void changeReport(ReportingType rt, Milliseconds interval) |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 979 | { |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 980 | setProperty<std::string>(sut->getPath(), "ReportingType", |
| 981 | utils::enumToString(rt)); |
| 982 | setProperty<uint64_t>(sut->getPath(), "Interval", interval.count()); |
| 983 | } |
| 984 | |
| 985 | auto readings() |
| 986 | { |
| 987 | auto [timestamp, readings] = |
| 988 | getProperty<Readings>(sut->getPath(), "Readings"); |
| 989 | return readings; |
| 990 | } |
| 991 | |
| 992 | void updateReportFourTimes() |
| 993 | { |
| 994 | for (int i = 0; i < 4; i++) |
| 995 | { |
| 996 | messanger.send(messages::UpdateReportInd{{sut->getId()}}); |
| 997 | } |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 998 | } |
| 999 | }; |
| 1000 | |
| 1001 | INSTANTIATE_TEST_SUITE_P( |
| 1002 | _, TestReportWithReportUpdatesAndLimit, |
| 1003 | Values( |
| 1004 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1005 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1006 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 1007 | .appendLimit(5), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1008 | std::vector<ReadingData>{{std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1009 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1010 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1011 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1012 | std::make_tuple("a"s, "b"s, 17.1, 114u)}}, |
| 1013 | true}, |
| 1014 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1015 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1016 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 1017 | .appendLimit(4), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1018 | std::vector<ReadingData>{ |
| 1019 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1020 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1021 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1022 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1023 | true}, |
| 1024 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1025 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1026 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 1027 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1028 | std::vector<ReadingData>{}, true}, |
| 1029 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1030 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1031 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1032 | .appendLimit(10), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1033 | std::vector<ReadingData>{ |
| 1034 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1035 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1036 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1037 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1038 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1039 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1040 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1041 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1042 | true}, |
| 1043 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1044 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1045 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1046 | .appendLimit(5), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1047 | std::vector<ReadingData>{{std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1048 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1049 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1050 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1051 | std::make_tuple("a"s, "b"s, 17.1, 114u)}}, |
| 1052 | false}, |
| 1053 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1054 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1055 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1056 | .appendLimit(4), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1057 | std::vector<ReadingData>{ |
| 1058 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1059 | std::make_tuple("aa"s, "bb"s, 42.0, 74u), |
| 1060 | std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1061 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1062 | false}, |
| 1063 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1064 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1065 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1066 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1067 | std::vector<ReadingData>{}, false}, |
| 1068 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1069 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1070 | .reportUpdates(ReportUpdates::overwrite) |
| 1071 | .appendLimit(500), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1072 | std::vector<ReadingData>{ |
| 1073 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1074 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1075 | true}, |
| 1076 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1077 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1078 | .reportUpdates(ReportUpdates::overwrite) |
| 1079 | .appendLimit(1), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1080 | std::vector<ReadingData>{ |
| 1081 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1082 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1083 | true}, |
| 1084 | ReportUpdatesReportParams{ |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1085 | defaultParams() |
Krzysztof Grobelny | 51497a0 | 2021-11-09 14:56:22 +0100 | [diff] [blame] | 1086 | .reportUpdates(ReportUpdates::overwrite) |
| 1087 | .appendLimit(0), |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1088 | std::vector<ReadingData>{ |
| 1089 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1090 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 1091 | true}, |
| 1092 | ReportUpdatesReportParams{ |
| 1093 | defaultParams() |
| 1094 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1095 | .appendLimit(std::numeric_limits<uint64_t>::max()), |
| 1096 | std::vector<ReadingData>{ |
| 1097 | {std::make_tuple("a"s, "b"s, 17.1, 114u), |
| 1098 | std::make_tuple("aa"s, "bb"s, 42.0, 74u)}}, |
| 1099 | false})); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1100 | |
| 1101 | TEST_P(TestReportWithReportUpdatesAndLimit, |
| 1102 | readingsAreUpdatedAfterIntervalExpires) |
| 1103 | { |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 1104 | sut = makeReport(ReportParams(GetParam().reportParams) |
| 1105 | .reportingType(ReportingType::periodic) |
| 1106 | .interval(std::chrono::hours(1000))); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1107 | |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 1108 | updateReportFourTimes(); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1109 | |
Krzysztof Grobelny | a8182be | 2022-07-04 11:26:20 +0200 | [diff] [blame^] | 1110 | EXPECT_THAT(readings(), ElementsAreArray(GetParam().expectedReadings)); |
| 1111 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), |
| 1112 | Eq(GetParam().expectedEnabled)); |
| 1113 | } |
| 1114 | |
| 1115 | TEST_P(TestReportWithReportUpdatesAndLimit, |
| 1116 | appendLimitIsRespectedAfterChangingToPeriodic) |
| 1117 | { |
| 1118 | sut = makeReport(ReportParams(GetParam().reportParams) |
| 1119 | .reportingType(ReportingType::onRequest) |
| 1120 | .interval(std::chrono::hours(0))); |
| 1121 | |
| 1122 | changeReport(ReportingType::periodic, std::chrono::hours(1000)); |
| 1123 | updateReportFourTimes(); |
| 1124 | |
| 1125 | EXPECT_THAT(readings(), ElementsAreArray(GetParam().expectedReadings)); |
| 1126 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), |
| 1127 | Eq(GetParam().expectedEnabled)); |
| 1128 | } |
| 1129 | |
| 1130 | TEST_P(TestReportWithReportUpdatesAndLimit, |
| 1131 | appendLimitIsIgnoredAfterChangingToOnRequest) |
| 1132 | { |
| 1133 | sut = makeReport(ReportParams(GetParam().reportParams) |
| 1134 | .reportingType(ReportingType::periodic) |
| 1135 | .interval(std::chrono::hours(1000))); |
| 1136 | |
| 1137 | changeReport(ReportingType::onRequest, Milliseconds{0}); |
| 1138 | updateReportFourTimes(); |
| 1139 | |
| 1140 | EXPECT_THAT(readings(), SizeIs(2u)); |
| 1141 | EXPECT_THAT(getProperty<bool>(sut->getPath(), "Enabled"), Eq(true)); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1142 | } |
| 1143 | |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1144 | class TestReportInitialization : public TestReport |
| 1145 | { |
| 1146 | public: |
| 1147 | void SetUp() override |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1148 | { |
| 1149 | initMetricMocks(defaultParams().metricParameters()); |
| 1150 | } |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1151 | |
Patrick Williams | 39cc6ac | 2022-07-22 19:26:56 -0500 | [diff] [blame] | 1152 | void monitorProc(sdbusplus::message_t& msg) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1153 | { |
| 1154 | std::string iface; |
| 1155 | std::vector<std::pair<std::string, std::variant<Readings>>> |
| 1156 | changed_properties; |
| 1157 | std::vector<std::string> invalidated_properties; |
| 1158 | |
| 1159 | msg.read(iface, changed_properties, invalidated_properties); |
| 1160 | |
| 1161 | if (iface == Report::reportIfaceName) |
| 1162 | { |
| 1163 | for (const auto& [name, value] : changed_properties) |
| 1164 | { |
| 1165 | if (name == "Readings") |
| 1166 | { |
| 1167 | readingsUpdated.Call(); |
| 1168 | } |
| 1169 | } |
| 1170 | } |
| 1171 | } |
| 1172 | |
| 1173 | void makeMonitor() |
| 1174 | { |
Patrick Williams | 3a62ee1 | 2021-12-03 10:13:25 -0600 | [diff] [blame] | 1175 | monitor = std::make_unique<sdbusplus::bus::match_t>( |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1176 | *DbusEnvironment::getBus(), |
| 1177 | sdbusplus::bus::match::rules::propertiesChanged( |
| 1178 | sut->getPath(), Report::reportIfaceName), |
| 1179 | [this](auto& msg) { monitorProc(msg); }); |
| 1180 | } |
| 1181 | |
Patrick Williams | 3a62ee1 | 2021-12-03 10:13:25 -0600 | [diff] [blame] | 1182 | std::unique_ptr<sdbusplus::bus::match_t> monitor; |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1183 | MockFunction<void()> readingsUpdated; |
| 1184 | }; |
| 1185 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1186 | TEST_F(TestReportInitialization, |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1187 | registersForMetricUpdatesWhenOnChangeReportCreated) |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1188 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1189 | std::vector<const interfaces::MetricListener*> args; |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1190 | for (auto& metric : metricMocks) |
| 1191 | { |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1192 | EXPECT_CALL(*metric, registerForUpdates(_)) |
| 1193 | .WillOnce(Invoke([&args](const interfaces::MetricListener& report) { |
| 1194 | args.emplace_back(&report); |
| 1195 | })); |
| 1196 | ; |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1197 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1198 | |
| 1199 | sut = makeReport(defaultParams().reportingType(ReportingType::onChange)); |
| 1200 | |
| 1201 | EXPECT_THAT(args, SizeIs(metricMocks.size())); |
| 1202 | for (const auto* reportPtr : args) |
| 1203 | { |
| 1204 | EXPECT_THAT(reportPtr, Eq(sut.get())); |
| 1205 | } |
| 1206 | } |
| 1207 | |
| 1208 | TEST_F(TestReportInitialization, |
| 1209 | deregistersForMetricUpdatesWhenOnChangeReportDestroyed) |
| 1210 | { |
| 1211 | sut = makeReport(defaultParams().reportingType(ReportingType::onChange)); |
| 1212 | |
| 1213 | for (auto& metric : metricMocks) |
| 1214 | { |
| 1215 | EXPECT_CALL(*metric, |
| 1216 | unregisterFromUpdates(Ref( |
| 1217 | static_cast<interfaces::MetricListener&>(*sut.get())))); |
| 1218 | } |
| 1219 | |
| 1220 | sut = nullptr; |
| 1221 | } |
| 1222 | |
| 1223 | TEST_F(TestReportInitialization, |
| 1224 | metricsAreInitializedWhenEnabledReportConstructed) |
| 1225 | { |
| 1226 | for (auto& metric : metricMocks) |
| 1227 | { |
| 1228 | EXPECT_CALL(*metric, initialize()); |
| 1229 | } |
| 1230 | sut = makeReport(defaultParams().enabled(true)); |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1231 | } |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1232 | |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1233 | TEST_F(TestReportInitialization, |
| 1234 | metricsAreNotInitializedWhenDisabledReportConstructed) |
| 1235 | { |
Lukasz Kazmierczak | 7e098e9 | 2021-09-16 15:59:56 +0200 | [diff] [blame] | 1236 | for (auto& metric : metricMocks) |
| 1237 | { |
| 1238 | EXPECT_CALL(*metric, initialize()).Times(0); |
| 1239 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1240 | sut = makeReport(defaultParams().enabled(false)); |
Krzysztof Grobelny | 6ccfcbf | 2020-11-04 09:31:36 +0100 | [diff] [blame] | 1241 | } |
| 1242 | |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1243 | TEST_F(TestReportInitialization, |
| 1244 | emitReadingsUpdateIsTrueReadingsPropertiesChangedSingalEmits) |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1245 | { |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1246 | EXPECT_CALL(readingsUpdated, Call()) |
| 1247 | .WillOnce( |
| 1248 | InvokeWithoutArgs(DbusEnvironment::setPromise("readingsUpdated"))); |
| 1249 | |
| 1250 | const auto elapsed = DbusEnvironment::measureTime([this] { |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 1251 | sut = makeReport(defaultParams() |
| 1252 | .reportingType(ReportingType::periodic) |
| 1253 | .reportActions({ReportAction::emitsReadingsUpdate}) |
| 1254 | .interval(ReportManager::minInterval)); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1255 | makeMonitor(); |
| 1256 | EXPECT_TRUE(DbusEnvironment::waitForFuture("readingsUpdated")); |
| 1257 | }); |
| 1258 | |
Krzysztof Grobelny | 973b4bb | 2022-04-25 17:07:27 +0200 | [diff] [blame] | 1259 | EXPECT_THAT(elapsed, AllOf(Ge(ReportManager::minInterval), |
| 1260 | Lt(ReportManager::minInterval * 2))); |
Wludzik, Jozef | b1ff1f6 | 2020-10-23 13:20:52 +0200 | [diff] [blame] | 1261 | } |
| 1262 | |
| 1263 | TEST_F(TestReportInitialization, |
| 1264 | emitReadingsUpdateIsFalseReadingsPropertiesChangesSigalDoesNotEmits) |
| 1265 | { |
| 1266 | EXPECT_CALL(readingsUpdated, Call()).Times(0); |
| 1267 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1268 | sut = makeReport(defaultParams() |
| 1269 | .reportingType(ReportingType::periodic) |
| 1270 | .reportActions({})); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1271 | makeMonitor(); |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1272 | DbusEnvironment::sleepFor(defaultParams().interval() * 2); |
Wludzik, Jozef | e236279 | 2020-10-27 17:23:55 +0100 | [diff] [blame] | 1273 | } |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1274 | |
| 1275 | TEST_F(TestReportInitialization, appendLimitDeducedProperly) |
| 1276 | { |
| 1277 | sut = makeReport( |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1278 | defaultParams().appendLimit(std::numeric_limits<uint64_t>::max())); |
Szymon Dompke | 3eb5686 | 2021-09-20 15:32:04 +0200 | [diff] [blame] | 1279 | auto appendLimit = getProperty<uint64_t>(sut->getPath(), "AppendLimit"); |
| 1280 | EXPECT_EQ(appendLimit, 2ull); |
| 1281 | } |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 1282 | |
| 1283 | TEST_F(TestReportInitialization, appendLimitSetToUintMaxIsStoredCorrectly) |
| 1284 | { |
Krzysztof Grobelny | e6c417c | 2022-02-02 17:25:53 +0100 | [diff] [blame] | 1285 | sut = makeReport( |
| 1286 | ReportParams().appendLimit(std::numeric_limits<uint64_t>::max())); |
| 1287 | |
| 1288 | ASSERT_THAT(storedConfiguration.at("AppendLimit"), |
| 1289 | Eq(std::numeric_limits<uint64_t>::max())); |
| 1290 | } |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 1291 | |
| 1292 | TEST_F(TestReportInitialization, triggerIdsPropertyIsInitialzed) |
| 1293 | { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 1294 | for (const auto& triggerId : {"trigger1", "trigger2"}) |
| 1295 | { |
| 1296 | messanger.on_receive<messages::CollectTriggerIdReq>( |
Szymon Dompke | e0ed508 | 2022-05-20 10:54:25 +0200 | [diff] [blame] | 1297 | [this, triggerId](const auto& msg) { |
Krzysztof Grobelny | e6d4887 | 2022-02-08 13:41:30 +0100 | [diff] [blame] | 1298 | messanger.send(messages::CollectTriggerIdResp{triggerId}); |
| 1299 | }); |
| 1300 | } |
| 1301 | |
| 1302 | sut = makeReport(ReportParams()); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 1303 | |
| 1304 | EXPECT_THAT( |
Szymon Dompke | 1cdd7e4 | 2022-06-08 14:43:13 +0200 | [diff] [blame] | 1305 | getProperty<std::vector<object_path>>(sut->getPath(), "Triggers"), |
| 1306 | UnorderedElementsAre(utils::constants::triggerDirPath / "trigger1", |
| 1307 | utils::constants::triggerDirPath / "trigger2")); |
Szymon Dompke | b4ef22e | 2022-02-07 15:15:12 +0100 | [diff] [blame] | 1308 | } |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1309 | |
Krzysztof Grobelny | 493e62e | 2022-02-14 10:55:50 +0100 | [diff] [blame] | 1310 | TEST_F(TestReportInitialization, |
| 1311 | metricValuesAreNotStoredForReportUpdatesDifferentThanAppendStopsWhenFull) |
| 1312 | { |
| 1313 | sut = makeReport(ReportParams() |
| 1314 | .reportingType(ReportingType::periodic) |
| 1315 | .interval(1h) |
| 1316 | .reportUpdates(ReportUpdates::appendWrapsWhenFull) |
| 1317 | .readings(Readings{{}, {{}}})); |
| 1318 | |
| 1319 | ASSERT_THAT(storedConfiguration.find("MetricValues"), |
| 1320 | Eq(storedConfiguration.end())); |
| 1321 | } |
| 1322 | |
| 1323 | TEST_F(TestReportInitialization, metricValuesAreNotStoredForOnRequestReport) |
| 1324 | { |
| 1325 | sut = makeReport(ReportParams() |
| 1326 | .reportingType(ReportingType::onRequest) |
| 1327 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1328 | .readings(Readings{{}, {{}}})); |
| 1329 | |
| 1330 | ASSERT_THAT(storedConfiguration.find("MetricValues"), |
| 1331 | Eq(storedConfiguration.end())); |
| 1332 | } |
| 1333 | |
| 1334 | TEST_F(TestReportInitialization, |
| 1335 | metricValuesAreStoredForNonOnRequestReportWithAppendStopsWhenFull) |
| 1336 | { |
| 1337 | const auto readings = Readings{{}, {{}}}; |
| 1338 | |
| 1339 | sut = makeReport(ReportParams() |
| 1340 | .reportingType(ReportingType::periodic) |
| 1341 | .interval(1h) |
| 1342 | .reportUpdates(ReportUpdates::appendStopsWhenFull) |
| 1343 | .readings(readings)); |
| 1344 | |
| 1345 | ASSERT_THAT(storedConfiguration.at("MetricValues").get<LabeledReadings>(), |
| 1346 | Eq(utils::toLabeledReadings(readings))); |
| 1347 | } |
| 1348 | |
Krzysztof Grobelny | f7ea299 | 2022-01-27 11:04:58 +0100 | [diff] [blame] | 1349 | class TestReportInitializationOnChangeReport : public TestReportInitialization |
| 1350 | { |
| 1351 | public: |
| 1352 | void SetUp() override |
| 1353 | { |
| 1354 | initMetricMocks(params.metricParameters()); |
| 1355 | } |
| 1356 | |
| 1357 | ReportParams params = defaultOnChangeParams(); |
| 1358 | }; |
| 1359 | |
| 1360 | TEST_F(TestReportInitializationOnChangeReport, |
| 1361 | doesntUpdateReadingsWhenNotRequired) |
| 1362 | { |
| 1363 | EXPECT_CALL(*metricMocks[0], updateReadings(_)).Times(0); |
| 1364 | |
| 1365 | ON_CALL(*metricMocks[0], isTimerRequired()).WillByDefault(Return(false)); |
| 1366 | |
| 1367 | sut = makeReport(params); |
| 1368 | |
| 1369 | DbusEnvironment::sleepFor(500ms); |
| 1370 | } |
| 1371 | |
| 1372 | TEST_F(TestReportInitializationOnChangeReport, updatesReadingsWhenRequired) |
| 1373 | { |
| 1374 | EXPECT_CALL(*metricMocks[0], updateReadings(_)) |
| 1375 | .WillOnce(Return()) |
| 1376 | .WillOnce( |
| 1377 | InvokeWithoutArgs(DbusEnvironment::setPromise("readingsUpdated"))) |
| 1378 | .WillRepeatedly(Return()); |
| 1379 | |
| 1380 | ON_CALL(*metricMocks[0], isTimerRequired()).WillByDefault(Return(true)); |
| 1381 | |
| 1382 | sut = makeReport(params); |
| 1383 | |
| 1384 | DbusEnvironment::waitForFuture("readingsUpdated"); |
| 1385 | } |