Change eslint rules to use vue recommended
Resubmitting after reverted–original commit here
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/28763/7
- Ran npm run lint
- Resolved eslint issues
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I2b8b9244acddd483d0a72f9a5d156a79de9869a0
diff --git a/src/views/AccessControl/LocalUserManagement/LocalUserManagement.vue b/src/views/AccessControl/LocalUserManagement/LocalUserManagement.vue
index b81dba6..0ca3428 100644
--- a/src/views/AccessControl/LocalUserManagement/LocalUserManagement.vue
+++ b/src/views/AccessControl/LocalUserManagement/LocalUserManagement.vue
@@ -1,13 +1,13 @@
<template>
<b-container class="ml-0">
- <PageTitle />
+ <page-title />
<b-row>
<b-col lg="10" class="text-right">
<b-button variant="link" @click="initModalSettings">
Account policy settings
<icon-settings />
</b-button>
- <b-button @click="initModalUser(null)" variant="primary">
+ <b-button variant="primary" @click="initModalUser(null)">
Add user
<icon-add />
</b-button>
@@ -69,7 +69,7 @@
import PageTitle from '../../../components/Global/PageTitle';
export default {
- name: 'local-users',
+ name: 'LocalUsers',
components: {
IconAdd,
IconChevron,
@@ -97,9 +97,6 @@
]
};
},
- created() {
- this.getUsers();
- },
computed: {
allUsers() {
return this.$store.getters['localUsers/allUsers'];
@@ -124,6 +121,9 @@
});
}
},
+ created() {
+ this.getUsers();
+ },
methods: {
getUsers() {
this.$store.dispatch('localUsers/getUsers');
diff --git a/src/views/AccessControl/LocalUserManagement/ModalSettings.vue b/src/views/AccessControl/LocalUserManagement/ModalSettings.vue
index dae4d90..a0d6294 100644
--- a/src/views/AccessControl/LocalUserManagement/ModalSettings.vue
+++ b/src/views/AccessControl/LocalUserManagement/ModalSettings.vue
@@ -4,6 +4,11 @@
<script>
export default {
- props: ['settings']
+ props: {
+ settings: {
+ type: String,
+ default: ''
+ }
+ }
};
</script>
diff --git a/src/views/AccessControl/LocalUserManagement/ModalUser.vue b/src/views/AccessControl/LocalUserManagement/ModalUser.vue
index e3ceb7d..d156c3d 100644
--- a/src/views/AccessControl/LocalUserManagement/ModalUser.vue
+++ b/src/views/AccessControl/LocalUserManagement/ModalUser.vue
@@ -37,9 +37,9 @@
No special characters except underscore
</b-form-text>
<b-form-input
+ id="username"
v-model="form.username"
type="text"
- id="username"
aria-describedby="username-help-block"
:state="getValidationState($v.form.username)"
:disabled="!newUser && originalUsername === 'root'"
@@ -78,9 +78,9 @@
Password must between 8 – 20 characters
</b-form-text>
<b-form-input
+ id="password"
v-model="form.password"
type="password"
- id="password"
aria-describedby="password-help-block"
:state="getValidationState($v.form.password)"
@input="$v.form.password.$touch()"
@@ -103,9 +103,9 @@
label-for="password-confirmation"
>
<b-form-input
+ id="password-confirmation"
v-model="form.passwordConfirmation"
type="password"
- id="password-confirmation"
:state="getValidationState($v.form.passwordConfirmation)"
@input="$v.form.passwordConfirmation.$touch()"
/>
@@ -147,8 +147,13 @@
import VuelidateMixin from '../../../components/Mixins/VuelidateMixin.js';
export default {
- props: ['user'],
mixins: [VuelidateMixin],
+ props: {
+ user: {
+ type: Object,
+ default: null
+ }
+ },
data() {
return {
privilegeTypes: ['Administrator', 'Operator', 'ReadOnly', 'NoAccess'],
diff --git a/src/views/AccessControl/LocalUserManagement/TableRoles.vue b/src/views/AccessControl/LocalUserManagement/TableRoles.vue
index 7ea89da..0927c55 100644
--- a/src/views/AccessControl/LocalUserManagement/TableRoles.vue
+++ b/src/views/AccessControl/LocalUserManagement/TableRoles.vue
@@ -2,22 +2,22 @@
<b-table small :items="items" :fields="fields">
<template v-slot:cell(administrator)="data">
<template v-if="data.value">
- <Checkmark20 />
+ <checkmark20 />
</template>
</template>
<template v-slot:cell(operator)="data">
<template v-if="data.value">
- <Checkmark20 />
+ <checkmark20 />
</template>
</template>
<template v-slot:cell(readonly)="data">
<template v-if="data.value">
- <Checkmark20 />
+ <checkmark20 />
</template>
</template>
<template v-slot:cell(noaccess)="data">
<template v-if="data.value">
- <Checkmark20 />
+ <checkmark20 />
</template>
</template>
</b-table>