Change eslint rules to use vue recommended
Resubmitting after reverted–original commit here
https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/28763/7
- Ran npm run lint
- Resolved eslint issues
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: I2b8b9244acddd483d0a72f9a5d156a79de9869a0
diff --git a/src/views/Overview/Overview.vue b/src/views/Overview/Overview.vue
index 2672af7..6ff9f4a 100644
--- a/src/views/Overview/Overview.vue
+++ b/src/views/Overview/Overview.vue
@@ -1,9 +1,9 @@
<template>
<b-container fluid>
- <PageTitle />
+ <page-title />
<b-row>
<b-col lg="8" sm="12">
- <PageSection sectionTitle="Server information">
+ <page-section section-title="Server information">
<b-row>
<b-col sm="6">
<dl>
@@ -30,8 +30,8 @@
</dl>
</b-col>
</b-row>
- </PageSection>
- <PageSection sectionTitle="BMC information">
+ </page-section>
+ <page-section section-title="BMC information">
<b-row>
<b-col sm="6">
<dl>
@@ -48,7 +48,7 @@
<b-col sm="6">
<dl>
<dt>IP address</dt>
- <dd v-for="ip in ipAddress" v-bind:key="ip.id">{{ ip }}</dd>
+ <dd v-for="ip in ipAddress" :key="ip.id">{{ ip }}</dd>
</dl>
</b-col>
<b-col sm="6">
@@ -58,8 +58,8 @@
</dl>
</b-col>
</b-row>
- </PageSection>
- <PageSection sectionTitle="Power consumption">
+ </page-section>
+ <page-section section-title="Power consumption">
<b-row>
<b-col sm="6">
<dl>
@@ -74,15 +74,15 @@
</dl>
</b-col>
</b-row>
- </PageSection>
+ </page-section>
</b-col>
<b-col lg="4" sm="12">
- <OverviewQuickLinks />
+ <overview-quick-links />
</b-col>
</b-row>
- <PageSection sectionTitle="High priority events">
- <OverviewEvents />
- </PageSection>
+ <page-section section-title="High priority events">
+ <overview-events />
+ </page-section>
</b-container>
</template>
@@ -100,9 +100,6 @@
PageTitle,
PageSection
},
- created() {
- this.getOverviewInfo();
- },
computed: mapState({
serverModel: state => state.overview.serverModel,
serverManufacturer: state => state.overview.serverManufacturer,
@@ -115,6 +112,9 @@
ipAddress: state => state.networkSettings.ipAddress,
macAddress: state => state.networkSettings.macAddress
}),
+ created() {
+ this.getOverviewInfo();
+ },
methods: {
getOverviewInfo() {
this.$store.dispatch('overview/getServerInfo');
diff --git a/src/views/Overview/OverviewEvents.vue b/src/views/Overview/OverviewEvents.vue
index 07aab1d..5820e61 100644
--- a/src/views/Overview/OverviewEvents.vue
+++ b/src/views/Overview/OverviewEvents.vue
@@ -8,7 +8,7 @@
<small>{{
logData.Timestamp | date('MMM DD YYYY HH:MM:SS A ZZ')
}}</small>
- <ChevronRight16 />
+ <chevron-right16 />
</div>
<p class="mb-1">{{ logData.eventID }}: {{ logData.description }}</p>
</b-list-group-item>
@@ -22,18 +22,18 @@
<script>
import ChevronRight16 from '@carbon/icons-vue/es/chevron--right/16';
export default {
- name: 'events',
+ name: 'Events',
components: {
ChevronRight16
},
- created() {
- this.getEventLogData();
- },
computed: {
eventLogData() {
return this.$store.getters['eventLog/eventLogData'];
}
},
+ created() {
+ this.getEventLogData();
+ },
methods: {
getEventLogData() {
this.$store.dispatch('eventLog/getEventLogData');
diff --git a/src/views/Overview/OverviewQuickLinks.vue b/src/views/Overview/OverviewQuickLinks.vue
index 726eaf7..d9d86ca 100644
--- a/src/views/Overview/OverviewQuickLinks.vue
+++ b/src/views/Overview/OverviewQuickLinks.vue
@@ -21,7 +21,7 @@
>
<!-- TODO: link to SOL -->
<span>Serial over LAN console</span>
- <ChevronRight16 />
+ <chevron-right16 />
</b-list-group-item>
<b-list-group-item
href="#"
@@ -29,7 +29,7 @@
>
<!-- TODO: link to network settings -->
<span>Edit network settings</span>
- <ChevronRight16 />
+ <chevron-right16 />
</b-list-group-item>
</b-list-group>
</template>
@@ -37,27 +37,27 @@
<script>
import ChevronRight16 from '@carbon/icons-vue/es/chevron--right/16';
export default {
- name: 'quickLinks',
+ name: 'QuickLinks',
components: {
ChevronRight16
},
- created() {
- this.getBmcTime();
+ data() {
+ return {
+ serverLEDChecked: false
+ };
},
computed: {
bmcTime() {
return this.$store.getters['global/bmcTime'];
}
},
+ created() {
+ this.getBmcTime();
+ },
methods: {
getBmcTime() {
this.$store.dispatch('global/getBmcTime');
}
- },
- data() {
- return {
- serverLedChecked: false
- };
}
};
</script>