commit 11bafca85ee2c3f4d4fac5f2ea6b874059099211
author Yoshie Muranaka <yoshiemuranaka@gmail.com> Tue Dec 01 16:38:47 2020 -0800
committer Yoshie Muranaka <yoshiemuranaka@gmail.com> Wed Dec 02 19:47:36 2020 +0000
tree cedac65385022d1c5fb9475995de67c1d1e63ad6
parent 6483544a7be8f86b37ce817b6cb7ac93db6e322a

Fix server LED switch value on error

Add error state handling in the ServerLed store to make sure the
UI accurately reflects the state if there is an error.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: I7f3647df9f5a32e241005eb7058a7cda1e0ba36a

src/store/modules/Control/ServerLedStore.js

diff --git a/src/store/modules/Control/ServerLedStore.js b/src/store/modules/Control/ServerLedStore.js
index d7c1234..a8903e2 100644
--- a/src/store/modules/Control/ServerLedStore.js
+++ b/src/store/modules/Control/ServerLedStore.js
@@ -27,12 +27,12 @@
         .catch((error) => console.log(error));
     },
     async saveIndicatorLedActiveState({ commit }, payload) {
+      commit('setIndicatorLedActiveState', payload);
       return await api
         .patch('/redfish/v1/Systems/system', {
           LocationIndicatorActive: payload,
         })
         .then(() => {
-          commit('setIndicatorLedActiveState', payload);
           if (payload) {
             return i18n.t('pageServerLed.toast.successServerLedOn');
           } else {
@@ -41,6 +41,7 @@
         })
         .catch((error) => {
           console.log(error);
+          commit('setIndicatorLedActiveState', !payload);
           if (payload) {
             throw new Error(i18n.t('pageServerLed.toast.errorServerLedOn'));
           } else {

src/views/Control/ServerLed/ServerLed.vue

diff --git a/src/views/Control/ServerLed/ServerLed.vue b/src/views/Control/ServerLed/ServerLed.vue
index e5c6dac..72726ba 100644
--- a/src/views/Control/ServerLed/ServerLed.vue
+++ b/src/views/Control/ServerLed/ServerLed.vue
@@ -64,9 +64,7 @@
           indicatorLedActiveState
         )
         .then((message) => this.successToast(message))
-        .catch(({ message }) => {
-          this.errorToast(message);
-        });
+        .catch(({ message }) => this.errorToast(message));
     },
   },
 };

src/views/Overview/OverviewQuickLinks.vue

diff --git a/src/views/Overview/OverviewQuickLinks.vue b/src/views/Overview/OverviewQuickLinks.vue
index 82975f5..1b84ce7 100644
--- a/src/views/Overview/OverviewQuickLinks.vue
+++ b/src/views/Overview/OverviewQuickLinks.vue
@@ -92,9 +92,7 @@
           indicatorLedActiveState
         )
         .then((message) => this.successToast(message))
-        .catch(({ message }) => {
-          this.errorToast(message);
-        });
+        .catch(({ message }) => this.errorToast(message));
     },
   },
 };