Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / webui-vue / 373d243c98f8b465e9315e95f88cdf26b887a626
commit373d243c98f8b465e9315e95f88cdf26b887a626[log] [tgz]
authorChandra Harkude <chandramohan.harkude@gmail.com>Thu Dec 15 20:51:02 2022 +0530
committerGunnar Mills <gmills@us.ibm.com>Mon Mar 13 16:11:53 2023 +0000
tree5c4d05aa461590841ea82545446d8f3635f4ca97
parentb63e9d9a70dabc4c9a7038f7727fca6bd17d940a [diff]
Fixed calling method "handleSubmit" two times

Problem : "handleSubmit" called on clicking Ok button implicitly as
well by the form
(<b-form id="generate-csr-form" novalidate @submit.prevent=
"handleSubmit"), due to this,
redfish API POST /redfish/v1/CertificateService/Actions/Certificate
Servi
ce.GenerateCSR
sent two times when "Generate CSR" button clicked,ideally redfish API
needs to be sent only once
This leads to failure of the second redfish API.

Steps to Reproduce Issue:

1. Go to 'Login->Security and access->Certificate->Generate CSR fill
the form
2. Click on 'Generate CSR.'
3. Scroll down to 'More Tools->Web Developer Tools->Network tab'
4. Two POST /redfish/v1/CertificateService/Actions/CertificateService.
    GenerateCSR are sent

Solution: The issue can be fixed either by deleting the Ok button click
event listener or deleting
the (@submit.prevent="handleSubmit"). I have used later one, which is
small change as well does not
alter the code much

Tested : I did manual testing and observed that two POST requests
    are no longer sent
Reference : https://softauthor.com/vuejs-prevent-form-submission/

Signed-off-by: Chandra Harkude <chandramohan.harkude@gmail.com>
Change-Id: I8736e597d2fe70aef438779667475426837d2c67
1 file changed
tree: 5c4d05aa461590841ea82545446d8f3635f4ca97
  1. .github/
  2. docs/
  3. public/
  4. src/
  5. tests/
  6. .browserslistrc
  7. .env.ibm
  8. .env.intel
  9. .eslintrc.js
  10. .gitattributes
  11. .gitignore
  12. .npmrc
  13. .shellcheck
  14. babel.config.js
  15. CONTRIBUTING.md
  16. format-code.sh
  17. jest.config.js
  18. LICENSE
  19. OWNERS
  20. package-lock.json
  21. package.json
  22. postcss.config.js
  23. README.md
  24. run-ci
  25. vue.config.js
README.md

webui-vue

webui-vue is a web-based user interface for the OpenBMC firmware stack built on Vue.js.

Hold on... What happened to phosphor-webui?

phosphor-webui was built on AngularJS and AngularJS goes End of Life June 30, 2021, this repository is its replacement.

When will this new Vue.js application reach feature parity with phosphor-webui?

Several, mostly minor, features remain for feature parity. See GitHub Issues label:phosphor-webui-feature-parity for the complete list.

Why will this application be better?

As mentioned, this application is built using Vue.js, a modern open-source Model-View-ViewModel JavaScript framework supported by an active community and strong documentation. It has been architected to allow organizations to easily update the theme to support their brand. This rewrite takes advantage of front-end development best practices and does not suffer from some of the anti-patterns that exist in phosphor-webui today.

Should I switch to webui-vue from phosphor-webui?

That is up to you. Several companies have switched.

webui-vue although still missing a few features that were in phosphor-webui, as mentioned above, has the following additional features:

  • Ability to easily theme to meet brand guidelines
  • Accessibility
  • Full Redfish
  • Improved user experience based on user feedback
  • Language translation-ready
  • Modern front-end framework with an active community and future development roadmap

How can I get involved?

Documentation

The documentation for coding standards and components is located in the docs directory. It is created using the VuePress static site generator. Information about how to write documentation can be found on the VuePress website.