Update linting packages to use latest
- 99% of changes were small syntax changes that were changed by the
lint command. There were a couple of small manual changes to meet the
property order patterns established as part of the vue:recommended
guidelines.
There are rules that were set from errors to warnings and new stories
are being opened to address those issues.
Testing:
- Successfully ran npm run serve
- Successfully ran npm run lint
- Verified functionality works as expected, e.g. success and failure use cases
- Resolved any JavaScript errors thrown to the console
Signed-off-by: Derick Montague <derick.montague@ibm.com>
Change-Id: Ie082f31c73ccbe8a60afa8f88a9ef6dbf33d9fd2
diff --git a/src/views/Health/EventLogs/EventLogs.vue b/src/views/Health/EventLogs/EventLogs.vue
index c345d8f..90f589a 100644
--- a/src/views/Health/EventLogs/EventLogs.vue
+++ b/src/views/Health/EventLogs/EventLogs.vue
@@ -33,7 +33,7 @@
@clearSelected="clearSelectedRows($refs.table)"
@batchAction="onBatchAction"
>
- <template v-slot:export>
+ <template #export>
<table-toolbar-export
:data="batchExportData"
:file-name="exportFileNameByDate()"
@@ -64,7 +64,7 @@
@row-selected="onRowSelected($event, filteredLogs.length)"
>
<!-- Checkbox column -->
- <template v-slot:head(checkbox)>
+ <template #head(checkbox)>
<b-form-checkbox
v-model="tableHeaderCheckboxModel"
data-test-id="eventLogs-checkbox-selectAll"
@@ -72,7 +72,7 @@
@change="onChangeHeaderCheckbox($refs.table)"
/>
</template>
- <template v-slot:cell(checkbox)="row">
+ <template #cell(checkbox)="row">
<b-form-checkbox
v-model="row.rowSelected"
:data-test-id="`eventLogs-checkbox-selectRow-${row.index}`"
@@ -81,19 +81,19 @@
</template>
<!-- Severity column -->
- <template v-slot:cell(severity)="{ value }">
+ <template #cell(severity)="{ value }">
<status-icon v-if="value" :status="statusIcon(value)" />
{{ value }}
</template>
<!-- Date column -->
- <template v-slot:cell(date)="{ value }">
+ <template #cell(date)="{ value }">
<p class="mb-0">{{ value | formatDate }}</p>
<p class="mb-0">{{ value | formatTime }}</p>
</template>
<!-- Actions column -->
- <template v-slot:cell(actions)="row">
+ <template #cell(actions)="row">
<table-row-action
v-for="(action, index) in row.item.actions"
:key="index"
@@ -104,7 +104,7 @@
:data-test-id="`eventLogs-button-deleteRow-${row.index}`"
@click:tableAction="onTableRowAction($event, row.item)"
>
- <template v-slot:icon>
+ <template #icon>
<icon-export v-if="action.value === 'export'" />
<icon-trashcan v-if="action.value === 'delete'" />
</template>
@@ -179,7 +179,7 @@
TableRowAction,
TableToolbar,
TableToolbarExport,
- TableDateFilter
+ TableDateFilter,
},
mixins: [
BVPaginationMixin,
@@ -189,64 +189,70 @@
TableFilterMixin,
TableDataFormatterMixin,
TableSortMixin,
- SearchFilterMixin
+ SearchFilterMixin,
],
+ beforeRouteLeave(to, from, next) {
+ // Hide loader if the user navigates to another page
+ // before request is fulfilled.
+ this.hideLoader();
+ next();
+ },
data() {
return {
fields: [
{
key: 'checkbox',
- sortable: false
+ sortable: false,
},
{
key: 'id',
label: this.$t('pageEventLogs.table.id'),
- sortable: true
+ sortable: true,
},
{
key: 'severity',
label: this.$t('pageEventLogs.table.severity'),
sortable: true,
- tdClass: 'text-nowrap'
+ tdClass: 'text-nowrap',
},
{
key: 'type',
label: this.$t('pageEventLogs.table.type'),
- sortable: true
+ sortable: true,
},
{
key: 'date',
label: this.$t('pageEventLogs.table.date'),
- sortable: true
+ sortable: true,
},
{
key: 'description',
- label: this.$t('pageEventLogs.table.description')
+ label: this.$t('pageEventLogs.table.description'),
},
{
key: 'actions',
sortable: false,
label: '',
- tdClass: 'text-right text-nowrap'
- }
+ tdClass: 'text-right text-nowrap',
+ },
],
tableFilters: [
{
key: 'severity',
label: this.$t('pageEventLogs.table.severity'),
- values: ['OK', 'Warning', 'Critical']
- }
+ values: ['OK', 'Warning', 'Critical'],
+ },
],
activeFilters: [],
batchActions: [
{
value: 'delete',
- label: this.$t('global.action.delete')
- }
+ label: this.$t('global.action.delete'),
+ },
],
filterStartDate: null,
filterEndDate: null,
- searchTotalFilteredRows: 0
+ searchTotalFilteredRows: 0,
};
},
computed: {
@@ -256,24 +262,24 @@
: this.filteredLogs.length;
},
allLogs() {
- return this.$store.getters['eventLog/allEvents'].map(event => {
+ return this.$store.getters['eventLog/allEvents'].map((event) => {
return {
...event,
actions: [
{
value: 'export',
- title: this.$t('global.action.export')
+ title: this.$t('global.action.export'),
},
{
value: 'delete',
- title: this.$t('global.action.delete')
- }
- ]
+ title: this.$t('global.action.delete'),
+ },
+ ],
};
});
},
batchExportData() {
- return this.selectedRows.map(row => omit(row, 'actions'));
+ return this.selectedRows.map((row) => omit(row, 'actions'));
},
filteredLogsByDate() {
return this.getFilteredTableDataByDate(
@@ -287,7 +293,7 @@
this.filteredLogsByDate,
this.activeFilters
);
- }
+ },
},
created() {
this.startLoader();
@@ -295,23 +301,19 @@
.dispatch('eventLog/getEventLogData')
.finally(() => this.endLoader());
},
- beforeRouteLeave(to, from, next) {
- // Hide loader if the user navigates to another page
- // before request is fulfilled.
- this.hideLoader();
- next();
- },
methods: {
deleteLogs(uris) {
- this.$store.dispatch('eventLog/deleteEventLogs', uris).then(messages => {
- messages.forEach(({ type, message }) => {
- if (type === 'success') {
- this.successToast(message);
- } else if (type === 'error') {
- this.errorToast(message);
- }
+ this.$store
+ .dispatch('eventLog/deleteEventLogs', uris)
+ .then((messages) => {
+ messages.forEach(({ type, message }) => {
+ if (type === 'success') {
+ this.successToast(message);
+ } else if (type === 'error') {
+ this.errorToast(message);
+ }
+ });
});
- });
},
onFilterChange({ activeFilters }) {
this.activeFilters = activeFilters;
@@ -326,16 +328,16 @@
this.$bvModal
.msgBoxConfirm(this.$tc('pageEventLogs.modal.deleteMessage'), {
title: this.$tc('pageEventLogs.modal.deleteTitle'),
- okTitle: this.$t('global.action.delete')
+ okTitle: this.$t('global.action.delete'),
})
- .then(deleteConfirmed => {
+ .then((deleteConfirmed) => {
if (deleteConfirmed) this.deleteLogs([uri]);
});
}
},
onBatchAction(action) {
if (action === 'delete') {
- const uris = this.selectedRows.map(row => row.uri);
+ const uris = this.selectedRows.map((row) => row.uri);
this.$bvModal
.msgBoxConfirm(
this.$tc(
@@ -347,10 +349,10 @@
'pageEventLogs.modal.deleteTitle',
this.selectedRows.length
),
- okTitle: this.$t('global.action.delete')
+ okTitle: this.$t('global.action.delete'),
}
)
- .then(deleteConfirmed => {
+ .then((deleteConfirmed) => {
if (deleteConfirmed) this.deleteLogs(uris);
});
}
@@ -368,13 +370,9 @@
date =
date.toISOString().slice(0, 10) +
'_' +
- date
- .toString()
- .split(':')
- .join('-')
- .split(' ')[4];
+ date.toString().split(':').join('-').split(' ')[4];
return this.$t('pageEventLogs.exportFilePrefix') + date;
- }
- }
+ },
+ },
};
</script>