commit 7cc1fd48e64ff01dc80eb6323c1175b2fa42a2d0
author Yoshie Muranaka <yoshiemuranaka@gmail.com> Thu Feb 11 09:23:14 2021 -0800
committer Derick Montague <derick.montague@ibm.com> Tue Feb 16 21:00:41 2021 +0000
tree f5378a6f69cc482abceca3463fdfdbca239cf135
parent fc387aa2963042f4cb75c000811c99aa66abb8ff

Update single file firmware TFTP upload option

Adds API check for the UpdateService allowable values to determine
whether or not a TFTP upload option is available in UI.
This is part of an effort to make the firmware page more dynamic.
These changes are only visisble with ibm dotenv variables.

Signed-off-by: Yoshie Muranaka <yoshiemuranaka@gmail.com>
Change-Id: Ied8ac5fa9f0441b1a0762c7a5267e298294eea32

src/env/components/FirmwareSingleImage/FirmwareSingleImage.vue

diff --git a/src/env/components/FirmwareSingleImage/FirmwareSingleImage.vue b/src/env/components/FirmwareSingleImage/FirmwareSingleImage.vue
index 54a2bb1..b7ad4c5 100644
--- a/src/env/components/FirmwareSingleImage/FirmwareSingleImage.vue
+++ b/src/env/components/FirmwareSingleImage/FirmwareSingleImage.vue
@@ -101,6 +101,7 @@
           <div class="form-background p-3">
             <b-form @submit.prevent="onSubmitUpload">
               <b-form-group
+                v-if="isTftpUploadAvailable"
                 :label="$t('pageFirmware.singleFileUpload.fileSource')"
                 :disabled="isPageDisabled"
               >
@@ -258,6 +259,7 @@
       'backupFirmwareVersion',
       'isRebootFromBackupAvailable',
       'systemFirmwareVersion',
+      'isTftpUploadAvailable',
     ]),
     isPageDisabled() {
       if (this.isServerPowerOffRequired) {
@@ -281,7 +283,7 @@
   },
   created() {
     this.startLoader();
-    this.$store.dispatch('firmwareSingleImage/getUpdateServiceApplyTime');
+    this.$store.dispatch('firmwareSingleImage/getUpdateServiceSettings');
     Promise.all([
       this.$store.dispatch('global/getHostStatus'),
       this.$store.dispatch('firmwareSingleImage/getFirmwareInformation'),

src/env/store/FirmwareSingleImage/FirmwareSingleImageStore.js

diff --git a/src/env/store/FirmwareSingleImage/FirmwareSingleImageStore.js b/src/env/store/FirmwareSingleImage/FirmwareSingleImageStore.js
index 91bcb9f..b16cac8 100644
--- a/src/env/store/FirmwareSingleImage/FirmwareSingleImageStore.js
+++ b/src/env/store/FirmwareSingleImage/FirmwareSingleImageStore.js
@@ -16,6 +16,7 @@
       status: null,
     },
     applyTime: null,
+    tftpAvailable: false,
   },
   getters: {
     systemFirmwareVersion: (state) => state.activeFirmware.version,
@@ -23,7 +24,8 @@
     backupFirmwareStatus: (state) => state.backupFirmware.status,
     isRebootFromBackupAvailable: (state) =>
       state.backupFirmware.id ? true : false,
-    bmcFirmwareCurrentVersion: (state) => state.activeFirmware.version, //this getter is needed for the Overview page
+    bmcFirmwareCurrentVersion: (state) => state.activeFirmware.version, //this getter is needed for the Overview page,
+    isTftpUploadAvailable: (state) => state.tftpAvailable,
   },
   mutations: {
     setActiveFirmware: (state, { version, id, location }) => {
@@ -38,6 +40,8 @@
       state.backupFirmware.status = status;
     },
     setApplyTime: (state, applyTime) => (state.applyTime = applyTime),
+    setTftpUploadAvailable: (state, tftpAvailable) =>
+      (state.tftpAvailable = tftpAvailable),
   },
   actions: {
     async getFirmwareInformation({ commit }) {
@@ -77,13 +81,21 @@
         })
         .catch((error) => console.log(error));
     },
-    getUpdateServiceApplyTime({ commit }) {
+    getUpdateServiceSettings({ commit }) {
       api
         .get('/redfish/v1/UpdateService')
         .then(({ data }) => {
           const applyTime =
             data.HttpPushUriOptions.HttpPushUriApplyTime.ApplyTime;
+          const allowableActions =
+            data?.Actions?.['#UpdateService.SimpleUpdate']?.[
+              'TransferProtocol@Redfish.AllowableValues'
+            ];
+
           commit('setApplyTime', applyTime);
+          if (allowableActions.includes('TFTP')) {
+            commit('setTftpUploadAvailable', true);
+          }
         })
         .catch((error) => console.log(error));
     },