Migrate to Bootstrap 5 and remove Vue compat plugin
Complete migration from Bootstrap 4 (bootstrap-vue) to Bootstrap 5
(bootstrap-vue-next) and remove the @vue/compat plugin to finalize
the Vue 3 migration.
Bundle size impact:
- Before (Bootstrap 4 + bootstrap-vue): 535 KiB gzipped
- After (Bootstrap 5 + bootstrap-vue-next): 511 KiB gzipped
- Reduction: 24 KiB (4.5% smaller)
Package updates:
- Update bootstrap 4.6.2 -> 5.3.8
- Update bootstrap-vue 2.23.1 -> bootstrap-vue-next 0.40.8
- Remove @vue/compat plugin
- Update vue 3.4.29 -> 3.5.24 and related packages
- Add mitt 3.0.1 for global event bus
- Add vue-demi 0.14.10 for library compatibility
Bootstrap 5 CSS updates:
- Replace directional classes: ml/mr/pl/pr -> ms/me/ps/pe
- Replace text-left/right -> text-start/end
- Replace sr-only -> visually-hidden / visually-hidden-focusable
- Update media breakpoint xs -> sm (Bootstrap 5 removed xs)
- Update color functions: gray("700") -> $gray-700
- Add form-switch border-radius for curved toggles
- Update alert, table, toast, form, and button styles
Bootstrap-Vue-Next API changes:
- Use createBootstrap() for plugin registration
- Update modal footer slots: #modal-footer -> #footer
- Fix form select events: @change -> @update:model-value
- Add v-model bindings to modals instead of manual show()/hide()
- Update toast system with custom plugin wrapping useToast()
- Register components and directives explicitly
Vue 3 specific updates:
- Replace $root.$emit with mitt event bus (eventBus.js)
- Update render function from h(App) to createApp(App)
- Add emits option to components
- Use h() instead of $createElement in mixins
- Add Vue 3 compile-time feature flags with documentation
- Update event listeners: $on/$off to eventBus methods
- Add beforeUnmount cleanup for event listeners
New components and significant additions:
- src/plugins/toast.js - Custom toast plugin wrapping useToast() for
Options API compatibility
- src/components/Global/ConfirmModal.vue - Global confirmation dialog
shim to replace Bootstrap 4's removed bvModal.msgBoxConfirm
- src/eventBus.js - mitt-based event bus with Vue 2-compatible API
- Navigation state preservation on page refresh implemented
Critical fixes:
- Add global API interceptor to strip Vue reactivity from payloads
- Preserve binary data (File, Blob, FormData) in API requests
- Fix Generate CSR modal v-model binding for proper open/close
- Remove debug logging and fix jest configuration
- Fix responsive text visibility in AppHeader
- Update BVTableSelectableMixin for proper row selection
- Fix BVToastMixin VNode rendering for Vue 3
Vue 3 modal fixes (lazy-loaded components):
- Add v-model support to network modals (ModalIpv4, ModalIpv6, ModalDns,
ModalHostname, ModalMacAddress, ModalDefaultGateway) by adding
modelValue prop, watcher on modelValue that triggers show(), and
update:modelValue emit in resetForm
- Remove lazy loading from TableIpv4, TableIpv6, TableDns to ensure
modal component refs are available when v-model triggers
- Fix modal title accessibility by adding title prop to modals
(ModalAddDestination, ModalUser, ModalAddRoleGroup, etc.)
i18n fixes (computed properties):
- Fix computed properties using i18n translations in ModalAddRoleGroup,
ModalUser, and ModalUploadCertificate
- Move useI18n() call from data() to setup() and return i18n object
- Use i18n.t() instead of $t in computed properties and templates
- Prevents "this.$t is not a function" and "_ctx.$t is not a function"
errors in Vue 3
Toast notification fixes:
- Fix toast progress bar visibility by setting progressProps to
undefined (documented way to opt-out) instead of false
- Change modelValue prop to interval for auto-dismiss timing
- Remove temporary CSS display:none hack from _toasts.scss
Network settings fixes:
- Fix checkbox @change event sending Vue reactive proxy object instead
of boolean by casting with !! operator in changeDomainNameState and
related methods in NetworkGlobalSettings.vue
- Ensures API receives plain boolean values in PATCH requests
Navigation fixes:
- Fix nav-link styling for navigation items without children by
replacing b-nav-item with router-link in AppNavigation.vue
- Prevents blue font color from .nav-link CSS class
Configuration updates:
- Remove vue-compat webpack configuration
- Add Vue 3 feature flags (__VUE_OPTIONS_API__, etc.)
- Add .cursor to .gitignore
Accessibility improvements:
- Add autocomplete attributes to password and credential inputs
- Add modal title props for screen reader support
Build completes successfully and UI behavior matches pre-migration.
Extracted features (to be submitted in follow-up PRs):
The following features were removed from this migration PR to keep it
focused on the Bootstrap 5 upgrade. They will be submitted separately:
1. UnresponsiveModal - Server connectivity watchdog with auto-retry
2. Auth token persistence - sessionStorage support for X-Auth-Token
3. Hardware store error handling - try/catch, dynamic discovery
4. Login page connecting indicator - Backend polling with spinner
5. Test updates - Jest setup and snapshot updates for
Bootstrap-Vue-Next
6. Documentation updates - Vue 3 and Vue I18n v9+ API documentation
7. Enhanced ConfirmModal - Feature-rich confirmation dialog with
custom actions
Change-Id: Ib76a58f324b3c926cf536e6e4626e4271639de38
Signed-off-by: Jason Westover <jwestover@nvidia.com>
diff --git a/src/assets/styles/bmc/custom/_tables.scss b/src/assets/styles/bmc/custom/_tables.scss
index e8b5a83..d6d5a74 100644
--- a/src/assets/styles/bmc/custom/_tables.scss
+++ b/src/assets/styles/bmc/custom/_tables.scss
@@ -1,39 +1,43 @@
+
.table {
position: relative;
z-index: $zindex-dropdown;
td {
- border-top: 1px solid gray("300");
- border-bottom: 1px solid gray("300");
+ border-top: 1px solid $gray-300;
+ border-bottom: 1px solid $gray-300;
&:first-of-type {
- border-left: 1px solid gray("300");
+ border-inline-start: 1px solid $gray-300;
}
&:last-of-type {
- border-right: 1px solid gray("300");
+ border-inline-end: 1px solid $gray-300;
}
vertical-align: middle;
// Table action buttons
.btn-link {
- width: 40px;
- height: 40px;
- padding: 5px !important;
+ padding: 0.25rem 0.5rem !important;
display: inline-flex;
justify-content: center;
align-items: center;
+ line-height: 1;
+ .visually-hidden {
+ margin-inline-start: 0.25rem;
+ }
}
}
- // thead-light added for specificity
- .thead-light th {
+ // Bootstrap 4 thead-light and Bootstrap 5 table-light classes for specificity
+ .thead-light th,
+ .table-light th {
vertical-align: middle;
- border-top: 1px solid gray("300");
- border-bottom: 1px solid gray("300");
+ border-top: 1px solid $gray-300;
+ border-bottom: 1px solid $gray-300;
&:first-of-type {
- border-left: 1px solid gray("300");
+ border-inline-start: 1px solid $gray-300;
}
&:last-of-type {
- border-right: 1px solid gray("300");
+ border-inline-end: 1px solid $gray-300;
}
color: theme-color("dark");
&:focus {
@@ -50,24 +54,26 @@
td {
border-bottom: none;
}
- .table-row-expand svg {
- transform: rotate(180deg);
- }
+ }
+
+ // Show right-pointing chevron when collapsed
+ .table-row-expand .btn.collapsed svg {
+ transform: rotate(-90deg);
}
.b-table-details {
background-color: theme-color("light");
td {
- padding-left: calc(50px + (#{$table-cell-padding} * 2));
- padding-right: calc(50px + (#{$table-cell-padding} * 2));
+ padding-inline-start: calc(50px + (#{$table-cell-padding-x} * 2));
+ padding-inline-end: calc(50px + (#{$table-cell-padding-x} * 2));
}
dl {
margin: 0;
}
dt {
- float: left;
- clear: left;
- margin-right: $spacer / 2;
+ float: inline-start;
+ clear: inline-start;
+ margin-inline-end: calc($spacer / 2);
}
dd {
line-height: 1.2
@@ -78,7 +84,6 @@
width: 50px;
.btn {
padding: 0;
- width: 50px;
}
svg {
fill: theme-color("dark");
@@ -86,7 +91,7 @@
}
.b-table-sort-icon-left {
background-position: left calc(1.5rem / 2) center !important;
- padding-left: calc(1.2rem + 0.65em) !important;
+ padding-inline-start: calc(1.2rem + 0.65em) !important;
&:focus {
outline: none;
box-shadow: inset 0 0 0 2px theme-color('primary') !important;
@@ -101,15 +106,15 @@
border-top: none;
}
-// Table stacked style for small screen only
-@include media-breakpoint-down(xs) {
+// Table stacked style for small screens (< 576px)
+@include media-breakpoint-down(sm) {
.b-table-stacked-sm {
- border: 1px solid gray("300");
+ border: 1px solid $gray-300;
tr {
&:not(:first-child) > td[aria-colindex='1'] {
- border-top: 1px solid gray("300");
+ border-top: 1px solid $gray-300;
padding-top: 0.625rem;
}
@@ -126,29 +131,29 @@
&:before {
content: '';
- background-color: gray("200");
+ background-color: $gray-200;
width: 40%;
- border-right: 1px solid gray("300");
+ border-inline-end: 1px solid $gray-300;
}
&:after {
content: '';
- right: 0;
+ inset-inline-end: 0;
width: 60%;
}
&:nth-child(even)::after {
- background-color: gray("100"); // Zebra striping for the row
+ background-color: $gray-100; // Zebra striping for the row
}
}
td {
border: 0;
padding: 0.75rem;
- text-align: left !important;
+ text-align: start !important;
&:last-of-type {
- border-right: 0;
+ border-inline-end: 0;
}
}
}
@@ -156,12 +161,12 @@
.table.b-table.b-table-stacked-sm > tbody > tr > [data-label] {
&::before {
- text-align: left;
- padding-left: $spacer /2;
+ text-align: start;
+ padding-inline-start: calc($spacer / 2);
}
> div {
- padding-left: 1rem;
+ padding-inline-start: 1rem;
}
}