Migrate to Bootstrap 5 and remove Vue compat plugin
Complete migration from Bootstrap 4 (bootstrap-vue) to Bootstrap 5
(bootstrap-vue-next) and remove the @vue/compat plugin to finalize
the Vue 3 migration.
Bundle size impact:
- Before (Bootstrap 4 + bootstrap-vue): 535 KiB gzipped
- After (Bootstrap 5 + bootstrap-vue-next): 511 KiB gzipped
- Reduction: 24 KiB (4.5% smaller)
Package updates:
- Update bootstrap 4.6.2 -> 5.3.8
- Update bootstrap-vue 2.23.1 -> bootstrap-vue-next 0.40.8
- Remove @vue/compat plugin
- Update vue 3.4.29 -> 3.5.24 and related packages
- Add mitt 3.0.1 for global event bus
- Add vue-demi 0.14.10 for library compatibility
Bootstrap 5 CSS updates:
- Replace directional classes: ml/mr/pl/pr -> ms/me/ps/pe
- Replace text-left/right -> text-start/end
- Replace sr-only -> visually-hidden / visually-hidden-focusable
- Update media breakpoint xs -> sm (Bootstrap 5 removed xs)
- Update color functions: gray("700") -> $gray-700
- Add form-switch border-radius for curved toggles
- Update alert, table, toast, form, and button styles
Bootstrap-Vue-Next API changes:
- Use createBootstrap() for plugin registration
- Update modal footer slots: #modal-footer -> #footer
- Fix form select events: @change -> @update:model-value
- Add v-model bindings to modals instead of manual show()/hide()
- Update toast system with custom plugin wrapping useToast()
- Register components and directives explicitly
Vue 3 specific updates:
- Replace $root.$emit with mitt event bus (eventBus.js)
- Update render function from h(App) to createApp(App)
- Add emits option to components
- Use h() instead of $createElement in mixins
- Add Vue 3 compile-time feature flags with documentation
- Update event listeners: $on/$off to eventBus methods
- Add beforeUnmount cleanup for event listeners
New components and significant additions:
- src/plugins/toast.js - Custom toast plugin wrapping useToast() for
Options API compatibility
- src/components/Global/ConfirmModal.vue - Global confirmation dialog
shim to replace Bootstrap 4's removed bvModal.msgBoxConfirm
- src/eventBus.js - mitt-based event bus with Vue 2-compatible API
- Navigation state preservation on page refresh implemented
Critical fixes:
- Add global API interceptor to strip Vue reactivity from payloads
- Preserve binary data (File, Blob, FormData) in API requests
- Fix Generate CSR modal v-model binding for proper open/close
- Remove debug logging and fix jest configuration
- Fix responsive text visibility in AppHeader
- Update BVTableSelectableMixin for proper row selection
- Fix BVToastMixin VNode rendering for Vue 3
Vue 3 modal fixes (lazy-loaded components):
- Add v-model support to network modals (ModalIpv4, ModalIpv6, ModalDns,
ModalHostname, ModalMacAddress, ModalDefaultGateway) by adding
modelValue prop, watcher on modelValue that triggers show(), and
update:modelValue emit in resetForm
- Remove lazy loading from TableIpv4, TableIpv6, TableDns to ensure
modal component refs are available when v-model triggers
- Fix modal title accessibility by adding title prop to modals
(ModalAddDestination, ModalUser, ModalAddRoleGroup, etc.)
i18n fixes (computed properties):
- Fix computed properties using i18n translations in ModalAddRoleGroup,
ModalUser, and ModalUploadCertificate
- Move useI18n() call from data() to setup() and return i18n object
- Use i18n.t() instead of $t in computed properties and templates
- Prevents "this.$t is not a function" and "_ctx.$t is not a function"
errors in Vue 3
Toast notification fixes:
- Fix toast progress bar visibility by setting progressProps to
undefined (documented way to opt-out) instead of false
- Change modelValue prop to interval for auto-dismiss timing
- Remove temporary CSS display:none hack from _toasts.scss
Network settings fixes:
- Fix checkbox @change event sending Vue reactive proxy object instead
of boolean by casting with !! operator in changeDomainNameState and
related methods in NetworkGlobalSettings.vue
- Ensures API receives plain boolean values in PATCH requests
Navigation fixes:
- Fix nav-link styling for navigation items without children by
replacing b-nav-item with router-link in AppNavigation.vue
- Prevents blue font color from .nav-link CSS class
Configuration updates:
- Remove vue-compat webpack configuration
- Add Vue 3 feature flags (__VUE_OPTIONS_API__, etc.)
- Add .cursor to .gitignore
Accessibility improvements:
- Add autocomplete attributes to password and credential inputs
- Add modal title props for screen reader support
Build completes successfully and UI behavior matches pre-migration.
Extracted features (to be submitted in follow-up PRs):
The following features were removed from this migration PR to keep it
focused on the Bootstrap 5 upgrade. They will be submitted separately:
1. UnresponsiveModal - Server connectivity watchdog with auto-retry
2. Auth token persistence - sessionStorage support for X-Auth-Token
3. Hardware store error handling - try/catch, dynamic discovery
4. Login page connecting indicator - Backend polling with spinner
5. Test updates - Jest setup and snapshot updates for
Bootstrap-Vue-Next
6. Documentation updates - Vue 3 and Vue I18n v9+ API documentation
7. Enhanced ConfirmModal - Feature-rich confirmation dialog with
custom actions
Change-Id: Ib76a58f324b3c926cf536e6e4626e4271639de38
Signed-off-by: Jason Westover <jwestover@nvidia.com>
diff --git a/src/assets/styles/bmc/custom/_toasts.scss b/src/assets/styles/bmc/custom/_toasts.scss
index 4e2ad7f..900794f 100644
--- a/src/assets/styles/bmc/custom/_toasts.scss
+++ b/src/assets/styles/bmc/custom/_toasts.scss
@@ -1,16 +1,23 @@
-.b-toaster {
- top: 75px!important; // make sure toasts do not hide top header
+// Toast container positioning - below AppHeader
+.b-toaster,
+.toast-container {
+ top: calc(#{$header-height} + #{$spacer})!important; // position below AppHeader (48px + spacing)
}
// Toast component and status icon style
.toast {
- padding: $spacer/2 $spacer/2 $spacer/2 $spacer+2;
- border-width: 0 0 0 3px;
+ padding: calc(#{$spacer} / 2) calc(#{$spacer} / 2) calc(#{$spacer} / 2) $spacer+2;
+ border-width: 0 0 0 3px; // physical width retained; color via logical property
box-shadow: $box-shadow;
+ margin-bottom: $spacer; // vertical spacing between stacked toasts
.close {
font-weight: 300;
opacity: 1;
}
+ // Hide progress bar in all toasts (CSS workaround since JS props don't work as documented in Bootstrap Vue Next 0.40.8)
+ .progress {
+ display: none !important;
+ }
}
.toast-header {
@@ -19,15 +26,15 @@
background-color: inherit!important; //override specificity
border: none;
color: theme-color("dark")!important; //override specificity
- padding-bottom: 0;
+ padding-bottom: calc(#{$spacer} / 4); // spacing between header and body
}
.toast-icon {
display: flex;
- margin-right: 1rem;
+ margin-inline-end: 1rem;
svg {
- margin-left: -2.5rem;
+ margin-inline-start: -2.5rem;
}
+ .close {
@@ -37,25 +44,77 @@
.toast-body {
color: theme-color("dark");
- padding-top: 0;
+ padding-top: calc(#{$spacer} / 4); // spacing below header
+ white-space: pre-line; // Preserve newlines from \n characters
+ line-height: 1.6; // Better line spacing for multi-line content and timestamps
}
+// Bootstrap Vue 2 class names (backward compatibility)
.b-toast-success .toast {
- border-left-color: theme-color("success")!important;
+ border-inline-start-color: theme-color("success")!important;
background-color: theme-color-light("success")!important;
}
.b-toast-info .toast {
- border-left-color: theme-color("info")!important;
+ border-inline-start-color: theme-color("info")!important;
background-color: theme-color-light("info")!important;
}
.b-toast-danger .toast {
- border-left-color: theme-color("danger")!important;
+ border-inline-start-color: theme-color("danger")!important;
background-color: theme-color-light("danger")!important;
}
.b-toast-warning .toast {
- border-left-color: theme-color("warning")!important;
+ border-inline-start-color: theme-color("warning")!important;
+ background-color: theme-color-light("warning")!important;
+}
+
+// Bootstrap Vue Next class names
+.toast.bg-success {
+ border-inline-start-color: theme-color("success")!important;
+ background-color: theme-color-light("success")!important;
+}
+
+.toast.bg-info {
+ border-inline-start-color: theme-color("info")!important;
+ background-color: theme-color-light("info")!important;
+}
+
+.toast.bg-danger {
+ border-inline-start-color: theme-color("danger")!important;
+ background-color: theme-color-light("danger")!important;
+}
+
+.toast.bg-warning {
+ border-inline-start-color: theme-color("warning")!important;
+ background-color: theme-color-light("warning")!important;
+}
+
+// Override Bootstrap's solid variant backgrounds
+.toast.text-bg-success,
+.toast.text-bg-info,
+.toast.text-bg-danger,
+.toast.text-bg-warning {
+ color: theme-color("dark")!important;
+}
+
+.toast.text-bg-success {
+ border-inline-start-color: theme-color("success")!important;
+ background-color: theme-color-light("success")!important;
+}
+
+.toast.text-bg-info {
+ border-inline-start-color: theme-color("info")!important;
+ background-color: theme-color-light("info")!important;
+}
+
+.toast.text-bg-danger {
+ border-inline-start-color: theme-color("danger")!important;
+ background-color: theme-color-light("danger")!important;
+}
+
+.toast.text-bg-warning {
+ border-inline-start-color: theme-color("warning")!important;
background-color: theme-color-light("warning")!important;
}
\ No newline at end of file