Migrate to Bootstrap 5 and remove Vue compat plugin
Complete migration from Bootstrap 4 (bootstrap-vue) to Bootstrap 5
(bootstrap-vue-next) and remove the @vue/compat plugin to finalize
the Vue 3 migration.
Bundle size impact:
- Before (Bootstrap 4 + bootstrap-vue): 535 KiB gzipped
- After (Bootstrap 5 + bootstrap-vue-next): 511 KiB gzipped
- Reduction: 24 KiB (4.5% smaller)
Package updates:
- Update bootstrap 4.6.2 -> 5.3.8
- Update bootstrap-vue 2.23.1 -> bootstrap-vue-next 0.40.8
- Remove @vue/compat plugin
- Update vue 3.4.29 -> 3.5.24 and related packages
- Add mitt 3.0.1 for global event bus
- Add vue-demi 0.14.10 for library compatibility
Bootstrap 5 CSS updates:
- Replace directional classes: ml/mr/pl/pr -> ms/me/ps/pe
- Replace text-left/right -> text-start/end
- Replace sr-only -> visually-hidden / visually-hidden-focusable
- Update media breakpoint xs -> sm (Bootstrap 5 removed xs)
- Update color functions: gray("700") -> $gray-700
- Add form-switch border-radius for curved toggles
- Update alert, table, toast, form, and button styles
Bootstrap-Vue-Next API changes:
- Use createBootstrap() for plugin registration
- Update modal footer slots: #modal-footer -> #footer
- Fix form select events: @change -> @update:model-value
- Add v-model bindings to modals instead of manual show()/hide()
- Update toast system with custom plugin wrapping useToast()
- Register components and directives explicitly
Vue 3 specific updates:
- Replace $root.$emit with mitt event bus (eventBus.js)
- Update render function from h(App) to createApp(App)
- Add emits option to components
- Use h() instead of $createElement in mixins
- Add Vue 3 compile-time feature flags with documentation
- Update event listeners: $on/$off to eventBus methods
- Add beforeUnmount cleanup for event listeners
New components and significant additions:
- src/plugins/toast.js - Custom toast plugin wrapping useToast() for
Options API compatibility
- src/components/Global/ConfirmModal.vue - Global confirmation dialog
shim to replace Bootstrap 4's removed bvModal.msgBoxConfirm
- src/eventBus.js - mitt-based event bus with Vue 2-compatible API
- Navigation state preservation on page refresh implemented
Critical fixes:
- Add global API interceptor to strip Vue reactivity from payloads
- Preserve binary data (File, Blob, FormData) in API requests
- Fix Generate CSR modal v-model binding for proper open/close
- Remove debug logging and fix jest configuration
- Fix responsive text visibility in AppHeader
- Update BVTableSelectableMixin for proper row selection
- Fix BVToastMixin VNode rendering for Vue 3
Vue 3 modal fixes (lazy-loaded components):
- Add v-model support to network modals (ModalIpv4, ModalIpv6, ModalDns,
ModalHostname, ModalMacAddress, ModalDefaultGateway) by adding
modelValue prop, watcher on modelValue that triggers show(), and
update:modelValue emit in resetForm
- Remove lazy loading from TableIpv4, TableIpv6, TableDns to ensure
modal component refs are available when v-model triggers
- Fix modal title accessibility by adding title prop to modals
(ModalAddDestination, ModalUser, ModalAddRoleGroup, etc.)
i18n fixes (computed properties):
- Fix computed properties using i18n translations in ModalAddRoleGroup,
ModalUser, and ModalUploadCertificate
- Move useI18n() call from data() to setup() and return i18n object
- Use i18n.t() instead of $t in computed properties and templates
- Prevents "this.$t is not a function" and "_ctx.$t is not a function"
errors in Vue 3
Toast notification fixes:
- Fix toast progress bar visibility by setting progressProps to
undefined (documented way to opt-out) instead of false
- Change modelValue prop to interval for auto-dismiss timing
- Remove temporary CSS display:none hack from _toasts.scss
Network settings fixes:
- Fix checkbox @change event sending Vue reactive proxy object instead
of boolean by casting with !! operator in changeDomainNameState and
related methods in NetworkGlobalSettings.vue
- Ensures API receives plain boolean values in PATCH requests
Navigation fixes:
- Fix nav-link styling for navigation items without children by
replacing b-nav-item with router-link in AppNavigation.vue
- Prevents blue font color from .nav-link CSS class
Configuration updates:
- Remove vue-compat webpack configuration
- Add Vue 3 feature flags (__VUE_OPTIONS_API__, etc.)
- Add .cursor to .gitignore
Accessibility improvements:
- Add autocomplete attributes to password and credential inputs
- Add modal title props for screen reader support
Build completes successfully and UI behavior matches pre-migration.
Extracted features (to be submitted in follow-up PRs):
The following features were removed from this migration PR to keep it
focused on the Bootstrap 5 upgrade. They will be submitted separately:
1. UnresponsiveModal - Server connectivity watchdog with auto-retry
2. Auth token persistence - sessionStorage support for X-Auth-Token
3. Hardware store error handling - try/catch, dynamic discovery
4. Login page connecting indicator - Backend polling with spinner
5. Test updates - Jest setup and snapshot updates for
Bootstrap-Vue-Next
6. Documentation updates - Vue 3 and Vue I18n v9+ API documentation
7. Enhanced ConfirmModal - Feature-rich confirmation dialog with
custom actions
Change-Id: Ib76a58f324b3c926cf536e6e4626e4271639de38
Signed-off-by: Jason Westover <jwestover@nvidia.com>
diff --git a/src/views/Operations/FactoryReset/FactoryResetModal.vue b/src/views/Operations/FactoryReset/FactoryResetModal.vue
index 5865bb3..97c74c4 100644
--- a/src/views/Operations/FactoryReset/FactoryResetModal.vue
+++ b/src/views/Operations/FactoryReset/FactoryResetModal.vue
@@ -2,33 +2,33 @@
<b-modal
id="modal-reset"
ref="modal"
- :title="$t(`pageFactoryReset.modal.${resetType}Title`)"
+ :title="modalTitle"
title-tag="h2"
@hidden="resetConfirm"
>
<p class="mb-2">
- <strong>{{ $t(`pageFactoryReset.modal.${resetType}Header`) }}</strong>
+ <strong>{{ modalHeader }}</strong>
</p>
- <ul v-if="resetType == 'resetBios'" class="pl-3 mb-4">
+ <ul v-if="resetType == 'resetBios'" class="ps-3 mb-4">
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetBiosSettingsList.item1') }}
+ {{ t('pageFactoryReset.modal.resetBiosSettingsList.item1') }}
</li>
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetBiosSettingsList.item2') }}
+ {{ t('pageFactoryReset.modal.resetBiosSettingsList.item2') }}
</li>
</ul>
- <ul v-else-if="resetType == 'resetToDefaults'" class="pl-3 mb-4">
+ <ul v-else-if="resetType == 'resetToDefaults'" class="ps-3 mb-4">
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetToDefaultsSettingsList.item1') }}
+ {{ t('pageFactoryReset.modal.resetToDefaultsSettingsList.item1') }}
</li>
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetToDefaultsSettingsList.item2') }}
+ {{ t('pageFactoryReset.modal.resetToDefaultsSettingsList.item2') }}
</li>
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetToDefaultsSettingsList.item3') }}
+ {{ t('pageFactoryReset.modal.resetToDefaultsSettingsList.item3') }}
</li>
<li class="mt-1 mb-1">
- {{ $t('pageFactoryReset.modal.resetToDefaultsSettingsList.item4') }}
+ {{ t('pageFactoryReset.modal.resetToDefaultsSettingsList.item4') }}
</li>
</ul>
@@ -36,8 +36,8 @@
<template v-if="!isServerOff">
<p class="d-flex mb-2">
<status-icon status="danger" />
- <span id="reset-to-default-warning" class="ml-1">
- {{ $t(`pageFactoryReset.modal.resetWarningMessage`) }}
+ <span id="reset-to-default-warning" class="ms-1">
+ {{ t(`pageFactoryReset.modal.resetWarningMessage`) }}
</span>
</p>
<b-form-checkbox
@@ -45,23 +45,23 @@
aria-describedby="reset-to-default-warning"
@input="v$.confirm.$touch()"
>
- {{ $t(`pageFactoryReset.modal.resetWarningCheckLabel`) }}
+ {{ t(`pageFactoryReset.modal.resetWarningCheckLabel`) }}
</b-form-checkbox>
<b-form-invalid-feedback
role="alert"
:state="getValidationState(v$.confirm)"
>
- {{ $t('global.form.fieldRequired') }}
+ {{ t('global.form.fieldRequired') }}
</b-form-invalid-feedback>
</template>
- <template #modal-footer="{ cancel }">
+ <template #footer="{ cancel }">
<b-button
variant="secondary"
data-test-id="factoryReset-button-cancel"
@click="cancel()"
>
- {{ $t('global.action.cancel') }}
+ {{ t('global.action.cancel') }}
</b-button>
<b-button
type="sumbit"
@@ -69,7 +69,7 @@
data-test-id="factoryReset-button-confirm"
@click="handleConfirm"
>
- {{ $t(`pageFactoryReset.modal.${resetType}SubmitText`) }}
+ {{ modalSubmitText }}
</b-button>
</template>
</b-modal>
@@ -97,7 +97,7 @@
},
data() {
return {
- $t: useI18n().t,
+ t: useI18n().t,
confirm: false,
};
},
@@ -108,6 +108,15 @@
isServerOff() {
return this.serverStatus === 'off' ? true : false;
},
+ modalTitle() {
+ return this.t(`pageFactoryReset.modal.${this.resetType}Title`);
+ },
+ modalHeader() {
+ return this.t(`pageFactoryReset.modal.${this.resetType}Header`);
+ },
+ modalSubmitText() {
+ return this.t(`pageFactoryReset.modal.${this.resetType}SubmitText`);
+ },
},
validations: {
confirm: {
@@ -116,6 +125,19 @@
},
},
},
+ watch: {
+ isServerOff: {
+ handler(newValue) {
+ // Touch validation when server is on to show required message immediately
+ if (!newValue) {
+ this.$nextTick(() => {
+ this.v$.confirm.$touch();
+ });
+ }
+ },
+ immediate: true,
+ },
+ },
methods: {
handleConfirm() {
this.v$.$touch();