Migrate to Bootstrap 5 and remove Vue compat plugin
Complete migration from Bootstrap 4 (bootstrap-vue) to Bootstrap 5
(bootstrap-vue-next) and remove the @vue/compat plugin to finalize
the Vue 3 migration.
Bundle size impact:
- Before (Bootstrap 4 + bootstrap-vue): 535 KiB gzipped
- After (Bootstrap 5 + bootstrap-vue-next): 511 KiB gzipped
- Reduction: 24 KiB (4.5% smaller)
Package updates:
- Update bootstrap 4.6.2 -> 5.3.8
- Update bootstrap-vue 2.23.1 -> bootstrap-vue-next 0.40.8
- Remove @vue/compat plugin
- Update vue 3.4.29 -> 3.5.24 and related packages
- Add mitt 3.0.1 for global event bus
- Add vue-demi 0.14.10 for library compatibility
Bootstrap 5 CSS updates:
- Replace directional classes: ml/mr/pl/pr -> ms/me/ps/pe
- Replace text-left/right -> text-start/end
- Replace sr-only -> visually-hidden / visually-hidden-focusable
- Update media breakpoint xs -> sm (Bootstrap 5 removed xs)
- Update color functions: gray("700") -> $gray-700
- Add form-switch border-radius for curved toggles
- Update alert, table, toast, form, and button styles
Bootstrap-Vue-Next API changes:
- Use createBootstrap() for plugin registration
- Update modal footer slots: #modal-footer -> #footer
- Fix form select events: @change -> @update:model-value
- Add v-model bindings to modals instead of manual show()/hide()
- Update toast system with custom plugin wrapping useToast()
- Register components and directives explicitly
Vue 3 specific updates:
- Replace $root.$emit with mitt event bus (eventBus.js)
- Update render function from h(App) to createApp(App)
- Add emits option to components
- Use h() instead of $createElement in mixins
- Add Vue 3 compile-time feature flags with documentation
- Update event listeners: $on/$off to eventBus methods
- Add beforeUnmount cleanup for event listeners
New components and significant additions:
- src/plugins/toast.js - Custom toast plugin wrapping useToast() for
Options API compatibility
- src/components/Global/ConfirmModal.vue - Global confirmation dialog
shim to replace Bootstrap 4's removed bvModal.msgBoxConfirm
- src/eventBus.js - mitt-based event bus with Vue 2-compatible API
- Navigation state preservation on page refresh implemented
Critical fixes:
- Add global API interceptor to strip Vue reactivity from payloads
- Preserve binary data (File, Blob, FormData) in API requests
- Fix Generate CSR modal v-model binding for proper open/close
- Remove debug logging and fix jest configuration
- Fix responsive text visibility in AppHeader
- Update BVTableSelectableMixin for proper row selection
- Fix BVToastMixin VNode rendering for Vue 3
Vue 3 modal fixes (lazy-loaded components):
- Add v-model support to network modals (ModalIpv4, ModalIpv6, ModalDns,
ModalHostname, ModalMacAddress, ModalDefaultGateway) by adding
modelValue prop, watcher on modelValue that triggers show(), and
update:modelValue emit in resetForm
- Remove lazy loading from TableIpv4, TableIpv6, TableDns to ensure
modal component refs are available when v-model triggers
- Fix modal title accessibility by adding title prop to modals
(ModalAddDestination, ModalUser, ModalAddRoleGroup, etc.)
i18n fixes (computed properties):
- Fix computed properties using i18n translations in ModalAddRoleGroup,
ModalUser, and ModalUploadCertificate
- Move useI18n() call from data() to setup() and return i18n object
- Use i18n.t() instead of $t in computed properties and templates
- Prevents "this.$t is not a function" and "_ctx.$t is not a function"
errors in Vue 3
Toast notification fixes:
- Fix toast progress bar visibility by setting progressProps to
undefined (documented way to opt-out) instead of false
- Change modelValue prop to interval for auto-dismiss timing
- Remove temporary CSS display:none hack from _toasts.scss
Network settings fixes:
- Fix checkbox @change event sending Vue reactive proxy object instead
of boolean by casting with !! operator in changeDomainNameState and
related methods in NetworkGlobalSettings.vue
- Ensures API receives plain boolean values in PATCH requests
Navigation fixes:
- Fix nav-link styling for navigation items without children by
replacing b-nav-item with router-link in AppNavigation.vue
- Prevents blue font color from .nav-link CSS class
Configuration updates:
- Remove vue-compat webpack configuration
- Add Vue 3 feature flags (__VUE_OPTIONS_API__, etc.)
- Add .cursor to .gitignore
Accessibility improvements:
- Add autocomplete attributes to password and credential inputs
- Add modal title props for screen reader support
Build completes successfully and UI behavior matches pre-migration.
Extracted features (to be submitted in follow-up PRs):
The following features were removed from this migration PR to keep it
focused on the Bootstrap 5 upgrade. They will be submitted separately:
1. UnresponsiveModal - Server connectivity watchdog with auto-retry
2. Auth token persistence - sessionStorage support for X-Auth-Token
3. Hardware store error handling - try/catch, dynamic discovery
4. Login page connecting indicator - Backend polling with spinner
5. Test updates - Jest setup and snapshot updates for
Bootstrap-Vue-Next
6. Documentation updates - Vue 3 and Vue I18n v9+ API documentation
7. Enhanced ConfirmModal - Feature-rich confirmation dialog with
custom actions
Change-Id: Ib76a58f324b3c926cf536e6e4626e4271639de38
Signed-off-by: Jason Westover <jwestover@nvidia.com>
diff --git a/src/views/SecurityAndAccess/Certificates/Certificates.vue b/src/views/SecurityAndAccess/Certificates/Certificates.vue
index a55b66c..29c1436 100644
--- a/src/views/SecurityAndAccess/Certificates/Certificates.vue
+++ b/src/views/SecurityAndAccess/Certificates/Certificates.vue
@@ -32,11 +32,11 @@
</b-col>
</b-row>
<b-row>
- <b-col xl="11" class="text-right">
+ <b-col xl="11" class="text-end">
<b-button
- v-b-modal.generate-csr
data-test-id="certificates-button-generateCsr"
variant="link"
+ @click="showCsr = true"
>
<icon-add />
{{ $t('pageCertificates.generateCsr') }}
@@ -57,6 +57,7 @@
responsive="md"
show-empty
hover
+ thead-class="table-light"
:busy="isBusy"
:fields="fields"
:items="tableItems"
@@ -94,8 +95,12 @@
</b-row>
<!-- Modals -->
- <modal-upload-certificate :certificate="modalCertificate" @ok="onModalOk" />
- <modal-generate-csr />
+ <modal-upload-certificate
+ v-model="showUpload"
+ :certificate="modalCertificate"
+ @ok="onModalOk"
+ />
+ <modal-generate-csr v-model="showCsr" />
</b-container>
</template>
@@ -115,6 +120,7 @@
import LoadingBarMixin from '@/components/Mixins/LoadingBarMixin';
import { useI18n } from 'vue-i18n';
import i18n from '@/i18n';
+import { useModal } from 'bootstrap-vue-next';
export default {
name: 'Certificates',
@@ -134,11 +140,17 @@
this.hideLoader();
next();
},
+ setup() {
+ const bvModal = useModal();
+ return { bvModal };
+ },
data() {
return {
$t: useI18n().t,
isBusy: true,
modalCertificate: null,
+ showUpload: false,
+ showCsr: false,
fileTypeCorrect: undefined,
fields: [
{
@@ -164,7 +176,7 @@
{
key: 'actions',
label: '',
- tdClass: 'text-right text-nowrap',
+ tdClass: 'text-end text-nowrap',
},
],
};
@@ -240,25 +252,23 @@
},
initModalUploadCertificate(certificate = null) {
this.modalCertificate = certificate;
- this.$bvModal.show('upload-certificate');
+ this.showUpload = true;
},
initModalDeleteCertificate(certificate) {
- this.$bvModal
- .msgBoxConfirm(
- i18n.global.t('pageCertificates.modal.deleteConfirmMessage', {
- issuedBy: certificate.issuedBy,
- certificate: certificate.certificate,
- }),
- {
- title: i18n.global.t('pageCertificates.deleteCertificate'),
- okTitle: i18n.global.t('global.action.delete'),
- cancelTitle: i18n.global.t('global.action.cancel'),
- autoFocusButton: 'ok',
- },
- )
- .then((deleteConfirmed) => {
- if (deleteConfirmed) this.deleteCertificate(certificate);
- });
+ this.confirmDialog(
+ i18n.global.t('pageCertificates.modal.deleteConfirmMessage', {
+ issuedBy: certificate.issuedBy,
+ certificate: certificate.certificate,
+ }),
+ {
+ title: i18n.global.t('pageCertificates.deleteCertificate'),
+ okTitle: i18n.global.t('global.action.delete'),
+ cancelTitle: i18n.global.t('global.action.cancel'),
+ autoFocusButton: 'ok',
+ },
+ ).then((deleteConfirmed) => {
+ if (deleteConfirmed) this.deleteCertificate(certificate);
+ });
},
onModalOk({ addNew, file, type, location }) {
if (addNew) {
@@ -342,6 +352,9 @@
const fileTypeExtension = file.name.split('.').pop();
return fileTypeExtension === 'pem';
},
+ confirmDialog(message, options = {}) {
+ return this.$confirm({ message, ...options });
+ },
},
};
</script>
diff --git a/src/views/SecurityAndAccess/Certificates/ModalGenerateCsr.vue b/src/views/SecurityAndAccess/Certificates/ModalGenerateCsr.vue
index a74a1e4..53364de 100644
--- a/src/views/SecurityAndAccess/Certificates/ModalGenerateCsr.vue
+++ b/src/views/SecurityAndAccess/Certificates/ModalGenerateCsr.vue
@@ -3,6 +3,7 @@
<b-modal
id="generate-csr"
ref="modal"
+ v-model="isVisible"
size="lg"
no-stacking
:title="$t('pageCertificates.modal.generateACertificateSigningRequest')"
@@ -157,7 +158,8 @@
<b-col lg="6">
<b-form-group label-for="contact-person">
<template #label>
- {{ $t('pageCertificates.modal.contactPerson') }} -
+ {{ $t('pageCertificates.modal.contactPerson') }}
+ -
<span class="form-text d-inline">
{{ $t('global.form.optional') }}
</span>
@@ -175,7 +177,8 @@
<b-col lg="6">
<b-form-group label-for="email-address">
<template #label>
- {{ $t('pageCertificates.modal.emailAddress') }} -
+ {{ $t('pageCertificates.modal.emailAddress') }}
+ -
<span class="form-text d-inline">
{{ $t('global.form.optional') }}
</span>
@@ -193,7 +196,8 @@
<b-col lg="12">
<b-form-group label-for="alternate-name">
<template #label>
- {{ $t('pageCertificates.modal.alternateName') }} -
+ {{ $t('pageCertificates.modal.alternateName') }}
+ -
<span class="form-text d-inline">
{{ $t('global.form.optional') }}
</span>
@@ -218,7 +222,8 @@
data-test-id="modalGenerateCsr-input-alternateName"
>
<template #add-button-text>
- <icon-add /> {{ $t('global.action.add') }}
+ <icon-add />
+ {{ $t('global.action.add') }}
</template>
</b-form-tags>
</b-form-group>
@@ -311,7 +316,7 @@
</b-row>
</b-container>
</b-form>
- <template #modal-footer="{ ok, cancel }">
+ <template #footer="{ ok, cancel }">
<b-button variant="secondary" @click="cancel()">
{{ $t('global.action.cancel') }}
</b-button>
@@ -328,13 +333,14 @@
</b-modal>
<b-modal
id="csr-string"
+ v-model="showCsrString"
no-stacking
size="lg"
:title="$t('pageCertificates.modal.certificateSigningRequest')"
@hidden="onHiddenCsrStringModal"
>
{{ csrString }}
- <template #modal-footer>
+ <template #footer>
<b-btn variant="secondary" @click="copyCsrString">
<template v-if="csrStringCopied">
<icon-checkmark />
@@ -375,6 +381,13 @@
name: 'ModalGenerateCsr',
components: { IconAdd, IconCheckmark },
mixins: [BVToastMixin, VuelidateMixin],
+ props: {
+ modelValue: {
+ type: Boolean,
+ default: false,
+ },
+ },
+ emits: ['update:modelValue'],
setup() {
return {
v$: useVuelidate(),
@@ -383,6 +396,7 @@
data() {
return {
$t: useI18n().t,
+ showCsrString: false,
form: {
certificateType: null,
country: null,
@@ -410,6 +424,14 @@
};
},
computed: {
+ isVisible: {
+ get() {
+ return this.modelValue;
+ },
+ set(value) {
+ this.$emit('update:modelValue', value);
+ },
+ },
certificateTypes() {
return this.$store.getters['certificates/certificateTypes'];
},
@@ -457,7 +479,7 @@
.dispatch('certificates/generateCsr', this.form)
.then(({ data: { CSRString } }) => {
this.csrString = CSRString;
- this.$bvModal.show('csr-string');
+ this.showCsrString = true;
this.v$.$reset();
});
},
diff --git a/src/views/SecurityAndAccess/Certificates/ModalUploadCertificate.vue b/src/views/SecurityAndAccess/Certificates/ModalUploadCertificate.vue
index 7a40bfb..927163e 100644
--- a/src/views/SecurityAndAccess/Certificates/ModalUploadCertificate.vue
+++ b/src/views/SecurityAndAccess/Certificates/ModalUploadCertificate.vue
@@ -1,18 +1,16 @@
<template>
- <b-modal id="upload-certificate" ref="modal" @ok="onOk" @hidden="resetForm">
- <template #modal-title>
- <template v-if="certificate">
- {{ $t('pageCertificates.replaceCertificate') }}
- </template>
- <template v-else>
- {{ $t('pageCertificates.addNewCertificate') }}
- </template>
- </template>
+ <b-modal
+ id="upload-certificate"
+ ref="modal"
+ :title="modalTitle"
+ @ok="onOk"
+ @hidden="resetForm"
+ >
<b-form>
<!-- Replace Certificate type -->
<template v-if="certificate !== null">
<dl class="mb-4">
- <dt>{{ $t('pageCertificates.modal.certificateType') }}</dt>
+ <dt>{{ i18n.t('pageCertificates.modal.certificateType') }}</dt>
<dd>{{ certificate.certificate }}</dd>
</dl>
</template>
@@ -20,7 +18,7 @@
<!-- Add new Certificate type -->
<template v-else>
<b-form-group
- :label="$t('pageCertificates.modal.certificateType')"
+ :label="i18n.t('pageCertificates.modal.certificateType')"
label-for="certificate-type"
>
<b-form-select
@@ -33,13 +31,13 @@
</b-form-select>
<b-form-invalid-feedback role="alert">
<template v-if="v$.form.certificateType.required.$invalid">
- {{ $t('global.form.fieldRequired') }}
+ {{ i18n.t('global.form.fieldRequired') }}
</template>
</b-form-invalid-feedback>
</b-form-group>
</template>
- <b-form-group :label="$t('pageCertificates.modal.certificateFile')">
+ <b-form-group :label="i18n.t('pageCertificates.modal.certificateFile')">
<form-file
id="certificate-file"
v-model="form.file"
@@ -48,7 +46,7 @@
>
<template #invalid>
<b-form-invalid-feedback role="alert">
- {{ $t('global.form.required') }}
+ {{ i18n.t('global.form.required') }}
</b-form-invalid-feedback>
</template>
</form-file>
@@ -56,14 +54,14 @@
</b-form>
<template #modal-ok>
<template v-if="certificate">
- {{ $t('global.action.replace') }}
+ {{ i18n.t('global.action.replace') }}
</template>
<template v-else>
- {{ $t('global.action.add') }}
+ {{ i18n.t('global.action.add') }}
</template>
</template>
<template #modal-cancel>
- {{ $t('global.action.cancel') }}
+ {{ i18n.t('global.action.cancel') }}
</template>
</b-modal>
</template>
@@ -94,13 +92,14 @@
},
emits: ['ok'],
setup() {
+ const i18n = useI18n();
return {
v$: useVuelidate(),
+ i18n,
};
},
data() {
return {
- $t: useI18n().t,
form: {
certificateType: null,
file: null,
@@ -108,6 +107,11 @@
};
},
computed: {
+ modalTitle() {
+ return this.certificate
+ ? this.i18n.t('pageCertificates.replaceCertificate')
+ : this.i18n.t('pageCertificates.addNewCertificate');
+ },
certificateTypes() {
return this.$store.getters['certificates/availableUploadTypes'];
},