Migrate to Bootstrap 5 and remove Vue compat plugin
Complete migration from Bootstrap 4 (bootstrap-vue) to Bootstrap 5
(bootstrap-vue-next) and remove the @vue/compat plugin to finalize
the Vue 3 migration.
Bundle size impact:
- Before (Bootstrap 4 + bootstrap-vue): 535 KiB gzipped
- After (Bootstrap 5 + bootstrap-vue-next): 511 KiB gzipped
- Reduction: 24 KiB (4.5% smaller)
Package updates:
- Update bootstrap 4.6.2 -> 5.3.8
- Update bootstrap-vue 2.23.1 -> bootstrap-vue-next 0.40.8
- Remove @vue/compat plugin
- Update vue 3.4.29 -> 3.5.24 and related packages
- Add mitt 3.0.1 for global event bus
- Add vue-demi 0.14.10 for library compatibility
Bootstrap 5 CSS updates:
- Replace directional classes: ml/mr/pl/pr -> ms/me/ps/pe
- Replace text-left/right -> text-start/end
- Replace sr-only -> visually-hidden / visually-hidden-focusable
- Update media breakpoint xs -> sm (Bootstrap 5 removed xs)
- Update color functions: gray("700") -> $gray-700
- Add form-switch border-radius for curved toggles
- Update alert, table, toast, form, and button styles
Bootstrap-Vue-Next API changes:
- Use createBootstrap() for plugin registration
- Update modal footer slots: #modal-footer -> #footer
- Fix form select events: @change -> @update:model-value
- Add v-model bindings to modals instead of manual show()/hide()
- Update toast system with custom plugin wrapping useToast()
- Register components and directives explicitly
Vue 3 specific updates:
- Replace $root.$emit with mitt event bus (eventBus.js)
- Update render function from h(App) to createApp(App)
- Add emits option to components
- Use h() instead of $createElement in mixins
- Add Vue 3 compile-time feature flags with documentation
- Update event listeners: $on/$off to eventBus methods
- Add beforeUnmount cleanup for event listeners
New components and significant additions:
- src/plugins/toast.js - Custom toast plugin wrapping useToast() for
Options API compatibility
- src/components/Global/ConfirmModal.vue - Global confirmation dialog
shim to replace Bootstrap 4's removed bvModal.msgBoxConfirm
- src/eventBus.js - mitt-based event bus with Vue 2-compatible API
- Navigation state preservation on page refresh implemented
Critical fixes:
- Add global API interceptor to strip Vue reactivity from payloads
- Preserve binary data (File, Blob, FormData) in API requests
- Fix Generate CSR modal v-model binding for proper open/close
- Remove debug logging and fix jest configuration
- Fix responsive text visibility in AppHeader
- Update BVTableSelectableMixin for proper row selection
- Fix BVToastMixin VNode rendering for Vue 3
Vue 3 modal fixes (lazy-loaded components):
- Add v-model support to network modals (ModalIpv4, ModalIpv6, ModalDns,
ModalHostname, ModalMacAddress, ModalDefaultGateway) by adding
modelValue prop, watcher on modelValue that triggers show(), and
update:modelValue emit in resetForm
- Remove lazy loading from TableIpv4, TableIpv6, TableDns to ensure
modal component refs are available when v-model triggers
- Fix modal title accessibility by adding title prop to modals
(ModalAddDestination, ModalUser, ModalAddRoleGroup, etc.)
i18n fixes (computed properties):
- Fix computed properties using i18n translations in ModalAddRoleGroup,
ModalUser, and ModalUploadCertificate
- Move useI18n() call from data() to setup() and return i18n object
- Use i18n.t() instead of $t in computed properties and templates
- Prevents "this.$t is not a function" and "_ctx.$t is not a function"
errors in Vue 3
Toast notification fixes:
- Fix toast progress bar visibility by setting progressProps to
undefined (documented way to opt-out) instead of false
- Change modelValue prop to interval for auto-dismiss timing
- Remove temporary CSS display:none hack from _toasts.scss
Network settings fixes:
- Fix checkbox @change event sending Vue reactive proxy object instead
of boolean by casting with !! operator in changeDomainNameState and
related methods in NetworkGlobalSettings.vue
- Ensures API receives plain boolean values in PATCH requests
Navigation fixes:
- Fix nav-link styling for navigation items without children by
replacing b-nav-item with router-link in AppNavigation.vue
- Prevents blue font color from .nav-link CSS class
Configuration updates:
- Remove vue-compat webpack configuration
- Add Vue 3 feature flags (__VUE_OPTIONS_API__, etc.)
- Add .cursor to .gitignore
Accessibility improvements:
- Add autocomplete attributes to password and credential inputs
- Add modal title props for screen reader support
Build completes successfully and UI behavior matches pre-migration.
Extracted features (to be submitted in follow-up PRs):
The following features were removed from this migration PR to keep it
focused on the Bootstrap 5 upgrade. They will be submitted separately:
1. UnresponsiveModal - Server connectivity watchdog with auto-retry
2. Auth token persistence - sessionStorage support for X-Auth-Token
3. Hardware store error handling - try/catch, dynamic discovery
4. Login page connecting indicator - Backend polling with spinner
5. Test updates - Jest setup and snapshot updates for
Bootstrap-Vue-Next
6. Documentation updates - Vue 3 and Vue I18n v9+ API documentation
7. Enhanced ConfirmModal - Feature-rich confirmation dialog with
custom actions
Change-Id: Ib76a58f324b3c926cf536e6e4626e4271639de38
Signed-off-by: Jason Westover <jwestover@nvidia.com>
diff --git a/src/views/Settings/Network/TableIpv6.vue b/src/views/Settings/Network/TableIpv6.vue
index bdebc27..bf2e6e1 100644
--- a/src/views/Settings/Network/TableIpv6.vue
+++ b/src/views/Settings/Network/TableIpv6.vue
@@ -47,7 +47,7 @@
{{ $t('pageNetwork.ipv6Addresses') }}
</h3>
</b-col>
- <b-col class="text-right">
+ <b-col class="text-end">
<b-button variant="primary" @click="initAddIpv6Address()">
<icon-add />
{{ $t('pageNetwork.table.addIpv6Address') }}
@@ -57,6 +57,7 @@
<b-table
responsive="md"
hover
+ thead-class="table-light"
:fields="ipv6TableFields"
:items="form.ipv6TableItems"
:empty-text="$t('global.table.emptyMessage')"
@@ -79,6 +80,7 @@
</table-row-action>
</template>
</b-table>
+ <modal-ipv6 v-model="showAddIpv6" />
</page-section>
</template>
@@ -91,9 +93,11 @@
import PageSection from '@/components/Global/PageSection';
import TableRowAction from '@/components/Global/TableRowAction';
import DataFormatterMixin from '@/components/Mixins/DataFormatterMixin';
+import ModalIpv6 from './ModalIpv6.vue';
import { mapState } from 'vuex';
import i18n from '@/i18n';
import { useI18n } from 'vue-i18n';
+import { useModal } from 'bootstrap-vue-next';
export default {
name: 'Ipv6Table',
@@ -103,6 +107,7 @@
IconTrashcan,
PageSection,
TableRowAction,
+ ModalIpv6,
},
mixins: [BVToastMixin, LoadingBarMixin, DataFormatterMixin],
props: {
@@ -111,9 +116,15 @@
default: 0,
},
},
+ setup() {
+ const bvModal = useModal();
+ return { bvModal };
+ },
data() {
return {
$t: useI18n().t,
+ showAddIpv6: false,
+ showDefaultGatewayModal: false,
form: {
ipv6TableItems: [],
},
@@ -140,7 +151,7 @@
key: 'AddressOrigin',
label: i18n.global.t('pageNetwork.table.addressOrigin'),
},
- { key: 'actions', label: '', tdClass: 'text-right' },
+ { key: 'actions', label: '', tdClass: 'text-end' },
],
defaultGateway: '',
defaultGatewayEditable:
@@ -190,7 +201,7 @@
this.getDefaultGateway();
this.$store.dispatch('network/getEthernetData').finally(() => {
// Emit initial data fetch complete to parent component
- this.$root.$emit('network-table-ipv6-complete');
+ require('@/eventBus').default.$emit('network-table-ipv6-complete');
});
},
methods: {
@@ -251,41 +262,42 @@
.catch(({ message }) => this.errorToast(message));
},
initAddIpv6Address() {
- this.$bvModal.show('modal-add-ipv6');
+ this.showAddIpv6 = true;
},
changeDhcp6EnabledState(state) {
- this.$bvModal
- .msgBoxConfirm(
- state
- ? i18n.global.t('pageNetwork.modal.confirmEnableDhcp')
- : i18n.global.t('pageNetwork.modal.confirmDisableDhcp'),
- {
- title: i18n.global.t('pageNetwork.modal.dhcpConfirmTitle', {
- dhcpState: state
- ? i18n.global.t('global.action.enable')
- : i18n.global.t('global.action.disable'),
- }),
- okTitle: state
- ? i18n.global.t('global.action.enable')
- : i18n.global.t('global.action.disable'),
- okVariant: 'danger',
- cancelTitle: i18n.global.t('global.action.cancel'),
- },
- )
- .then((dhcpEnableConfirmed) => {
- if (dhcpEnableConfirmed) {
- this.$store
- .dispatch('network/saveDhcp6EnabledState', state)
- .then((message) => this.successToast(message))
- .catch(({ message }) => this.errorToast(message));
- } else {
- let onDhcpCancel = document.getElementById('dhcp6Switch');
- onDhcpCancel.checked = !state;
- }
- });
+ const dhcpState = state
+ ? i18n.global.t('global.action.enable')
+ : i18n.global.t('global.action.disable');
+ this.confirmDialog(
+ state
+ ? i18n.global.t('pageNetwork.modal.confirmEnableDhcp')
+ : i18n.global.t('pageNetwork.modal.confirmDisableDhcp'),
+ {
+ title: i18n.global.t('pageNetwork.modal.dhcpConfirmTitle', {
+ dhcpState,
+ }),
+ okTitle: dhcpState,
+ okVariant: 'danger',
+ cancelTitle: i18n.global.t('global.action.cancel'),
+ autoFocusButton: 'cancel',
+ },
+ ).then((dhcpEnableConfirmed) => {
+ if (dhcpEnableConfirmed) {
+ this.$store
+ .dispatch('network/saveDhcp6EnabledState', state)
+ .then((message) => this.successToast(message))
+ .catch(({ message }) => this.errorToast(message));
+ } else {
+ let onDhcpCancel = document.getElementById('dhcp6Switch');
+ onDhcpCancel.checked = !state;
+ }
+ });
+ },
+ confirmDialog(message, options = {}) {
+ return this.$confirm({ message, ...options });
},
initDefaultGatewayModal() {
- this.$bvModal.show('modal-default-gateway');
+ this.showDefaultGatewayModal = true;
},
},
};