Fix bug in Overview endless loading
Bug description:
Before this commit there was an endless loading
on blue bar when user entering to the Overview.
Problem was missing `if` statement
after what that promise wasn't be able to finish.
Test:
Step1. Launch webui on browser and see Overview page.
Step2. Wait a while. Blue loading bar finished pulsing.
Change-Id: I2ea3b6f125ca24fcefeea8020c4a903ea018f4f7
Signed-off-by: Konstantin Maskov <sulwirld@gmail.com>
diff --git a/src/store/index.js b/src/store/index.js
index ba248c5..c0b7894 100644
--- a/src/store/index.js
+++ b/src/store/index.js
@@ -14,6 +14,7 @@
import PowerPolicyStore from './modules/Settings/PowerPolicyStore';
import NetworkStore from './modules/Settings/NetworkStore';
import EventLogStore from './modules/Logs/EventLogStore';
+import DumpsStore from './modules/Logs/DumpsStore';
import SensorsStore from './modules/HardwareStatus/SensorsStore';
import ServerLedStore from './modules/HardwareStatus/ServerLedStore';
import SystemStore from './modules/HardwareStatus/SystemStore';
@@ -54,6 +55,7 @@
powerSupply: PowerSupplyStore,
network: NetworkStore,
eventLog: EventLogStore,
+ dumps: DumpsStore,
sensors: SensorsStore,
serverLed: ServerLedStore,
certificates: CertificatesStore,
diff --git a/src/views/Overview/Overview.vue b/src/views/Overview/Overview.vue
index 9960f37..d999be4 100644
--- a/src/views/Overview/Overview.vue
+++ b/src/views/Overview/Overview.vue
@@ -85,8 +85,7 @@
this.$root.$on('overview-server-complete', () => resolve());
});
- Promise.all([
- dumpsPromise,
+ const promises = [
eventsPromise,
firmwarePromise,
inventoryPromise,
@@ -94,7 +93,9 @@
powerPromise,
quicklinksPromise,
serverPromise,
- ]).finally(() => this.endLoader());
+ ];
+ if (this.showDumps) promises.push(dumpsPromise);
+ Promise.all(promises).finally(() => this.endLoader());
},
};
</script>